OPenaz

want to find topic on tankspot, because i'm prefering tank classes, but i couldn't i remember, that hit cap was from 8% (HC bosses) to 15% (25man raid bosses)...but maybe, it's changed with 3.2.2 or maybe i'm totally wrong...not sure now...and have no proof so i will shut up and waiting for fix :)

I'm not happy to write it, but this patch has one mistake...Item 49040 uses Spell 67826 to summon NPC 35642...it is Jeeves...banker and vendor/repairer created by Engineering...if u try item or spell, output is only animation of casting and nothing happened...if i use .npc add 35642, mob is added into game right, but it can't be summoned...tested on Win32...revision 8993 clean mangos without SD2 or patches...commandline output is: WORLD: CMSG_USE_ITEM packet, bagIndex: 255, slot: 25, cast_count: 1, spellid: 67 826, Item: 49040, glyphIndex: 0, unk_flags: 0, data length = 24 STORAGE: CanUseItem item = 49040 Sending SMSG_SPELL_START id=67826 Sending SMSG_SPELL_GO id=67826 Spell 67826 Effect0 : 28 EffectSummonType: Unhandled summon type 12 EDIT: updated code part due to typo in spell id, this is copied from console EDIT2: In spell.dbc: EffectMiscValB1 == 35642, EffectTriggerSpell1 == 2181; In SummonProperties.dbc first column == 2181, 4th column == 12, 6th column == 4096...hope it will help EDIT3: In spell.dbc there is no value 12 for this spell, so where it came from?

ok..so...i asked one of my friends who plays on offi...wthout tabard, player have to gain reputatino with Horde Expedition/Aliance Vanguard...last question is, how many reputation has player to gain after kill trash mobs/bosses...i will ask and post here later EDIT: Sorry for many misstypes...whole night working on server but i have also values 250rep bosses, 10rep elite trash, 5rep non-elite trash

Tested patch from post #24 and works perfectly on revision 8797. But i'm not sure about adding reputation to player without tabard. In this case, whole tabard championing is useless. Maybe, some non-existing faction can be used for all dungeons in northrend, but it will make many errors in log.

* What bug does the patch fix? What features does the patch add? It updates fishing skillup...now it worked perfectly for max skill 375, but for 450, there is little higher chance to gain skill (data taken from WoWwiki and El's fishing guide (due to wowwiki it's best source outside blizzard) * For which repository revision was the patch created? 8797 * Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. No * Who has been writing this patch? Please include either forum user names or email addresses. Me index 8e60f11..5ae3fe8 100644 --- a/src/game/Player.cpp +++ b/src/game/Player.cpp @@ -5218,32 +5218,7 @@ bool Player::UpdateFishingSkill() uint32 SkillValue = GetPureSkillValue(SKILL_FISHING); - int32 chance = SkillValue < 75 ? 100 : 2500/(SkillValue-50); + int32 chance = SkillValue <= 75 ? 100 : 2500/(SkillValue-75); uint32 gathering_skill_gain = sWorld.getConfig(CONFIG_SKILL_GAIN_GATHERING);

Updated, works fine on my server enjoy

OK tested...work as expected, exclude dalaran...In non flying maps, u will summon 100% ground mount, in flying maps, u will have flying mount...dalaran can be checked by zoneid, i will add this later

unitTarget->GetMapId() this is not working...also (Player*)unitTarget too... EDIT: My fault, case typo (GetMapId and Getmapid) EDIT2: compilled, will test in about 10 minutes Test result: In northrend, it can be summoned as ground mount, without cold weather flying...but forget about old world...will update later (players aren't happy due to restarts )

* What bug does the patch fix? What features does the patch add? Allow this mount to be summoned, added dependency on riding skill * For which repository revision was the patch created? 8746 * Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. No * Who has been writing this patch? Please include either forum user names or email addresses. Me, OPenaz index 8e60f11..5ae3fe8 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -5200,8 +5200,36 @@ void Spell::EffectScriptEffect(uint32 effIndex) unitTarget->CastSpell(unitTarget, damage, false); break; } + case 48025: // Headless Horseman Mount + { + if(!unitTarget || unitTarget->GetTypeId() != TYPEID_PLAYER) + return; + + // Prevent stacking of mounts + unitTarget->RemoveSpellsCausingAura(SPELL_AURA_MOUNTED); + + // Triggered spell id dependent of riding skill + uint16 skillval = ((Player*)unitTarget)->GetSkillValue(SKILL_RIDING); + uint32 zone, area; + unitTarget->GetZoneAndAreaId(zone, area); + switch (skillval) + { + case 75: + unitTarget->CastSpell(unitTarget, 51621, true); + return; + case 150: + unitTarget->CastSpell(unitTarget, 48024, true); + return; + case 225: + if ((((Player*)unitTarget)->IsKnowHowFlyIn(((Player*)unitTarget)->GetMapId(), zone) && area != 4395 && ((Player*)unitTarget)->GetMapId() == 571) || ((Player*)unitTarget)->GetMapId() == 530) + unitTarget->CastSpell(unitTarget, 51617, true); + else + unitTarget->CastSpell(unitTarget, 48024, true); + return; + case 300: + if ((((Player*)unitTarget)->IsKnowHowFlyIn(((Player*)unitTarget)->GetMapId(), zone) && area != 4395 && ((Player*)unitTarget)->GetMapId() == 571) || ((Player*)unitTarget)->GetMapId() == 530) + unitTarget->CastSpell(unitTarget, 48023, true); + else + unitTarget->CastSpell(unitTarget, 48024, true); + return; + default: + break; + } + return; + } // Winged Steed of the Ebon Blade case 54729: Known problems: None How it works: Headless Horseman's Mount now scales with your riding with this exceptions: If u have skill higher than 150, u will summon him as 100% ground mount in Azeroth, Kalimdor and Dalaran (except Krasus Landing) If u have skill higher than 150 and not learned spell Cold Weather Flying, u will summon him as 100% ground mount in whole Northrend

as a temp fix, you can simply remove assert line from src/framework/GameSystem/TypeContainer.h

ok...maybe i understand it wrong...but according to tankspot.com, warrior 3.0.3 threat values: heroic strike threat is calculated as: damage+259...in defensive stance, damage is multiplied with 2.073...so one hit about 500dmg will do 1295.5 threat...but it do only 759...missing 500threat, which makes tanking very hard...also battle or berserker stance have 0.8 multiplier, but one hit in battle stance (autoattack) for 200dmg do 200 threat...if i remember right...if i'm wrong, please correct me

this patch works fine, but there is still one problem...tested with addon called threat, which in chat displays threat for every hit...and values are not correct...IMHO, threat is not working properly...with omen tested too...i had 100% threat, healer had 40% and he aggroed...dps will do this about 50-60%...so i don't have feeling, that threat is calculated regullary...but maybe, i'm wrong, can someone tell me?

What bug does the patch fix? What features does the patch add? Alllow works some WotLK kill credit spells (needed for more blizzlike functionality of Troll Patrol quest series) For which repository revision was the patch created? 8435 Is there a thread in the bug report section or at lighthouse? I don't think so, because this is not critical for players Who has been writing this patch? Me, OPenaz --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -148,7 +148,7 @@ pEffect SpellEffects[TOTAL_SPELL_EFFECTS]= &Spell::EffectUnused, // 87 SPELL_EFFECT_ &Spell::EffectUnused, // 88 SPELL_EFFECT_ &Spell::EffectUnused, // 89 SPELL_EFFECT_ - &Spell::EffectUnused, // 90 SPELL_EFFECT_ + &Spell::EffectKillCredit, // 90 SPELL_EFFECT_ &Spell::EffectUnused, // 91 SPELL_EFFECT_ &Spell::EffectEnchantHeldItem, // 92 SPELL_EFFECT_ &Spell::EffectUnused, // 93 SPELL_EFFECT_

you are welcome, new fixes will come i hope

yep...its old...because i have old revision...i don't want to make new revision every day