raftom
-
Posts
24 -
Joined
-
Last visited
Never -
Donations
0.00 GBP
Content Type
Profiles
Bug Tracker
Wiki
Release Notes
Forums
Downloads
Blogs
Events
Posts posted by raftom
-
-
DELETE FROM `spell_bonus_data` WHERE `entry` = 116; INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES ('116','0.8550','0','0', 'Mage - Frost Bolt');
spell power coeff is for patch 3.3.0.
this one above is new bonus for patch 3.3.3 (5% increased spell power coeff)
-
what about the 2nd effect of for example http://www.wowhead.com/spell=61311?
is it somehow connected to this 30% extra reputation?
-
it fixes a bug that teams with rating below 1500 dont gets points as if they where at 1500 rating
http://www.wowwiki.com/Season_6 here is small info
diff --git a/ArenaTeam.cpp b/ArenaTeam2.cpp index ed4ce5b..4d413d6 100644 --- a/ArenaTeam.cpp +++ b/ArenaTeam2.cpp @@ -523,7 +523,10 @@ uint32 ArenaTeam::GetPoints(uint32 MemberRating) float points; uint32 rating = MemberRating + 150 < m_stats.rating ? MemberRating : m_stats.rating; - + + if (sWorld.getConfig(CONFIG_UINT32_ARENA_SEASON_ID) >= 6 && rating <= 1500) + rating = 1500; + if(rating <= 1500) points = (float)rating * 0.22f + 14.0f; else
also try checking arena calculators for more info
plz test and share comments
-
maybe it should be written in the same way as warrior's overpower ?
-
On offy HOTs still do heal when you'r at max health.
and i wonder why is that ... since hots still heal at your max health, and your max heath isnt increasing, the condition (target->health>=target->maxhealth) must be checked somewhere to prevent adding excess health :confused:
-
warbringer uses both 262 and 275
abilities using aura 262 http://thottbot.com/?e=Apply%20Aura%20262
-
i believe this kind of implementation was already put on forum ... dont know why wasn't add to git
anyway thx
-
well to me rune strike should be implemented similar to warrior's overpower... check Unit::ProcDamageAndSpellFor() for REACTIVE_OVERPOWER
-
i rewrite the patch using suggestions posted by lightguard... i hope it will not crash now
-
hmm i dont think ttw affects frostbolt but it should
-
Looks nice except the problem that you remove an aura while using AuraList::const_iterator. Take a look at other examples in the source how this should be done, there are many of them.
hmmm i found this (divine purpose)
AuraMap& Auras = pVictim->GetAuras(); for(AuraMap::const_iterator iter = Auras.begin(); iter != Auras.end() { SpellEntry const *spell = iter->second->GetSpellProto(); if( spell->Mechanic == MECHANIC_STUN || spell->EffectMechanic[iter->second->GetEffIndex()] == MECHANIC_STUN) { pVictim->RemoveAurasDueToSpell(spell->Id); iter = Auras.begin(); } else ++iter; }
is this a better way to write haste part of the glyph?
-
i edited first post... now it's in correct spellfamilyname case and i added remove only negative spell haste aura
plz test and share comments:)
-
finally thx guys
-
now let devs look at this thread and get their opinion about patches
-
so anybody tested ? anyone has any ideas about it?
-
dont thank me ... thank passdVn i just took his idea from rapture patch (8064 rev)
edit: anybody tested it ?
-
What bug does the patch fix? What features does the patch add?
haste part for talent borrowed time
For which repository revision was the patch created?
7643
Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.
didn't find any
Who has been writing this patch? Please include either forum user names or email addresses.
that would be me
diff --git a/Unit.cpp b/Unit2.cpp index c8f19e0..11ca352 100644 --- a/Unit.cpp +++ b/Unit2.cpp @@ -6343,6 +6343,22 @@ bool Unit::HandleProcTriggerSpell(Unit *pVictim, uint32 damage, Aura* triggeredB basepoints0 = damage * triggerAmount / 100 / 3; target = this; } + //borrowed time - haste + else if (auraSpellInfo->SpellIconID == 2899) + { + switch (auraSpellInfo->Id) + { + case 52795: trigger_spell_id = 59887; break; + case 52797: trigger_spell_id = 59888; break; + case 52798: trigger_spell_id = 59889; break; + case 52799: trigger_spell_id = 59890; break; + case 52800: trigger_spell_id = 59891; break; + default: + sLog.outError("Unit::HandleProcTriggerSpell: Spell %u not handled in Borrowed time", auraSpellInfo->Id); + return false; + } + target = pVictim; + } break; } case SPELLFAMILY_DRUID:
edit:
it already worked sry .. i didnt noticed
-
the only entries i was able to find from wowhead and spell.dbc were these below and 33245 (used by some mobs)
DELETE FROM `spell_bonus_data` WHERE `entry` IN ('11426','13031','13032','13033','27134','33405','43038','43039');
INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES
('11426', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 1)'),
('13031', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 2)'),
('13032', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 3)'),
('13033', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 4)'),
('27134', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 5)'),
('33405', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 6)'),
('43038', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 7)'),
('43039', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 8)');
that hardcoded values was on purpose i believe ... just read the comment (to prevent double apply bonus)
-
well i think i should be written in void Aura::HandleAddModifier(bool apply, bool Real) ... http://www.wowhead.com/?spell=31683 just read the effects
-
Yup corrupt at line 19
lol i forgot bracers {} .... corrected first post and it should works now
-
any news ?? anybody tested??
-
on our realm we have rev 7577 and we still have this bug ... i don't know why
i noticed today that after using deathchill, killing machine buff ends as it should
-
I have one question about Ice Barrier... it doesnt seem to get 80% bonus from spell power
http://www.wowwiki.com/Spell_power_coefficient
so i thought it might help
DELETE FROM `spell_bonus_data` WHERE `entry` IN ('11426','13031','13032','13033','27134','33405','43038','43039'); INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES ('11426', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 1)'), ('13031', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 2)'), ('13032', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 3)'), ('13033', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 4)'), ('27134', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 5)'), ('33405', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 6)'), ('43038', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 7)'), ('43039', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 8)');
if sth is wrong with entries plz correct it
[patch] Small Ignite Fix
in ... rejectedOld
Posted
i kinda couldn't find anything that looks like 40% for spell http://www.wowhead.com/spell=12848
rank 1 and 5 have also value:1 with applyaura: dummy in effect box (no idea if it's important or not)
anyway... this fix is wondering on forum for such a long time, it 'd be nice if sb actually apply this