[Warrior] Execute not working properly

[Warrior] Execute not working properly

Hi,

Just reporting a known Mangos-Zero (and I think Mangos-One too but didn't validate) bug. When warrior is using execute, it can be that the animation is done, rage is taken (partially) but nothing appear on the client as it should. In practice, this behavior results from a miss/parry/avoid while processing the original spell sent by the client. To display properly the result on the client, it's expecting spell id 20647 to be returned to it.

Also, fixing the above reveals another bug then, because spell 20647 is also processed, you can actually miss/parry/avoid it as well meaning there's 2 roll for the same spell (and I don't think it's the goal of it) creating a situation even worse: all the rage is gone, animation started, nothing displayed. After analyzing the spells in DBC, I've found out that Initial spell Id's get an EquippedClassItems property while the spell id 20647 doesn't have such property and it makes hit calculation different than for the initial spell id. Therefore, I propose to update spell 20647 at start-up to never miss the target.

Impacted spell id's:

- 5308
- 20658
- 20660
- 20661
- 20662

- 20647

I'm filling this bug to "normalize" the situation of my pull request: [url]https://github.com/mangoszero/server/commit/cda3ebf959502147601f2b31fc9410c00e49e62f[/url]

Ps : If not clear enough, will make a drawing to show how it works actually and how I think it should work.