Jump to content

Bjago

Members
  • Posts

    2
  • Joined

  • Last visited

  • Donations

    0.00 GBP 

Core Infomation

  • Core
    Two

Bjago's Achievements

Newbie

Newbie (1/3)

1

Reputation

  1. Code originally changed from bool prof = SpellMgr::IsProfessionSpell(trainer_spell->learnedSpell); // check level requirement if (!prof || GetSession()->GetSecurity() < AccountTypes(sWorld.getConfig(CONFIG_UINT32_TRADE_SKILL_GMIGNORE_LEVEL))) { if (getLevel() < reqLevel) { return TRAINER_SPELL_RED; } } on lines 4748-4757 in v22.02.65 to this bool prof = SpellMgr::IsProfessionSpell(trainer_spell->spell); if (prof || trainer_spell->reqLevel && (trainer_spell->reqLevel) < reqLevel) { return TRAINER_SPELL_RED; } on lines 4763-4767 in v22.02.67 I thought it could have happened accidentally that the function getLevel() was not taken over bc it worked before and now it's discarded. Made not much sense imho but I am no software developer so I haven't been able to figure out more about what's behind the dynamic properties yet. Just looked for the explicit difference between these two versions for now. Happy to help!
  2. Good evening! I experienced a strange behavior of all the class trainers. On my server all spells are green (and also buyable) every time speaking to a class trainer. But every time after buying one spell, all the others which are usually not buyable at this moment are turning red. There are no wrong spells shown or anything like that. Its just all about the level requirements of the spells, they seemed to be ignored at the beginning. After closing the interface and talking to the trainer again, it's the same behavior, every spell is buyable, but after buying one spell, everything is fine again. I'm not very experienced in these things but I managed to find out that these bug took place within the changes made from v22.02.65 to v22.02.67 and I think it might belong to line 4764 in src\game\Object\Player.cpp where I changed if (prof || trainer_spell->reqLevel && (trainer_spell->reqLevel) < reqLevel) to the following based on the changes made between both versions if (prof || trainer_spell->reqLevel && (getLevel() < reqLevel)) Within the latest repository from git and compiled with VS2022 it works as intended to! Tested again without named change it shows the described behavior. I would appreciate if you can test it and take over this change with the next release. Please don't hesitate to contact me if further informations are needed. Sorry for my bad english :) Kind Regards
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use