Group Loot Zoning Crash

More specifically,
a player opens a group loot and roll begins; he votes for rolled item (either need or greed); no others votes for the item (cannot say is this required); he leaves the instance (by heartstone so on) appearing on another map; when the roll expired, the core crashes. See Group.cpp:1120-1121. The cause is evident.

Use the patch provided.

It accounts for a possibility of missing characters rolling for an item, on the instance map with the mob corpse. These characters will not get the rolled loot, though a roll is done for them and the group is informed about it. If such behaviour looks undesirable, the roll for such characters may be suppressed resulting in just a minor code complication.

Thanks Olion for your patch!

Sorry to be difficult, but I've add the patch. Now when i attempt to compile i get a list of errors. I don't know why this is. Forgive me, my C++ knowledge is low/non existent.

The developers use the latest available version, which is one from the repo branch develop21 now. I switched to the older release20 branch, applied the patch and (after re-creating VS project files with cmake, what is my usual procedure) got the sources compiled cleanly.

It means that you failed to apply the patch somehow. Reset your sources with "git checkout -f" and try again "git apply" ensuring there was no error on each step. Note that the patch does not require any change of the VS project, so if you use pre-built slns, they are ok still.

I realize that it would be much more comfortable to get changes from the repo with "git pull", but the PRs [URL="https://github.com/mangoszero/server/pulls"]are not being merged for months[/URL], and we can do nothing about it.

After a cleanup, [URL="https://github.com/mangoszero/server/pull/82"]PRed[/URL].

Merged and closed.