Jump to content

  • Recursive on all paths, will cause stack overflow

    madmax

    By madmax

      • Status: Awaiting Dev Review
      Main Category: Script (Eluna / SD3)
      Sub-Category: Core Crash
      Version: 21.14 Milestone: 22 Priority: Normal
      Implemented Version: Unset
      Assigned: Rochet2
     Share
    Quote

    I've run into some issues with the Lua Engine for MaNGOSTwo. Everything compiled 22, 0, 0, 1 skipped. Realmd runs fine. Running mangos.exe runs to completion and crashes at the end. Debugging led me to a stack overflow error. After running through clean build and rebuild solution, i sorted output by build order, in module 4 Lua Engine BindingMap.h at line 275, "Recursive on all paths, will cause stack overflow" error. 

    Taken from 

     

     Share
    Go to bugs

    User Feedback

    Recommended Comments

    Rochet2

    Rochet2 33

    Posted

    @khamarr3524 Would it be possible for you to try debug and see what the types of the variables are and where they originate from? Also information about your environment would be nice. For example are you trying to compile 64 bit and so on.
    Assuming you used windows since the report was posted at the end of windows installation guide. Tell us if this is not true.

    This is a first issue about such since the code was added two years ago and I cannot directly see where it would come from.
    Can you try making these changes and report back? https://gist.github.com/Rochet2/d2c4647df88aea3ebf3cb47b32a53baf

    For reference, this is the line reported:
    https://github.com/ElunaLuaEngine/Eluna/blob/c6b9d7364c811825465e82156c56656500ea9a64/BindingMap.h#L275

    khamarr3524

    khamarr3524 0

    Posted (edited)

    Same thing.

    Some stats:
    OS: Windows 10 (Current Update)

    Compiler: MS VS12 2013 (Ultimate)

    Core: MaNGOSTWO (fresh pull)

    Build Type: Release Win32

    Here is the exact error code

    Unhandled exception at 0x0061BE06 in mangosd.exe: 0xC00000FD: Stack overflow (parameters: 0x00000001, 0x00902FFC).

    and attached are the images of my process through running mangos.exe to the debugger.

    Also, these are the lines in the compiler that give the warning.

    Spoiler

    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::BGEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::BGEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>  ElunaUtility.cpp
    4>  GameObjectHooks.cpp
    4>  GossipHooks.cpp
    4>  GroupHooks.cpp
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::GroupEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::GroupEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>  GuildHooks.cpp
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<unsigned __int64>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::CreatureEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<unsigned __int64>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::CreatureEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>  InstanceHooks.cpp
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::GuildEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::GuildEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>  ItemHooks.cpp
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::GossipEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::GossipEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>  LuaEngine.cpp
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::GameObjectEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::GameObjectEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>  LuaFunctions.cpp
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::InstanceEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::InstanceEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>  PacketHooks.cpp
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::ItemEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::ItemEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>  PlayerHooks.cpp
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<unsigned __int64>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::BGEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::GroupEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::GuildEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::PlayerEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::ServerEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::CreatureEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::GossipEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::GameObjectEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::ItemEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::PacketEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::InstanceEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<unsigned __int64>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::BGEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::GroupEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::PlayerEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::GuildEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::CreatureEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::ServerEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::GossipEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::GameObjectEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::PacketEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::ItemEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::InstanceEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<unsigned __int64>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::ServerEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::GuildEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::GroupEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::BGEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::PacketEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::CreatureEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::GameObjectEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::GossipEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::ItemEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::InstanceEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::PlayerEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::VehicleEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<unsigned __int64>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::ServerEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::GuildEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::GroupEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::BGEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::PacketEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::CreatureEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::GameObjectEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::GossipEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::ItemEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::InstanceEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::PlayerEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::VehicleEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>  ServerHooks.cpp
    4>  VehicleHooks.cpp
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::ServerEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::PacketEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<unsigned int>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::PacketEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::ServerEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>  lmarshal.cpp
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::PlayerEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::PlayerEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::VehicleEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::VehicleEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(299): warning C4717: 'hash_helper::_hash_combine<enum Hooks::ServerEvents>' : recursive on all control paths, function will cause runtime stack overflow
    4>f:\code\mangostwo\server\src\modules\eluna\bindingmap.h(275): warning C4717: 'hash_helper::hash<enum Hooks::ServerEvents>' : recursive on all control paths, function will cause runtime stack overflow

    Edit: This is my BindingMap.h file now after applying your fix.

    Spoiler 
    
@264

class hash_helper
{
public:
    typedef std::size_t result_type;

    template <typename... T>
    static inline result_type hash(T const &... t)
    {
        result_type seed = 0;
        _hash_combine(seed, t...);
        return seed;
    }

    template <typename T, typename std::enable_if<std::is_enum<T>::value>::type* = nullptr>
    static inline result_type hash(T const & t)
    {
        return std::hash<typename std::underlying_type<T>::type>()(t);
    }
    
    template <typename T, typename std::enable_if<!std::is_enum<T>::value>::type* = nullptr>
    static inline result_type hash(T const & t)
    {
        return std::hash<T>()(t);
    }

private:
    static inline void _hash_combine(result_type& seed)
    {
    }

    template <typename H, typename... T>
    static inline void _hash_combine(result_type& seed, H const & h, T const &... t)
    {
        seed ^= hash(h) + 0x9e3779b9 + (seed << 6) + (seed >> 2);
        _hash_combine(seed, t...);
    }
};

     

    Edit2: MaNGOSZero builds no problem, have not tested MaNGOSOne

     

    Edit3: MaNGOSTwo builds and runs correctly when disabling Eluna in the EasyBuild.

    Capture.PNG

    Capture.PNG

    Capture.PNG

    Edited by khamarr3524
    Rochet2

    Rochet2 33

    Posted

    @khamarr3524 I may have found the issue.
    Remove the earlier edits and try this: https://gist.github.com/Rochet2/f47056785ccf864e9be481605380d2d7
    The issue may be that the hash function that was supposed to take 2 or more arguments is used instead of the functions that take one argument. The changes above should make the function require at least two arguments so it cannot be confused with the ones that take only one.

    I couldnt reproduce the issue with
    Windows 10, MS VS12 2013 (windows desktop update 5), MaNGOSTWO, Release Win32
    which should be close match to your setup, so I cant test possible fixes myself.

    khamarr3524

    khamarr3524 0

    Posted

    @Rochet2 I'll try the fix now, I ran raw source in Debug win32 and it compiled no errors. I ran it in debug win32 in VS 2017, and it ran fine no errors, but it had errors as well in Release mode. I've tried generating through the EasyBuild for different target compilers but there are cmake errors for some reason and I haven't worked through them yet.

    khamarr3524

    khamarr3524 0

    Posted

    @Rochet2 The fix worked. Compiled in release no recursive errors and mangos.exe works as intended. Thanks for looking into this!

    Rochet2

    Rochet2 33

    Posted

    Alright. I will apply it as a fix to the source then. Thanks for testing.

    btw. on my machine I tried with VS 2013 and VS 2017 and in debug and release and couldnt reproduce it.
    The fault in the code does make sense though. The inconsistency is disturbing.



    Create an account or sign in to comment

    You need to be a member in order to leave a comment

    Create an account

    Sign up for a new account in our community. It's easy!

    Register a new account

    Sign in

    Already have an account? Sign in here.

    Sign In Now

Contact Us

To contact us click here
You can also email us at [email protected]

Privacy Policy | Terms & Conditions

Repositories

The Link to the master list
of MaNGOS repositories:
Copyright © getMaNGOS. All rights Reserved.

This website is in no way associated with or endorsed by Blizzard Entertainment®
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use