[Fix][7523] Prevent use of Divine Shield/Ice Block while carrying BG Flags

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

Prevents a player from holding a flag with Divine Shield and other effects that grant immunity:

-If the player is holding the flag, it will drop.

-The player will not be able to pick up the flag.

For which repository revision was the patch created?

7501

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

There is a fix in the rejected section here

Who has been writing this patch? Please include either forum user names or email addresses.

Me

Patch: http://paste2.org/p/168327

Only Divine Shield, Hand of Protection, Ice Block have SPELL_AURA_SCHOOL_IMMUNITY effect coupled with MECHANIC_IMMUNE_SHIELD.

Didn't find any special definition for spells with EffectMiscValue[0] == 85 using MECHANIC_IMMUNE_SHIELD, so it might be a little hackish. But it seems like it's used for flag-like effects that should be dispelled when a player uses an invulnerability effect (not solely BGs). Here is a list of the spell ids that I found with these attributes:

21546 - Deprecated, used to be used in bg quest

23333 - WSG Flag Spell

23335 - WSG Flag Spell

32430 - Zangarmarsh PVP Battle Standard

32431 - Zangarmarsh PVP Battle Standard

34976 - EotS Flag

45450 - Unused WSG Flag?

29519 - Used in quest, this comment suggests it should also be dispelled on invulnerability.

48039 - Not sure what this is

53797 - Not sure what this is

Edit: Fixed the patch on paste2

[Auntie Mangos]

I am using patches maintained KAPATEJIb, confirme that it works as intended.

[Auntie Mangos]

hello,

patch is not correct, because stealth and feign death should drop flag too ... as is said above. Another thing is that Divine protection (http://www.wowhead.com/?spell=498) should not drop the flag.

I will commit soon KAPATEJIb's patch, but i want to do some testing, before commit.

[Auntie Mangos]

hi,

i rewrited `win's / KAPATEJIb's patch

obsolete!

Pls test it as soon as possible.

I tried and it worked as it should, but i did test it alone and only in WSG.

[Sephiroth1983]

Triplex is also working on this now, lets see if you found something helpful, but as I know he was close to finish.

[False.Genesis]

probably you are using tabs instead of 4 spaces, paste2 displays a tab as 8 spaces

anyway, going to test this, thx

EDIT: code with cleaned up tabs in my repo: http://github.com/fgenesis/mangos/commit/3dc46f59d19a6235b1fa812af0d6823b1e066081

[leak]

I guess this doesn't cover the "taking the flag" part of EOTS and AB?

[nos4r2zod]

Prevents a player from holding a flag with Divine Shield and other effects that grant immunity:

-The player will not be able to pick up the flag

It works for both WSG and EotS. What's the AB flag? :confused:

Edit: I see, I didn't test the EotS/AB base captures with DS yet.

Edit2:

bool Player::CanCaptureTowerPoint()

{

return ( !HasStealthAura() && // not stealthed

!HasInvisibilityAura() && // not invisible

!HasInvulnerabilityAura() && //player cannot use object when he is invulnerable (immune) - (ice block, divine shield, divine intervention ...)

isAlive() // live player

);

}

I'll change it on paste2 later, thanks.

[KAPATEJIb]

Feign Death should also drop flag, i have other patch that haves already fixed case with feign death.

Sorry, but that patch is old, and i've forget a first author name

http://paste2.org/p/168712 patch tested on many servers (because used in my compiled binaries ) and don't have any bugs related...

That patch can be splitted on two parts:

first - implementation of aura flag_lost_selection (drops flag)

second - part, that don't allow to pick up the flag with immunity grant spells

[dereka]

Sorry, but that patch is old, and i've forget a first author name

http://paste2.org/p/168712

author `win

[nos4r2zod]

From what I interpret from leak's post above, immune players shouldn't be able to capture bases either. So shouldn't CanCaptureTowerPoint() also check !isTotalImmune() ?

[Triplex]

no immune players can capture base in EoS by being near the tower place...

[hikikomori18]

From what I interpret from leak's post above, immune players shouldn't be able to capture bases either. So shouldn't CanCaptureTowerPoint() also check !isTotalImmune() ?

its not about whether they capture or not, its about, "the flag is supposed to drop in place" when classes use their "immune" spells, like pally bubbles and iceblocks. As Triplex said, Immune players are allowed to capture bases in EOTS

[Triplex]

rewritten and commited in [7523]. Thx to all who helped.

[Sephiroth1983]

rewritten and commited in [7523]. Thx to all who helped.

Well done, finally I can remove rules about this problem

[DasBlub]

rewritten and commited in [7523]. Thx to all who helped.

will this be backported to mangos-0.12 ? would be really nice

[Triplex]

i don;t know if it is a good idea to backport this patch, because it works with currect dbc files. I'm not sure if those data hasn't been updated recently...

[Sephiroth1983]

Is this patch also checking if someone use invisibility? I didn't test it yet, but I read it checks for stealth, feign death, and so on... but not invis

[Triplex]

yes, invisibility will drop flag

[Sephiroth1983]

yes, invisibility will drop flag

And what about this:

Rocket Boots Xtreme and Rocket Boots Xtreme Lite will cause players to drop a PvP flag if used while carrying one. (Warsong Gulch, Eye of the Storm, and Zangarmarsh)

The spell they should trigger 30452 has

Apply Aura: Force Reaction (1059)

[Triplex]

Apply Aura: Force Reaction (1059)

should be handled in gameobject code (check gameobject's faction relation to faction 1059). I don't have time now to test it, but i think it is not working.