[9346][fix]Nourish: 20% on heal efect increase when afected by regrow, reju...

[rechapa79]

Who wrote this patch:

me again,with special thanks to gsa and Sarjuuk for their imput

What this patch does:

Increase the amount healed by Nourish by 20% when the target is affected by regrow, rejuvenation, lifebloom or wild grown

For what revision this patch was made:

7553+

any thread reporting this bug:

None that i could find. If there is one please tell

--- mangos/src/game/SpellEffects.cpp    2009-03-27 14:41:29.000000000 -0300
+++ patch/src/game/SpellEffects.cpp    2009-03-27 14:22:00.000000000 -0300
@@ -2473,6 +2473,23 @@

            addhealth += tickheal * tickcount;
        }
+    //Nourish 20% of heal increase if target is afected by Druids HOTs
+    else if(m_spellInfo->SpellFamilyFlags&0x0200000000000000LL){
+        Unit::AuraList const& RejorRegr = unitTarget->GetAurasByType(SPELL_AURA_PERIODIC_HEAL);
+           
+            for(Unit::AuraList::const_iterator i = RejorRegr.begin(); i != RejorRegr.end(); ++i)
+            {
+                if((*i)->GetSpellProto()->SpellFamilyName == SPELLFAMILY_DRUID)
+                {
+                   addhealth+=addhealth*0.2;
+           break;
+                }
+            }
+
+            
+
+    }
        else
            addhealth = caster->SpellHealingBonus(unitTarget, m_spellInfo, addhealth, HEAL);

[qsa]

I think you miss Lifebloom (0x1000000000LL) right there.

Haven't tested yet, but looks fine to me.

[rechapa79]

you are right, i missed lifebloom. ill update the patch after i can test it

[Sarjuuk]

Ttwo smal things.

First. The tooltip says its only affected by Rejuv., Regrowth, Lifebloom and Wild Growth. This is already checked with SPELLFAMILY_DRUID over SPELL_AURA_PERIODIC_HEAL. Frenzied Regeneration and Tranquility both aren't periodic Heals but periodic Triggers and druids don't have any other healing over time-spells.

second:

This simplyfication should make it easier to look forward to implement this Glyph-Spell, as it would need to go over every single periodic Heal-Aura and check, weather caster and owner are identical.

maybe the second idea isn't so great, but i simply wanted to mention it ^.^

[rechapa79]

silly me. if Nourish reacts to all Druid HOTs, then is useless to check for individual auras.

patch updated

EDIT: 3.1.0 is not out yet, so lets not get ahead of ourselves

[Mondo01]

anyone test this?

pliz confirm

[krysys]

Hi guys:

Excuse me, but my english is very bad.

I´ve tested this fix. Yes, it add bonus of 20% to heal at spell Nourish, but with this fix, the spell lose heal bonus equip. I think that a possible solution is to put this line in the end of for:

--- mangos/src/game/SpellEffects.cpp 2009-03-27 14:41:29.000000000 -0300

+++ patch/src/game/SpellEffects.cpp 2009-03-27 14:22:00.000000000 -0300

@@ -2473,6 +2473,23 @@

addhealth += tickheal * tickcount;

}

+ //Nourish 20% of heal increase if target is afected by Druids HOTs

+ else if(m_spellInfo->SpellFamilyFlags&0x0200000000000000LL){

+ Unit::AuraList const& RejorRegr = unitTarget->GetAurasByType(SPELL_AURA_PERIODIC_HEAL);

+

+ for(Unit::AuraList::const_iterator i = RejorRegr.begin(); i != RejorRegr.end(); ++i)

+ {

+ if((*i)->GetSpellProto()->SpellFamilyName == SPELLFAMILY_DRUID)

+ {

+ addhealth+=addhealth*0.2;

+ break;

+ }

+ }

+

+ addhealth = caster->SpellHealingBonus(unitTarget, m_spellInfo, addhealth, HEAL);

+

+ }

+ else

+ addhealth = caster->SpellHealingBonus(unitTarget, m_spellInfo, addhealth, HEAL);

If my solution is correct, please, say me.

Thanks.

[Mondo01]

anyone test this?

[bobaz]

since in mangos core there is already coding for nourish heal boost, to make it work you need only to add to your spell_learn_spell table a row:

insert into `spell_learn_spell` (`entry`, `SpellID`, `Active`) values('50464','60137','0');

And reload table.

I'm using mangos build 8587 for 3.1.3 client, so I don't know if this problem was solved in further builds.

If the problem still occures, formal patch app:

What bug does the patch fix? What features does the patch add?

Enables already implemented Nourish Heal Boost.

For which repository revision was the patch created?

8587

Patch:

insert into `spell_learn_spell` (`entry`, `SpellID`, `Active`) values('50464','60137','0');

[Sarjuuk]

omit this post

[Ranger]

go to Unit.cpp

and find: Nourish Heal Boost

...rewrite code and apply SQL fix

[Sarjuuk]

Dont mess them up...

[Glyph of Nourish]

Your Nourish heals an additional 6% for each of your heal over time effects present on the target.

[Nourish Heal Boost]

Your Nourish heals an additional 5% for each of your heal over time effects present on the target.

[VladimirMangos]

since in mangos core there is already coding for nourish heal boost, to make it work you need only to add to your spell_learn_spell table a row:

Strange conclusion... This spell aplied at item set equip, why it must learned with main spell learn For me very wrong suggestion...

master @ b9d2db3a3737ec795b34fb755851c0c65afd5999

[Download]

Not find any file, why not use something more accessable like github gist or paste2.org...

Suggest patch in first post not fully correct. Must be counted only _own_ caster HoTs at target.

[darkstalker]

the hardcoded 0.2 value doesnt look good, might be stored in dbc somewhere

[VladimirMangos]

Rewrited patch added in [9346]. Thank you.

[texen]

I think it´s bugged again in 3.3.3 version.

[Blacktooth]

I think it´s bugged again in 3.3.3 version.

Me too. V 3.3.3a