[Help] Implementing Vehicles

[shakx]

got one problem.. i have windows.. and when i use "git pull" it allways says:

fatal: Not a repository <or any of the parent directories>: .git

i'm using msysGit..

does anyone know what im doing wrong?

[zergtmn]

try

git clone git://github.com/rastikzzz/mangos.git

[shakx]

and what should i do with this directory? sorry but i never done something like that before usually i'm just working with databases

[Alathar]

Does it work if i put vehicle codes inside my source/game mangos repo folder, compile it as I always do and apply the vehicle sqls????

thx! :rolleyes:

[NetSky]

why using tables if you could also use dbc where you already got the needed data this patch is non generic and wasting database resources not needed at all... blizzard already gave you all the data you need look at your dbc folder

[traponinet]

this post can be erased, because I made a new post about rastikzzz's vehicle-patch.

[blitz69]

do you plan on updating anytime soon? whynot just make a single patch file that can patch the mangos core

[mynameis]

Hi, when i try to apply the update by clicking the extended menu fromt tortoise (tortoise-->apply patch), then i choose the directory where are my mangos files then i think should be some message or something that it has been completed or aborted. In my case there is nothing, no error no messages. I don't know what i'm doing wrong. I will appreciate if somebody can help me.

[NetSky]

this patch works fine but i still wonder where he got his sql vehicle data from... testing one by one? and i am wondering why he did not use dbc data and introduced this table based system with this it will get hard to get this vehicle system really completed... we should convert this to use dbc data only but i still did not figure out where to get the required aura data from(dbc) if someone knew would help a lot - different way to solute this : use dbc data for flags,etc use db data for required aura which could also be moved to npc_clickspell table

one other thing that is still missing is the vehicle ehnancements like turrets, etc. -> ulduar leviathan tank for example. but this is just visuals and passenger_seat/spell handling

@ mynameis : use git fetch or git pull but you got to resolve conflicts afterwards

[yad02]

Hello rastikzzz,

can you take some time to up to date your git branch please ?

branch was already in conflict but now, with 3.2.2 switch it's a great conflict

Thank you in advance.

[DaemonCantor]

while waiting 'rastikzzz' to make the update, you can to take this:

the updated rastikzzz's vehicle-patch for MaNGOS revision 8590

download from here: http://filebeam.com/efb83b12b536ff7962be3df28380ea7f

(but now the core supports wow 3.2.2a Live patch)

for 'msysgit' (Git on Windows) use the command:

patch -p1 < name.patch

and if you see any FAILED, then you need to fix it, before to compile the core.

thanks 'rastikzzz'

I just tested this on the .14 branch now that it has been supported and it worked like a charm, No git errors and it COMPILED! finally!:eek:

[Drako]

I have a little question^^

what EXACTLY does this patch fix?

I first thought of something like... robbing the horse in the start zone of the dk...

or maybe using the tanks in Northrend (also in Ulduar)... or enabling you to use the mammoth as 3 persons...

ok... the last thing I couldn't test...

but the other three things just didn't work... also with the patch...

so what does this patch fix?

something else I didn't imagine?

or is it just not ready yet and it will do, what I thought it would?

thx

Drako

[NetSky]

it adds vehicle support working when you got the proper data for vehicle in your sql tables

i want to rewrite this for 0.15 with more generic use of dbc...so there is just required aura left in vehicle data table and get rid of seat table... if it is working i will let you know

[Drako]

ok, so it does, what I thought, it does,

but it needs correct values in the database?

hm, great^^

I hope it won't be that hard to import it to v0.14 because for now I want my server to keep to that version

maybe that'll change later.

regards

Drako

[Drako]

hi, ok, it finally works

now I have a question.

can anyone give me the SQL-Statements for the tanks in Ulduar?^^

or what would be quite better: can anyone tell me, how I can create these statements by myself?

if I see it right there are 3 tables I have to care for, right?

so how do I have to fill them and where will I find the values to fill in?

thx

Drako

[leomkyll]

If anyone out there can enlighten me how to apply the vehicles in my mangos will be very

grateful.

Use updated by mangos

git://github.com/mangos/mangos.git

After cloning this.

I put over his with Git Bash Here

using the command

Git pull git://github.com/rastikzzz/ mangos.git

But it generates a conflict in the merge

$ git pull git://github.com/mangos/mangos.git

remote: Counting objects: 3820, done.

remote: Compressing objects: 100% (1134/1134), done.

emote: Total 3365 (delta 2879), reused 2674 (delta 2231)B/s

Receiving objects: 100% (3365/3365), 1018.21 KiB | 97 KiB/s, done.

Resolving deltas: 100% (2879/2879), completed with 191 local objects.

From git://github.com/mangos/mangos

* branch HEAD -> FETCH_HEAD

Removing contrib/extractor/VC71_AD.sln

Removing contrib/extractor/VC71_ad.vcproj

Auto-merging src/game/AggressorAI.cpp

Auto-merging src/game/BattleGroundMgr.cpp

Auto-merging src/game/Chat.cpp

Auto-merging src/game/Chat.h

Auto-merging src/game/ConfusedMovementGenerator.cpp

CONFLICT (content): Merge conflict in src/game/ConfusedMovementGenerator.cpp

Auto-merging src/game/Creature.cpp

Auto-merging src/game/Creature.h

Auto-merging src/game/CreatureEventAI.cpp

Auto-merging src/game/DBCStores.cpp

Auto-merging src/game/DBCStores.h

Auto-merging src/game/DBCStructure.h

Auto-merging src/game/DBCfmt.h

Auto-merging src/game/FleeingMovementGenerator.cpp

CONFLICT (content): Merge conflict in src/game/FleeingMovementGenerator.cpp

Auto-merging src/game/GameObject.cpp

Auto-merging src/game/GameObject.h

Auto-merging src/game/Group.h

Auto-merging src/game/HomeMovementGenerator.cpp

CONFLICT (content): Merge conflict in src/game/HomeMovementGenerator.cpp

Auto-merging src/game/Level3.cpp

Auto-merging src/game/MiscHandler.cpp

Auto-merging src/game/MotionMaster.cpp

CONFLICT (content): Merge conflict in src/game/MotionMaster.cpp

Auto-merging src/game/MovementHandler.cpp

CONFLICT (content): Merge conflict in src/game/MovementHandler.cpp

Auto-merging src/game/Object.cpp

CONFLICT (content): Merge conflict in src/game/Object.cpp

Auto-merging src/game/Object.h

Auto-merging src/game/ObjectMgr.cpp

Auto-merging src/game/Opcodes.cpp

Auto-merging src/game/PetHandler.cpp

Auto-merging src/game/Player.cpp

Auto-merging src/game/Player.h

Auto-merging src/game/PointMovementGenerator.cpp

CONFLICT (content): Merge conflict in src/game/PointMovementGenerator.cpp

Auto-merging src/game/RandomMovementGenerator.cpp

CONFLICT (content): Merge conflict in src/game/RandomMovementGenerator.cpp

Auto-merging src/game/SharedDefines.h

CONFLICT (content): Merge conflict in src/game/SharedDefines.h

Auto-merging src/game/Spell.cpp

Auto-merging src/game/Spell.h

Auto-merging src/game/SpellAuras.cpp

Auto-merging src/game/SpellEffects.cpp

Auto-merging src/game/SpellHandler.cpp

Auto-merging src/game/TargetedMovementGenerator.cpp

CONFLICT (content): Merge conflict in src/game/TargetedMovementGenerator.cpp

Auto-merging src/game/Unit.cpp

Auto-merging src/game/Unit.h

CONFLICT (content): Merge conflict in src/game/Unit.h

Auto-merging src/game/WaypointMovementGenerator.cpp

CONFLICT (content): Merge conflict in src/game/WaypointMovementGenerator.cpp

Auto-merging src/game/World.cpp

Auto-merging src/game/WorldSession.h

Auto-merging src/game/debugcmds.cpp

Auto-merging src/shared/Database/SQLStorage.cpp

CONFLICT (content): Merge conflict in src/shared/Database/SQLStorage.cpp

Automatic merge failed; fix conflicts and then commit the result.

[leomkyll]

I just tested this on the .14 branch now that it has been supported and it worked like a charm, No git errors and it COMPILED! finally!:eek:

I tried to patch but had some errors in git merge

I used the command patch-p1 <name.patch

on my mangos source 8620

$ patch -p1 < vehicle_mangos_8590.patch

patching file `sql/v01_vehicle_data.sql'

patching file `sql/v02_vehicle_seat_data.sql'

patching file `sql/v03_creature_addon_tables.sql'

patching file `sql/vvv_vehicle_test_data.sql'

patching file `src/game/AggressorAI.cpp'

patching file `src/game/BattleGroundMgr.cpp'

patching file `src/game/BattleGroundSA.h'

patching file `src/game/Chat.cpp'

patching file `src/game/Chat.h'

patching file `src/game/ConfusedMovementGenerator.cpp'

Hunk #1 FAILED at 102.

1 out of 1 hunk FAILED -- saving rejects to src/game/ConfusedMovementGenerator.c

pp.rej

patching file `src/game/Creature.cpp'

Hunk #3 succeeded at 1647 (offset 11 lines).

Hunk #4 succeeded at 2127 (offset 12 lines).

patching file `src/game/Creature.h'

Hunk #3 succeeded at 642 (offset 2 lines).

patching file `src/game/CreatureAI.cpp'

patching file `src/game/CreatureEventAI.cpp'

Hunk #1 succeeded at 847 (offset -7 lines).

patching file `src/game/DBCStores.cpp'

Hunk #1 succeeded at 130 (offset 1 line).

patching file `src/game/DBCStores.h'

patching file `src/game/DBCStructure.h'

patching file `src/game/DBCfmt.h'

patching file `src/game/FleeingMovementGenerator.cpp'

Hunk #1 FAILED at 33.

Hunk #2 FAILED at 353.

Hunk #3 FAILED at 409.

3 out of 3 hunks FAILED -- saving rejects to src/game/FleeingMovementGenerator.c

pp.rej

patching file `src/game/GameObject.cpp'

Hunk #1 succeeded at 51 (offset 1 line).

Hunk #3 succeeded at 1343 (offset 8 lines).

patching file `src/game/GameObject.h'

patching file `src/game/GridNotifiers.cpp'

patching file `src/game/Group.h'

patching file `src/game/GroupHandler.cpp'

patching file `src/game/HomeMovementGenerator.cpp'

Hunk #1 FAILED at 42.

1 out of 1 hunk FAILED -- saving rejects to src/game/HomeMovementGenerator.cpp.r

ej

patching file `src/game/Level3.cpp'

patching file `src/game/MiscHandler.cpp'

patching file `src/game/MotionMaster.cpp'

Hunk #1 FAILED at 76.

1 out of 1 hunk FAILED -- saving rejects to src/game/MotionMaster.cpp.rej

patching file `src/game/MovementHandler.cpp'

patching file `src/game/Object.cpp'

Hunk #1 succeeded at 258 (offset -10 lines).

Hunk #3 succeeded at 299 (offset -10 lines).

Hunk #4 succeeded at 1641 (offset -14 lines).

Hunk #5 FAILED at 1696.

1 out of 5 hunks FAILED -- saving rejects to src/game/Object.cpp.rej

patching file `src/game/Object.h'

Hunk #2 succeeded at 490 (offset -2 lines).

patching file `src/game/ObjectMgr.cpp'

patching file `src/game/ObjectMgr.h'

patching file `src/game/Opcodes.cpp'

patching file `src/game/Pet.cpp'

patching file `src/game/Pet.h'

patching file `src/game/PetHandler.cpp'

patching file `src/game/Player.cpp'

Hunk #1 succeeded at 335 (offset 1 line).

Hunk #3 succeeded at 1613 (offset 1 line).

Hunk #4 succeeded at 7749 (offset 28 lines).

Hunk #5 succeeded at 8043 (offset 6 lines).

Hunk #6 succeeded at 16980 (offset 33 lines).

Hunk #7 succeeded at 16991 (offset 6 lines).

Hunk #8 succeeded at 17047 (offset 33 lines).

Hunk #9 succeeded at 18131 (offset 6 lines).

Hunk #10 succeeded at 18349 (offset 32 lines).

Hunk #11 succeeded at 18374 (offset 6 lines).

Hunk #12 succeeded at 18422 (offset 32 lines).

Hunk #13 succeeded at 18648 (offset 6 lines).

Hunk #14 succeeded at 19137 (offset 32 lines).

Hunk #15 succeeded at 19166 (offset 6 lines).

Hunk #16 succeeded at 19650 (offset 32 lines).

Hunk #17 succeeded at 19710 (offset 6 lines).

patching file `src/game/Player.h'

Hunk #1 succeeded at 2087 (offset 2 lines).

Hunk #3 succeeded at 2216 (offset 2 lines).

patching file `src/game/PointMovementGenerator.cpp'

Hunk #1 FAILED at 42.

1 out of 1 hunk FAILED -- saving rejects to src/game/PointMovementGenerator.cpp.

rej

patching file `src/game/RandomMovementGenerator.cpp'

Hunk #1 FAILED at 129.

1 out of 1 hunk FAILED -- saving rejects to src/game/RandomMovementGenerator.cpp

.rej

patching file `src/game/ReactorAI.cpp'

patching file `src/game/SharedDefines.h'

patching file `src/game/Spell.cpp'

Hunk #3 succeeded at 1406 (offset 2 lines).

Hunk #5 succeeded at 4905 (offset 2 lines).

Hunk #7 succeeded at 5789 (offset 2 lines).

patching file `src/game/Spell.h'

patching file `src/game/SpellAuras.cpp'

Hunk #5 succeeded at 3628 (offset -44 lines).

Hunk #7 succeeded at 3902 (offset -44 lines).

Hunk #9 succeeded at 5939 (offset -44 lines).

Hunk #10 succeeded at 7241 (offset -10 lines).

patching file `src/game/SpellEffects.cpp'

Hunk #3 succeeded at 3253 (offset 1 line).

Hunk #5 succeeded at 6945 (offset 1 line).

patching file `src/game/SpellHandler.cpp'

Hunk #3 succeeded at 560 (offset 2 lines).

patching file `src/game/TargetedMovementGenerator.cpp'

Hunk #1 FAILED at 46.

Hunk #2 FAILED at 132.

2 out of 2 hunks FAILED -- saving rejects to src/game/TargetedMovementGenerator.

cpp.rej

patching file `src/game/Unit.cpp'

Hunk #3 succeeded at 7337 (offset 34 lines).

Hunk #5 succeeded at 9874 (offset 30 lines).

Hunk #7 succeeded at 10271 (offset 34 lines).

Hunk #9 succeeded at 10753 (offset 34 lines).

Hunk #11 succeeded at 10814 (offset 34 lines).

Hunk #13 succeeded at 10851 (offset 34 lines).

Hunk #15 succeeded at 11635 with fuzz 1 (offset 34 lines).

Hunk #16 succeeded at 11635 with fuzz 1 (offset 2 lines).

Hunk #17 succeeded at 11776 (offset 96 lines).

Hunk #18 succeeded at 11938 (offset 2 lines).

Hunk #19 succeeded at 12344 (offset 96 lines).

Hunk #20 succeeded at 12259 (offset 2 lines).

patching file `src/game/Unit.h'

Hunk #4 FAILED at 956.

Hunk #7 succeeded at 1544 (offset 2 lines).

1 out of 8 hunks FAILED -- saving rejects to src/game/Unit.h.rej

patching file `src/game/Vehicle.cpp'

patching file `src/game/Vehicle.h'

patching file `src/game/WaypointMovementGenerator.cpp'

Hunk #1 FAILED at 83.

1 out of 1 hunk FAILED -- saving rejects to src/game/WaypointMovementGenerator.c

pp.rej

patching file `src/game/World.cpp'

Hunk #1 succeeded at 1425 with fuzz 2.

patching file `src/game/WorldSession.h'

patching file `src/game/debugcmds.cpp'

patching file `src/shared/Database/SQLStorage.cpp'

[roby10]

try to implement in where are bugs manually...

[leomkyll]

try to implement in where are bugs manually...

Not wanting .... I'm very noob in programming C + + and Visual Studio. All I can do some very simple things and see how to compile errors. I do not find and fix them ¬ ¬

I'll wait you try to talk

[roby10]

how hard could it be... you got the lines betwen where you should add the line for vehicles... (or implement using git and correct the mistakes ... ex: here in your post for.. (patching file `src/game/ConfusedMovementGenerator.cpp'

Hunk #1 FAILED at 102.

1 out of 1 hunk FAILED -- saving rejects to src/game/ConfusedMovementGenerator.c

pp.rej)

1/1 means u need to and first change wich is:

- if(unit.hasUnitState(UNIT_STAT_ROOT | UNIT_STAT_STUNNED | UNIT_STAT_DISTRACTED))

+ if(unit.hasUnitState(UNIT_STAT_ROOT | UNIT_STAT_STUNNED | UNIT_STAT_DISTRACTED | UNIT_STAT_ON_VEHICLE))

find first line and delete it ..then replace with + line....

and so on...

will work but is not recomanded...

sry for my bad english;)

[Christian Schamara]

Pls Upload a new Patch for this

[taza438]

strange ive implemented the patch successfully but i cant get on any vehicle

why?

the inhumanity oh why?

please help

[cyrex]

Is your character skinny enough to let another character share the same mount, or maybe your characters is fat and drinks too much dwarven beer. Check to see if the character can enter a building, if yes then he/she is skinny, if not then put your character on a diet.

[traponinet]

updated vehicle-patch, to work with revision 8746 of MaNGOS source code.

download from here: vehicle_mangos_8746.patch

for 'msysgit' (Git on Windows) use the command:

patch -p1 < name.patch

Do not use the command: git apply ...

and if you see any FAILED, then you need to fix it, before to compile the core.

thanks 'rastikzzz'

[Tamrael]

rastikzzz's repository still does not update for the new revision of Mangos,

but there is nothing difficult to update vehicle-patch only, to work with revision 8632 of Mangos source code

download from here: http://filebeam.com/33361f1d6ef96215a53d421d39c392fd

for 'msysgit' (Git on Windows) use the command:

patch -p1 < name.patch

and if you see any FAILED, then you need to fix it, before to compile the core.

thanks 'rastikzzz'

Great that worked just fine clean and smooth