[patch][8066] return TeleportTo fix

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

Function TeleportTo should return 6 parameters, not 5.

For which repository revision was the patch created?

8063

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

No. There is no Thread.

Who has been writing this patch? Please include either forum user names or email addresses.

Ambal

diff --git a/src/game/Player.h b/src/game/Player.h
index 02d8f30..734faba 100644
--- a/src/game/Player.h
+++ b/src/game/Player.h
@@ -885,7 +885,7 @@ class MANGOS_DLL_SPEC Player : public Unit

        bool TeleportTo(WorldLocation const &loc, uint32 options = 0)
        {
-            return TeleportTo(loc.mapid, loc.coord_x, loc.coord_y, loc.coord_z, options);
+            return TeleportTo(loc.mapid, loc.coord_x, loc.coord_y, loc.coord_z, loc.orientation, options);
        }

        void SetSummonPoint(uint32 mapid, float x, float y, float z)

[Auntie Mangos]

if writed [NNNN] then OFC it in master, _only_ master comkits have revisions in form [NNNN]

i downloaded latest repo from 0.12 branch but every time i exit bg i got a crash....

help

[Ambal]

This small bug in this function was unnoticed in clean sources just because it is called from very specific BG's code. But with new map system patch this func is really a PITA if not fixed.

[VladimirMangos]

In [8066]. Thank you

[bobaz]

Is this patch on mangos master git branch already? 8064 and 8065 as well?

[VladimirMangos]

if writed [NNNN] then OFC it in master, _only_ master comkits have revisions in form [NNNN]

[VladimirMangos]

at just enter and leave?

[pelle]

at just enter and leave?

i don't know, i downloaded the 8067 and i got this error. so i looked into the commits to see if were applied and found that this commit ( http://github.com/mangos/mangos/commit/b78d15978fcaaf421e95b871bf56b8e816bfed83 ) wasn't. (don't know if my error or git error)

now i applied it manually... working.

[VladimirMangos]

I test 0.12 branch and can't repeat crash...

[pelle]

I test 0.12 branch and can't repeat crash...

yes, i fixed that line and i haven't too.

probably my repo hadn't _that_ commit.... :confused: