[fix]Glyph of Icy Veins

[Guest]

What bug does the patch fix? What features does the patch add?

it should fix glyph of icy veins

For which repository revision was the patch created?

8440

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/viewtopic.php?id=7554&highlight=icy+veins

http://paste2.org/p/409065

if you have some improvements just post them

[raftom]

i edited first post... now it's in correct spellfamilyname case and i added remove only negative spell haste aura

plz test and share comments:)

[Lightguard]

Looks nice except the problem that you remove an aura while using AuraList::const_iterator. Take a look at other examples in the source how this should be done, there are many of them.

[raftom]

Looks nice except the problem that you remove an aura while using AuraList::const_iterator. Take a look at other examples in the source how this should be done, there are many of them.

hmmm i found this (divine purpose)

        AuraMap& Auras = pVictim->GetAuras();
                   for(AuraMap::const_iterator iter = Auras.begin(); iter != Auras.end()
                   {
                       SpellEntry const *spell = iter->second->GetSpellProto();
                       if( spell->Mechanic == MECHANIC_STUN ||
                           spell->EffectMechanic[iter->second->GetEffIndex()] == MECHANIC_STUN)
                       {
                           pVictim->RemoveAurasDueToSpell(spell->Id);
                           iter = Auras.begin();
                       }
                       else
                           ++iter;
                   }

is this a better way to write haste part of the glyph?

[Lightguard]

At least it will not crash;)

[raftom]

i rewrite the patch using suggestions posted by lightguard... i hope it will not crash now

[stfx]

Different patch was added in [11676] which fixed it. Thanks though