[patch][6067] More Spell Replacement Checks

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

Fixes 8 issues with spells replacing each other:

Nature's Grace <=> Wrath of Elune

Druid Feral-T4 (2)Bonus <=> Omen of Clarity

Stamina (from the Scrolls) <=> Leader of the Pack

Defensive Stance <=> Scroll of Protection

Impr. Concussive Shot <=> Concussive Shot

Detect Invisibility <=> Mana Shield

Bloodlust <=> Bloodthirst

Fire Resistance Aura <=> Combustion

For which SubVersion revision was the patch created?

<strike>r6028</strike> <strike>r6031</strike> r6036

Is there a thread in the bug report section? If yes, please add a link to the thread.

none to the ItemSet-part

Leader of the pack

Nature's Grace

Who has been writing this patch? Please include either forum user names or email addresses.

Sarjuuk

notes:

<strike>The check for LotP and Stamina is working, but its a rather cruel way to do it. I had no idea how to do the check working both ways round, if one spell is generic and the other one druid. So it's consisting of two parts in the switch. One set in case: SPELLFAMILY_GENERIC and one in case SPELLFAMILY_DRUID</strike>

Fire Resistance Aura <=> Combustion: please note, that this conflict didn't replace the triggered spell (Combustion), that gives 10% crit, rather the aura, that controls the triggered spells, thus giving the posibility to get permanent 100% crit-Rate on Fire for the Mage.

--------------------------------- End Line

final: pastebin

[Sephiroth1983]

Maybe you can add, scroll of protection <=> defensive stance

[Sarjuuk]

hmm, it's possible, but i fear, it'll suffer vom the same problem like "LotP vs. Stamina"

[thenecromancer]

Don't worry about multi-family checks, there aresome already ( eg. Hamstring and Imp. Hamstring )

[Sarjuuk]

updated first post:

- Defensive Stance vs. Scroll of Protection added

- multi family checks simplified

<strike>functionality not tested though</strike>

/e: LotP vs. Stamina not working for some reason .. invastigating

[gitara]

item id 2802 and Imp Fire Shield - the same problem ;p

[Sarjuuk]

well, i don't know, wheather it's supposed to.

both spells increase your resistance to fire but, have different secondary effects

/e:

<strike>a cookie for the one, finding out, why the part armor-DefStance is working, while stamina-LotP isn't. The structure is perfectly the same.

shortend code part at pastebin.com</strike>

/e ²: Cookie to self, uploading corrected *.diff

/e ³: up and working, no problems noticed : original

[Sephiroth1983]

Another case I remember is mana shield with invisibility detection of warlocks, same icon

[thenecromancer]

Concussive Shot -> Improved Concussive Shot

Bloodthirst -> Bloodlust

[Sarjuuk]

eww...

I'll put it in a separated *.diff, or the original patch isn't going anywhere, because it changes to often.

extended

note: <strike>althoug it should work it's not guaranteed to do so and it's untested</strike> works for me...

[VladimirMangos]

I can wait with review for files tabilization by content, or you can write end line and additional changes place in another patch.

By your choice. Please, place in first post _final_ version for review in any case when _this_ patch will ready.

[Sarjuuk]

updated first post.

hopefully it's sufficient

[Jiraya]

http://www.wowhead.com/?item=23558 should stack with devotion aura

[Sarjuuk]

noted:

But i won't go into it, until the current patch is either accepted or rejected...

[Raimisnk]

Also:

http://www.wowhead.com/?spell=33077 (agility scroll) and http://www.wowhead.com/?spell=43738 (Idol of Terror mangle proc).

[Sephiroth1983]

And (http://www.wowhead.com/?spell=37658) with Evocation

[Flat]

bump for svn -> cause final ;o

[VladimirMangos]

Patch in [6067]. Thank you