[fix][8621] some typos

[zhenya``]

someone can do diffs.

1) Typo in calculate reputation reward

void Player::RewardReputation(Quest const *pQuest)
int32 rep = pQuest->RewRepValue[i];

should be

int32 rep = CalculateReputationGain(pQuest->GetQuestLevel(), pQuest->RewRepValue[i], pQuest->RewRepFaction[i], true);

2) typo in HomeMovementGenerator

uint32 travel_time = i_destinationHolder.SetDestination(traveller, x, y, z);

should be

i_destinationHolder.SetDestination(traveller, x, y, z);
uint32 travel_time = i_destinationHolder.GetTotalTravelTime();

?

3) missing break

case 31930:                                         // Judgements of the Wise
case 63375:                                         // Improved Stormstrike
damage = damage * unitTarget->GetCreateMana() / 100;
default:
break;

should be

case 63375:                                         // Improved Stormstrike
damage = damage * unitTarget->GetCreateMana() / 100;
break;
default:
break;

[Ambal]

Please, provide a patch

[zhenya``]

i can`t do this because i didn`t use git.

[zhenya``]

all okey in pools..

problem with unlimited veins in Visible updates.

i found possible problem with chest with quest items.

           if (loot_type == LOOT_FISHING)
               go->getFishLoot(loot,this);

           go->SetLootState(GO_ACTIVATED);

all freeze go has GO_ACTIVADED lootstate

need to test with

           if (loot_type == LOOT_FISHING)
               go->getFishLoot(loot,this);

           go->SetLootState(GO_JUST_DEACTIVATED);

[VladimirMangos]

No. Send loot open chest, it 'activated'

// For containers: [GO_NOT_READY]->GO_READY (close)->GO_ACTIVATED (open) ->GO_JUST_DEACTIVATED->GO_READY -> ...

When loot release it just deactivated.

Please not make from threads listed unrelated patches.

[VladimirMangos]

About early case:

int32 rep = pQuest->RewRepValue;

Whet you find this. It's already in form "rep = CalculateReputationGain"

uint32 travel_time = i_destinationHolder.SetDestination(traveller, x, y, z);

SetDestination return result return StartTravel(traveller, sendMove);

that return

return i_totalTravelTime;

some lines before calculated as

i_totalTravelTime = traveller.GetTotalTrevelTimeTo(i_destX,i_destY,i_destZ);

3) missing break

agree, but not affect anything. Anyway code style problem and possible leter code problems with changes.

(3) added into [8621]. Thank you.

Other can be considered as rejected.