Jump to content

[fix][8621] some typos


Guest zhenya``
 Share

Recommended Posts

someone can do diffs.

1) Typo in calculate reputation reward

void Player::RewardReputation(Quest const *pQuest)
int32 rep = pQuest->RewRepValue[i];

should be

int32 rep = CalculateReputationGain(pQuest->GetQuestLevel(), pQuest->RewRepValue[i], pQuest->RewRepFaction[i], true);

2) typo in HomeMovementGenerator

uint32 travel_time = i_destinationHolder.SetDestination(traveller, x, y, z);

should be

i_destinationHolder.SetDestination(traveller, x, y, z);
uint32 travel_time = i_destinationHolder.GetTotalTravelTime();

?

3) missing break

case 31930:                                         // Judgements of the Wise
case 63375:                                         // Improved Stormstrike
damage = damage * unitTarget->GetCreateMana() / 100;
default:
break;

should be

case 63375:                                         // Improved Stormstrike
damage = damage * unitTarget->GetCreateMana() / 100;
break;
default:
break;

Link to comment
Share on other sites

  • 2 weeks later...

all okey in pools..

problem with unlimited veins in Visible updates.

i found possible problem with chest with quest items.

           if (loot_type == LOOT_FISHING)
               go->getFishLoot(loot,this);

           go->SetLootState(GO_ACTIVATED);

all freeze go has GO_ACTIVADED lootstate

need to test with

           if (loot_type == LOOT_FISHING)
               go->getFishLoot(loot,this);

           go->SetLootState(GO_JUST_DEACTIVATED);

Link to comment
Share on other sites

About early case:

int32 rep = pQuest->RewRepValue;

Whet you find this. It's already in form "rep = CalculateReputationGain"

uint32 travel_time = i_destinationHolder.SetDestination(traveller, x, y, z);

SetDestination return result return StartTravel(traveller, sendMove);

that return

return i_totalTravelTime;

some lines before calculated as

i_totalTravelTime = traveller.GetTotalTrevelTimeTo(i_destX,i_destY,i_destZ);

3) missing break
agree, but not affect anything. Anyway code style problem and possible leter code problems with changes.

(3) added into [8621]. Thank you.

Other can be considered as rejected.

Link to comment
Share on other sites

 Share

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use