[BUG] in Player::CorrectMetaGemEnchants

[Auntie Mangos]

waza123, as i see, you use hack with durability. That and will be.

If you wanna fix it more correct(but still hackly) Use this.

Place before IsBroken - > return

Or like zhenya said.

[Wowka321]

In

Player::EnchantmentFitsRequirements

there are very seriuos bug, that make possible do exploits with stacking metagems effects. Counting current equipped gem colors should't count gems from broken items.

I was try to add check like

 if(pItem2->IsBroken())
continue;

but i get crash when equip item with metagem

Anybody can to help with this check?

[zhenya``]

try to change

       Item *pItem2 = GetItemByPos( INVENTORY_SLOT_BAG_0, i );
               iif(pItem2 && pItem2->GetProto()->Socket[0].Color)

to

       Item *pItem2 = GetItemByPos( INVENTORY_SLOT_BAG_0, i );
       if(pItem2 && !pItem2->IsBroken() && pItem2->GetProto()->Socket[0].Color)

[Wowka321]

try to change

       Item *pItem2 = GetItemByPos( INVENTORY_SLOT_BAG_0, i );
               iif(pItem2 && pItem2->GetProto()->Socket[0].Color)

to

       Item *pItem2 = GetItemByPos( INVENTORY_SLOT_BAG_0, i );
       if(pItem2 && !pItem2->IsBroken() && pItem2->GetProto()->Socket[0].Color)

No, crash again. :confused:

Main problem here that bonus from meta not removed if EnchantmentFitsRequirements return false (if requirements with count of gems not true) when unequip item with metagem.

[zhenya``]

can you provide crash dump? backtrace..

[Wowka321]

can you provide crash dump? backtrace..

http://paste2.org/p/573502

As possible solution i made exeption in Player::_ApplyItemMods to pass checks

    if(item->IsBroken() && proto->Socket[0].Color)  //This need to remove bonuses from meta if item broken
     {
       CorrectMetaGemEnchants(slot, apply);
       return;
     }

[Nathaniel]

Does it work now?

[Wowka321]

Work what? Bug? On clear core yes. My hack? -yes, it prevent stacking bonuses from meta. I also was try put IsBroken where it need, but i always get crash

So, main problem in Player::_ApplyItemMods (all or part subfunctions). We shoul't make checks for unequip item case and always remove all bonuses when item unequip.

[Nathaniel]

Thank you. I'll try that on my compilation.

But I hope someone more skillful than me is able to create acceptable core patch.

[Hahaokej]

Could you track those people who have used this bug? Would be nice if you could

[rameez]

Ahmm, a really weird question, since im new to this and i havnt contributed to this forum but just wanted to ask you guys that where do we have to put these kinda commands: Item *pItem2 = GetItemByPos( INVENTORY_SLOT_BAG_0, i );

if(pItem2 && !pItem2->IsBroken() && pItem2->GetProto()->Socket[0].Color)

I play on Wowscape server

version 3.2.2a

[waza123]

What about players, who already have armor with durability 0 and with meta socket ?

Ok, bug is fixed, new players can't use it, but old players still can use it, because they have armor with 0 dur + patched.

[Mordaunt]

Is this hack fix still needed? Do I need to change:

    // not apply/remove mods for broken item
   if(item->IsBroken())

to

// not apply/remove mods for broken item
   if(item->IsBroken() && proto->Socket[0].Color)  //This need to remove bonuses from meta if item broken
     {
       CorrectMetaGemEnchants(slot, apply);
       return;
     }

Or is this wrong? Thanks.

[Wowka321]

This still actually.

This part of my code with exploit-fix.

http://paste2.org/p/722692

[Mordaunt]

This still actually.

This part of my code with exploit-fix.

http://paste2.org/p/722692

Perfect! That did the trick! A thanks for you!

[dardennf]

Ok I can confirm every players can reach millions of mana, or 100.000 spellpower etc...

A lot of players know this bug .

[Morphau]

Thanks it's fix the bug, please insert in the source

[VladimirMangos]

Ah, added version suggested originally.... second version just hack.... I see that it possible not fix all cases (will look more) but expected fixed not in like way