[fix][9060] Stealth/Prowl detection

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

fixes detecting stealthed units after restealth

For which repository revision was the patch created?

9055

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/viewtopic.php?id=11680

Who has been writing this patch? Please include either forum user names or email addresses.

me

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 0c7d24e..261d369 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -220,7 +220,7 @@ void Unit::Update( uint32 p_time )
        {
            // m_CombatTimer set at aura start and it will be freeze until aura removing
            if ( m_CombatTimer <= p_time )
-                ClearInCombat();
+                CombatStop();
            else
                m_CombatTimer -= p_time;
        }

this might be not the right place or the best way to fix it, but heres what i got from debug :

i had mage and druid in duel,

1)mage starts to cast fireball

2)mages m_attacking is now druid

3)mages m_attacking->AddAttacker(self)

4)druid has m_attacking null cause he is not attacking

5)combat fades (ClearInCombat - flags only)

6)druid casts prowl(yeah he gets AttackStop(); call in Spell::finish but it won't help cause he needs m_attackers delete on self)

7)now we end up having druid with m_attacking==NULL but with not empty m_attackers

8)I don't think mage's m_attacking is also cleared but AttackStop is never called for him

9)bool Unit::isVisibleForOrDetect(Unit const* u, WorldObject const* viewPoint, bool detect, bool inVisibleList, bool is3dDistance) const

   // If is attacked then stealth is lost, some creature can use stealth too
   if( !getAttackers().empty() )
       return true;

there the check fails because m_attackers list was never cleared

[Sarjuuk]

Well, thats a nice find, and just in time for Christmas too

And it's simple enough. Why do you think it may be wrong in doing so? :>

[przemratajczak]

tested on 9046 with your fix works as intended. Thank you.

[darkstalker]

There is another (maybe related problem) that might be caused by this: get 2 chars of opposite faction, attack one, wait till out of combat and logout victim. The victim char will die on logout.

[laise]

There is another (maybe related problem) that might be caused by this: get 2 chars of opposite faction, attack one, wait till out of combat and logout victim. The victim char will die on logout.

this is happening with the fix or on clean?

       else if (!_player->getAttackers().empty())

in void WorldSession::LogoutPlayer(bool Save) .. yeah guess its related

[darkstalker]

that always happened (didnt try the fix yet)

edit: this fix worked for this case, awesome.

probably this is the cause of getting stuck in combat in battelgrounds too.

[VladimirMangos]

In [9060]. Thank you

[Ice_rulez]

When you enter stealth or prowl it appears like a debuff and you can't leave stealth/prowl using steath/prowl button, only using attacks getting damage or shapestift (druid).

UDB 386

MaNGOS 9100 Linux_x64

Patches: none

SD2 1536

Linux CentOS 64

[wolftang32000]

When you enter stealth or prowl it appears like a debuff and you can't leave stealth/prowl using steath/prowl button, only using attacks getting damage or shapestift (druid).

UDB 386

MaNGOS 9100 Linux_x64

SD2 1536

yeah i had this same problem on mines. did you have any core modifications? cuz that was what i was beginning to assume it would have been. but not too sure on that after looking at this patch

PSDB 279

Mangos 9110 windows_x86

SD2 1539

[tendonsie]

Same prob.

YTDB

MaNgos 9106

Only core mod: Partyfix for horde & alliance.