[9288][spell] Living Ruby Pedant exploit

[przemratajczak]

MaNGOS 9110

ScriptDev2 1537

UDB 386

Spell Living Ruby Pedant and Siphon Essence should do healing exact as it is described in spell tooltip. Instead after passing:

pdamage = pCaster->SpellHealingBonus(m_target, GetSpellProto(), pdamage, DOT, GetStackAmount());

receive spell bonus that makes it heal for insane amount of health. maybe SPELL_AURA_PERIODIC_HEAL and SPELL_AURA_OBS_MOD_HEALTH should have two different cases?

DELETE FROM spell_bonus_data WHERE entry IN (31024,38395,5707,17712);
INSERT INTO spell_bonus_data VALUES
(31024,0,0,0,'Living Ruby Pedant'),
(38395,0,0,0,'Siphon Essence - Malefic Raiment set spell'),
(5707,0,0,0,'Lifestone Regeneration'),
(17712,0,0,0,'Lifestone Healing');

EDIT added:

http://www.wowhead.com/?item=833

[mns]

Must fixed in [9283]

[VladimirMangos]

Must fixed in [9283]

no, in fact commit do opposition thing: make heal taken from any sources to target affected by some auras.

[VladimirMangos]

maybe SPELL_AURA_PERIODIC_HEAL and SPELL_AURA_OBS_MOD_HEALTH should have two different cases?

Maybe but i am not sure for all cases...

Patch itself in [9288]. Thank you