[9082] Disengage

[Feel the Power]

Core: Clear core 9082.

How it SHOULD work: You jump back. Can only be used while in combat.

This spell.

How it DOES work: You can jump back in combat and when you are not in combat.

I could not find a place in the source code processing this spell, as well as similar spells. But apparently, the processing must be done in spell.cpp

[dardennf]

It's currently working for me .

[Rev] 9238 (but it has been fixed a long time ago).

[Ceris]

It's currently working for me .

[Rev] 9238 (but it has been fixed a long time ago).

Yes, the spell itself (backward jump) is working long time, but not as it should work. Disengage could be usable only if you are in combat, but now you can use Disengage even if you are out of combat.

[dardennf]

Oh yes, I didn't see lol...

My bad.

[Ceris]

I looked a little into this and maybe I find something. Maybe, this is totally wrong idea, but maybe not.

I think that in SharedDefines.h, in SpellCastResult is missing suitable failed spell cast result for this spell, something like SPELL_FAILED_NOT_IN_COMBAT

I hope, that Disengage has SPELL_EFECT_LEAP_BACK

then in Spell.cpp into function Spell::CheckCast(bool strict) add around line 4446 (somewhere into "effects of spells that have only one target") this:

case SPELL_EFFECT_LEAP_BACK:
   if(m_spellInfo->Id == 57636)
   {
       if(!m_caster->IsInCombat())
           return SPELL_FAILED_NOT_IN_COMBAT;
   }
   break;