[patch][5722] Channel Interruption

[thenecromancer]

rev 5322

this code makes only little sense - first at all, vanish cannot free from disorient effect and also it is not channeled at all

also root effects shouldn't iterrupt channeling, that makes no sense - don't know if it is related to ranged weapon failing when rooted.. probably not

Index: game/Spell.cpp
===================================================================
--- game/Spell.cpp        (revision 5322)
+++ game/Spell.cpp        (working copy)
@@ -1987,8 +1987,7 @@

                                        // check for incapacitating player states
                                        //Player can use vanish even if he is incapacitated
-                                        if( m_caster->hasUnitState(UNIT_STAT_STUNDED | UNIT_STAT_ROOT | UNIT_STAT_CONFUSED) &&
-                                                !(m_spellInfo->SpellFamilyName == SPELLFAMILY_ROGUE && m_spellInfo->SpellFamilyFlags & SPELLFAMILYFLAG_ROGUE_VANISH))
+                                        if( m_caster->hasUnitState(UNIT_STAT_STUNDED | UNIT_STAT_CONFUSED))
                                                cancel();

                                        // check if player has turned if flag is set

[thenecromancer]

bump, this code still does not make any sense

[KAPATEJIb]

That patch fixes a issue when player can't shoot with ranged weapon (warriors and rogues, with hunter autoshot all ok) in frost nova or roots?

[thenecromancer]

well it can, but I haven't checked

[Sephiroth1983]

I think the problem with root effects is that player is considered like moving while affected

infact instant spells are possible to use

@necro: maybe you can fix root effects to prevent use of Intercept spells?

[thenecromancer]

I guess so, some more spells need to return false cancast even condition is clear ( eg Mana Burn effects should not be casted on targets that are not using mana - including shapeshifted druid )

[KAPATEJIb]

I have test that patch - bug with ranged weapons shoot not fixed

[VladimirMangos]

Patch in [5722]. Thank you