[9298][PATCH]Healing Stream Totem

[[D4RK]Doom-Lord]

What bug does the patch fix? What features does the patch add?

• * Add bonus heal.
  * "Glyph of Healing Stream Totem" http://www.wowhead.com/?item=41533.
  * "Restorative Totems" Talent bonus http://www.wowhead.com/?spell=16187, http://www.wowhead.com/?spell=16205, http://www.wowhead.com/?spell=16206.
  

For which repository revision was the patch created?

9292.

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

https://mangos.lighthouseapp.com/projects/18208/tickets/218-shaman-healing-stream-totem

Who has been writing this patch? Please include either forum user names or email addresses.

[D4RK]Doom-Lord

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
index f9b7926..ed8f188 100644
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -1918,7 +1918,23 @@ void Spell::EffectDummy(uint32 i)
            if (m_spellInfo->SpellFamilyFlags & UI64LIT(0x0000000000002000))
            {
                if (unitTarget)
+                {
+                    if (Unit *owner = m_caster->GetOwner())
+                    damage += int32(owner->SpellBaseHealingBonus(GetSpellSchoolMask(m_spellInfo)) * 0.045f);
+                    // Restorative Totems (Healing Stream Totem)
+                    if (Unit *owner = m_caster->GetOwner())
+                    {
+                        Unit::AuraList const& mDummyAuras = owner->GetAurasByType(SPELL_AURA_DUMMY);
+                        for(Unit::AuraList::const_iterator i = mDummyAuras.begin(); i != mDummyAuras.end(); ++i)
+                            if (((*i)->GetId() == 16187) || ((*i)->GetId() == 16205) || ((*i)->GetId() == 16206) )
+                            damage+=(*i)->GetModifier()->m_amount * damage / 100;
+                    }    
+                    // Glyph Healing Stream Totem
+                    if (Unit *owner = m_caster->GetOwner())
+                        if (Aura *dummy = owner->GetDummyAura(55456))
+                            damage+=dummy->GetModifier()->m_amount * damage / 100;
                    m_caster->CastCustomSpell(unitTarget, 52042, &damage, 0, 0, true, 0, 0, m_originalCasterGUID);
+                }
                return;
            }
            // Mana Spring Totem

[VladimirMangos]

Heal spell itself already have proper data for spell power:

(52042, 0.045, 0, 0, 'Shaman - Healing Stream Totem Triggered Heal'),

if (((*i)->GetId() == 16187) || ((*i)->GetId() == 16205) || ((*i)->GetId() == 16206) )

Not very nice way check ranks..

[VladimirMangos]

With fixed referenced lines added in [9298]. Thank you

[[D4RK]Doom-Lord]

I've tested with "(52042, 0.045, 0, 0, 'Shaman - Healing Stream Totem Triggered Heal')". Seems it doesn't work; maybe because it needs totem's owner spell power.

[VladimirMangos]

totems already have special code for use owner spellpower, but i will test in debug...

[[D4RK]Doom-Lord]

From

uint32 Unit::SpellHealingBonus(Unit *pVictim, SpellEntry const *spellProto, uint32 healamount, DamageEffectType damagetype, uint32 stack)

It gets in:

if (spellProto->DmgClass == SPELL_DAMAGE_CLASS_NONE)
   {
       healamount = healamount * TakenTotalMod;
       return healamount < 0 ? 0 : uint32(healamount);
   }

and never reach this line:

SpellBonusEntry const* bonus = sSpellMgr.GetSpellBonusData(spellProto->Id);

[laise]

it's SpellBaseHealingBonus not SpellHealingBonus

[[D4RK]Doom-Lord]

I've followed code and from effect 10:

void Spell::EffectHeal( uint32 /*i*/ )

it calls

addhealth = caster->SpellHealingBonus(unitTarget, m_spellInfo, addhealth, HEAL);

SpellHealingBonus function is a recursive one in case of totem, so it's called twice first for totem and next for owner. Healing stream has "DmgClass == SPELL_DAMAGE_CLASS_NONE" so in "that if" it returns the second call to first call. I've tested it with checks and never call "SpellBaseHealingBonus()" function.

[DiffuSer]

Totem Rank 9 always healing 25. Without any items or with T10 Regalia set. SPD Bonus do not applying. Any sql needed?

[pasdVn]

As it was already mentioned the problem is, that the heal spell has SPELL_DAMAGE_CLASS_NONE. It would need some bigger changes in the bonus calculation logic to solve this problem clean (I think the original periodic trigger aura should receive the spell bonus, and cast the dummy aura with value...). SQL does not help here^^

[DiffuSer]

Patch from first post working very well. Commited part of this patch isn't working.

[goodbadguy]

Healing totems STILL heal for only 25 regardless of spell power. No updates?

[VladimirMangos]

Related to problem with spell bonuses. I attemp wrte it with avoid hardcoded coeff and just basic bonuses calling

in patch https://gist.github.com/784741 but final heal values not fit to expected as i test Because tested against area spell possible.

[VladimirMangos]

Must be fixed in [11040]