[fix]Glyph of Death's Embrace after 3.3.2

[laise]

What bug does the patch fix? What features does the patch add?

fixes runic power gain only from Death Coil used for healing

For which repository revision was the patch created?

9362

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

haven't seen any

Who has been writing this patch? Please include either forum user names or email addresses.

me

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 7489c45..7074017 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -7730,6 +7730,12 @@ bool Unit::HandleProcTriggerSpell(Unit *pVictim, uint32 damage, Aura* triggeredB
                trigger_spell_id = 50475;
                basepoints[0] = damage * triggerAmount / 100;
            }
+            // Glyph of Death's Embrace
+            else if (auraSpellInfo->Id == 58677)
+            {
+                if (procSpell->Id != 47633)
+                    return false;
+            }
            // Blade Barrier
            else if (auraSpellInfo->SpellIconID == 85)
            {

can't be fixed through DB only, cause player casted spell with dummy effect has same familyflags as death coil used for harm/heal and original spell is positive in check so it will have always "successful positive spell cast" proc flags

[Quriq14]

On 10577, this seems to work also (DB only):

update spell_proc_event set SpellFamilyMaskA0 = 0x80000000,SpellFamilyMaskA1 = 0x80000000,SpellFamilyMaskA2 = 0x80000000 where entry=58677;

[VladimirMangos]

On 10577, this seems to work also (DB only):

update spell_proc_event set SpellFamilyMaskA0 = 0x80000000,SpellFamilyMaskA1 = 0x80000000,SpellFamilyMaskA2 = 0x80000000 where entry=58677;

This is wrong. It just made selection more unexpected spells as trigger source.

[honzakf]

This problem cant be solved only in database, you also have to solve in IsPositive...blah blah if its used on friendly target or hostile. By default it is considered as positivie spell so it will proc when used on heal even when its used for damage

[Quriq14]

This problem cant be solved only in database, you also have to solve in IsPositive...blah blah if its used on friendly target or hostile. By default it is considered as positivie spell so it will proc when used on heal even when its used for damage

Death Coil involves three different spells: a main spell, one for heal and one for damage (find "Death Coil" inside SpellEffects.cpp). I was simply trying to make the glyph be procced only by one of them.

This is wrong. It just made selection more unexpected spells as trigger source.

Thank you for reviewing, anyway. I'll try to find something better.

[iRelax]

error C2440: 'return' : cannot convert from 'bool' to 'SpellAuraProcResult'

Latest Rev.

[zergtmn]

return SPELL_AURA_PROC_FAILED;