Jump to content

[fix]Shaman t10 restoration set bonus


Guest laise

Recommended Posts

What bug does the patch fix? What features does the patch add?

fixes healing over time after chain heal crit & other set bonuses where DoT had wrong tick amount

For which repository revision was the patch created?

9427

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

haven't seen any

Who has been writing this patch? Please include either forum user names or email addresses.

me

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 5a30d82..80fc804 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -6703,6 +6703,7 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu
                case 64928:
                {
                    basepoints0 = int32( triggerAmount * damage / 100 );
+                    basepoints0 = int32( basepoints0 / 2); // basepoints is for 1 tick, not all DoT amount
                    triggered_spell_id = 64930;            // Electrified
                    break;
                }
@@ -6710,9 +6711,18 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu
                case 67228:
                {
                    basepoints0 = int32( triggerAmount * damage / 100 );
+                    basepoints0 = int32( basepoints0 / 3); // basepoints is for 1 tick, not all DoT amount
                    triggered_spell_id = 71824;
                    break;
                }
+                // Item - Shaman T10 Restoration 4P Bonus
+                case 70808:
+                {
+                    basepoints0 = int32( triggerAmount * damage / 100 );
+                    basepoints0 = int32( basepoints0 / 3); // basepoints is for 1 tick, not all DoT amount
+                    triggered_spell_id = 70809;
+                    break;
+                }
            }
            // Storm, Earth and Fire
            if (dummySpell->SpellIconID == 3063)

DELETE FROM `spell_proc_event` WHERE entry = 70808;
INSERT INTO `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `Cooldown`) VALUES('70808','0','11',0x00000100,'0','0','0','2','0','0','0');

i think its more clear to have basepoint0 separate calculations - 1 for general amount and split for 1 tick after

Link to comment
Share on other sites

  • 1 year later...
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use