[9496][Bug] Heroic presence

[Ceris]

mangos: 9496

sd2: for mangos 8900+

UDB 387

ACID 303

How it should work: When in party with some draenei (if you are not draenei), then you must have only one buff of heroic presence. If you are draenei, then you shouldnt have any buffs of heroic presence

How it works now: When you are in group with more than one draenei, then you have chance to gain two buffs of heroic presence at one time (cases described below)

How to reproduce:

1) With other race (for example night elf) then draenei, invite draenei hunter, paladin or warrior to party, you will get heroic presence aura on yourself. Then invite draenei shaman, priest or mage to same party (with first draenei still in party), you will get second buff from heroic presence at the same time and this two draeneis will have one buff of heroic presence.

2) If you are in party with for example two draenei warriors or one draenei warrior and one draenei paladin, then you will get only one buff of heroic presence. Same when you are in party with for example two draenei mages. Draenei charracters from the same group (paladin/warrior/hunter or mage/priest/shaman) as the second draenei character in party will not get any buff from heroic presence, becouse they have this buff on yourselves as passive.

Where is the problem (probably)

in TBC, there were two pasive abilities - heroic presence (spell 6562) for draenei hunters, warriors and paladins which affected melee/ranged hit chance, and inspiring presence (spell 28878) for draenei shamans, priests and mages which affected spell hit chance (check playercreateinfo_spell table).

In WotLK, this two abilities becomes one (with combining melee/ranged and spell hit chance to one stat), but this two auras remained and it looks like they are stacking because they are different spells even with same icon and effects.

[Neo2003]

How it should work: [....] If you are draenei, then you shouldnt have any buffs of heroic presence

This part is wrong. If you are a Draenei you have the buff on you always whatever you are in a group or not. (I play a Shaman Draenei and a DK Draenei on offy).

[dardennf]

Can confirm, dranei should have the buff on himself.

[KAPATEJIb]

then you can simply cancel it with right clicking, this is no good for passive spell