[9715]Passive aura - visual bug discussion

[Ceris]

I think function, in which must be "false" changed to "true" has been modified in revision, where visualisation of draenei racial heroic presence passive aura has been implemented, but I cant found that part in code or in revisions on github

[Ceris]

tested on abominations might and heroic presence, but should work with all raid-wide pasive auras

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index 4e8df4f..1c4c985 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -939,8 +939,8 @@ bool Aura::IsNeedVisibleSlot(Unit const* caster) const
        case SPELL_EFFECT_APPLY_AREA_AURA_FRIEND:
        case SPELL_EFFECT_APPLY_AREA_AURA_PARTY:
        case SPELL_EFFECT_APPLY_AREA_AURA_RAID:
-            // passive auras (except totem auras) do not get placed in caster slot
-            return (m_target != caster || totemAura || !m_isPassive) && m_modifier.m_auraname != SPELL_AURA_NONE;
+            // passive auras must be placed in caster slot
+            return (totemAura || m_isPassive) && m_modifier.m_auraname != SPELL_AURA_NONE;
        default:
            break;
    }

[KAPATEJIb]

tested on abominations might and heroic presence, but should work with all raid-wide pasive auras

Heroic presence shouldn't be showed in caster's buffs because you can just cancel passive aura by right-click.

[Ceris]

Heroic presence shouldn't be showed in caster's buffs because you can just cancel passive aura by right-click.

then we must somewhere in code check, if the cancelled aura is passive, and then not remove her by right clicking, but from my information from retail, ALL passive auras (inclusing heroic presence) is shown as buffs even on owner

[laise]

Heroic presence shouldn't be showed in caster's buffs because you can just cancel passive aura by right-click.

on retail 3.3.3 it is shown.

tested on abominations might and heroic presence, but should work with all raid-wide pasive auras

m_isPassive and totemAura is not needed in check at all, also you forgot - same auras in one raid/party should replace each other & replace lesser rank(self buff like strength on Abomination's Might is left) and you might wanna check Arcane Empowerment after logout =\\

[Ceris]

updated patch version for mangos [9748]

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index 4e8df4f..1c4c985 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -939,8 +939,8 @@ bool Aura::IsNeedVisibleSlot(Unit const* caster) const
        case SPELL_EFFECT_APPLY_AREA_AURA_FRIEND:
        case SPELL_EFFECT_APPLY_AREA_AURA_PARTY:
        case SPELL_EFFECT_APPLY_AREA_AURA_RAID:
-            // passive auras (except totem auras) do not get placed in caster slot
-            return (m_target != caster || totemAura || !m_isPassive) && m_modifier.m_auraname != SPELL_AURA_NONE;
+            // passive auras must be placed in caster slot
+            return (totemAura || m_isPassive) && m_modifier.m_auraname != SPELL_AURA_NONE;
        default:
            break;
    }

diff --git a/src/game/SpellHandler.cpp b/src/game/SpellHandler.cpp
index 2d8c2e1..9dac3b4 100644
--- a/src/game/SpellHandler.cpp
+++ b/src/game/SpellHandler.cpp
@@ -402,6 +402,9 @@ void WorldSession::HandleCancelAuraOpcode( WorldPacket& recvPacket)

    if (spellInfo->Attributes & SPELL_ATTR_CANT_CANCEL)
        return;
+    
+    if (IsPassiveSpell(spellId))
+        return;

    if(!IsPositiveSpell(spellId))
    {

laise: this patch is only for showing passive auras on owners and restricting cancelling passive auras

stacking of buffs with simillar effects has been bugged on mangos from beginning and this patch is not meant to resolve stacking problem of simillar buffs

[laise]

moved related posts from bug report to leave it clean and here is my version of visible passive auras : http://paste2.org/p/774399

DELETE FROM spell_chain WHERE spell_id IN (31579,31582,31583,53137,53138,30802,30808,30809);
INSERT INTO spell_chain VALUES
(31579, 0, 31579, 1, 0),
(31582, 31579, 31579, 2, 0),
(31583, 31582, 31579, 3, 0),

(53137, 0, 53137, 1, 0),
(53138, 53137, 53137, 2, 0),

(30802, 0, 30802, 1, 0),
(30808, 30802, 30802, 2, 0),
(30809, 30808, 30802, 3, 0);