[Patch] Charge - no diminishing returns

[Auntie Mangos]

Rev of MaNGOS: 10051

Bug report: http://getmangos.eu/community/showthread.php?13862-Charge

What does it fix?

from www.wowwiki.com/charge:

Patch 3.1.0 (2009-04-14): Duration of stun effect now lasts 1.5 sec. This effect no longer has diminishing returns.

patch gives Charge DIMINISHING_NONE group, also another version with DIMINISHING_CHARGE group.

PATCH:

http://pastebin.com/pZphMR7a

pls test (with intercept it can be seen working properly)

[LordJZ]

It should diminish with itself.

[michalpolko]

so we should add a Warrior Specific group of DR - DIMINISHING_CHARGE?

will post this case patch in a minute

[Ceris]

It should diminish with itself.

according to http://www.wowwiki.com/Diminishing_return it has DIMINISHING_NONE and no it is not diminished by itself

[michalpolko]

well, yes, but look at the Cyclone DR group - it is also None, but we have DIMINISHING_CYCLONE implemented in MaNGOS, so i suppose that we should implement charge group also. it will be noticed when a player will get charged by 2+ warriors one after another.

so here's the patch with DIMINISHING_CHARGE group: http://pastebin.com/rvGmTYZR

[michalpolko]

in other words, point out a diminishing group on http://www.wowwiki.com/Diminishing_return which is applied to only one skill. there aren't any so there should be a new DR group for charge only.

Please test and comment.

[michalpolko]

bumping in the name of warrior's justice!

fix is simple, so pls at least take a look