[fixed][10208] Remove all movement impairing effects and loss of control

[xarly]

Trinkets PvP and racial spells which should remove all movement impairing effects and all effects which cause loss of control of the character doesn't work anymore.

Items 44098, 44097, ...

Spells 59752

and for example a warrior casting Bladestorm, can be stunned, etc...

I have tested with clean core + YTDB 556

Any one with same bug? These items and spells are critical for PvP

[shinra]

Confirmed on latest revision.

[xarly]

Also druid talent Berserk (50334) and Berserker Rage from warrior (18499) doesn't work.

I hope someone give us a hand

[blackbahamut]

beast within and bestial wrath too are bugged

[MysteriousSouL]

yep it is still bugged on latest revision (on Revision 10216)

[antonio2005pe]

also spells like Berserker Rage from warrior doesnt remove Fear

[LordJZ]

Here's a patch for you guys.

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index f177bb4..c077876 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -10400,9 +10400,10 @@ void Unit::RemoveAurasAtMechanicImmunity(uint32 mechMask, uint32 exceptSpellId,
            ++iter;
        else if (spell->Attributes & SPELL_ATTR_UNAFFECTED_BY_INVULNERABILITY)
            ++iter;
-        else if (iter->second->HasAuraAndMechanicEffectMask(mechMask))
+        else if ((iter->second->GetSpellProto()->Mechanic && (1 << (iter->second->GetSpellProto()->Mechanic-1)) & mechMask)
+            || iter->second->HasAuraAndMechanicEffectMask(mechMask))
        {
-            RemoveAurasDueToSpell(spell->Id);
+            RemoveSpellAuraHolder(iter->second);

            if(auras.empty())
                break;

Tested and works. Written by me.

[Betaman2k]

100 % working on the latest core, big thanks, ready for the master branch :9

[LordJZ]

As pasdVn pointed out, Unit::HasAuraAndMechanicEffectMask is also bugged, so the patch is updated: http://paste2.org/p/921034

[LordJZ]

After [10232] this topic is deprecated and should be locked

[zergtmn]

As pasdVn pointed out, Unit::HasAuraAndMechanicEffectMask is also bugged, so the patch is updated: http://paste2.org/p/921034

Wrong diff. Second part still needed: http://paste2.org/p/921141

[VladimirMangos]

Last part added into [10233]

[jluis859]

beast within and bestial wrath too are bugged

still bugged =/

[VladimirMangos]

Must be fixed in [11540]