[patch] Small Ignite Fix

[dpedroia15]

Nevermind

[darkstalker]

maybe that info is stored in some spell.dbc entry?

[raftom]

maybe that info is stored in some spell.dbc entry?

i kinda couldn't find anything that looks like 40% for spell http://www.wowhead.com/spell=12848

rank 1 and 5 have also value:1 with applyaura: dummy in effect box (no idea if it's important or not)

anyway... this fix is wondering on forum for such a long time, it 'd be nice if sb actually apply this

[Lynx3d]

Hm...my mage does pretty much damage from ignite proccs

I'd say current code is correct, because ignite is a DoT, and basepoints is the damage per tick.

[darkstalker]

it should be percent from caster's spell damage, not percent of damage done.

and maybe for cases like this we should start parsing description text.

[dpedroia15]

I was checking around to make sure that this fix was correct, seeing as it seemed like a kind of obvious thing to miss.

Why would DoT damage be handled per tick?

EDIT: Take a look at Deep Wounds proc handling in core. The basepoints are not handled per tick.

So one of these spells is wrong

[Lynx3d]

it should be percent from caster's spell damage, not percent of damage done.

No, definitely not.

If i may just quote wowhead:

"cause the target to burn for an additional 40% of your spell's damage over 4 sec."

"spell's damage", not "spell damage".

About the basepoints being wrong...

Why would DoT damage be handled per tick?

EDIT: Take a look at Deep Wounds proc handling in core. The basepoints are not handled per tick.

What i see is:

case 12867: basepoints[0] = int32(weaponDamage * 48 / 100); break;
(....)
// 1 tick/sec * 6 sec = 6 ticks
basepoints[0] /= 6;

That looks damn much like damage per tick to me...

[dpedroia15]

You're completely right, I dont know how I missed that >.<

My bad for wasting everyone's time!