[0.12] Don't allow enter in a instance in combat

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

The patch add a check before and after enter in a instance, if this instance isn't in combat.

TODO: Work on Boss add's after a wipe, some time they still in combat with corpse

For which repository revision was the patch created?

S00108

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/viewtopic.php?id=13298

Who has been writing this patch? Please include either forum user names or email addresses.

Me and Emme

https://gist.github.com/68b1d946384fcd1ce152

[Schmoozerd]

I would love to see this feature finally implemented in master, however there might be one problem: we use for quite some encounters - while they are in progress - SPECIAL to save something special with them, so this might need some thinking how to handle the InProcess then

[Xfurry]

Just a small note.

I checked with some friends which are playing on blizz, and they told me that this only applies to raid instances.

In 5 man dungeons normal / heroic doesn't apply, you can enter anytime you want.

[Neo2003]

I also think this does not apply to 5 men instances, only raids.

Moreover, you cannot enter if a boss (level 3) is engaged but you can enter freely when the group fights with trash mobs only.

[Xfurry]

I also think this does not apply to 5 men instances, only raids.

Moreover, you cannot enter if a boss (level 3) is engaged but you can enter freely when the group fights with trash mobs only.

True.

I forgot to mention about the trash mobs in my post.

[Flemzard]

I also think this does not apply to 5 men instances, only raids.

Moreover, you cannot enter if a boss (level 3) is engaged but you can enter freely when the group fights with trash mobs only.

With the trash it's okay because IsEncounterInProgress() is more often use with boss and not trash (or maybe it's a special case)

And yes you're right I've fix this, now it's check is only apply for raid.

https://gist.github.com/68b1d946384fcd1ce152 (First link updated)

I've have also add a forgotten player->isGameMaster()

[stfx]

Alternative fix added in [11783] for master and backported in [s1366] for One. Thanks