[Mangos-0.12] Wrong calculating bonus after recent backportings !

[mns]

[s0242]

For exampel :

use http://www.wowhead.com/search?q=Healing+Stream+Totem+#abilities

big healing

[VladimirMangos]

Maybe wrong coeff in table... As i known MiLk13 prepare updated content for table.

I will look if this core related. But note: we currently not have fully backported all spell_bonus changes so some bug from old master code possible not yet fixed.

Master code req. lot less data in table also.

[mns]

in fact caused GetSpellDuration(spellProto) result .

it's -1

Unit.cpp

       if(damagetype == DOT)
       {
           int32 DotDuration = GetSpellDuration(spellProto);
           // 200% limit
           if(DotDuration > 0)
           {
               if(DotDuration > 30000) DotDuration = 30000;
               if(!IsChanneledSpell(spellProto)) DotFactor = DotDuration / 15000.0f;
               int x = 0;
               for(int j = 0; j < 3; j++)
               {
                   if( spellProto->Effect[j] == SPELL_EFFECT_APPLY_AURA && (
                       spellProto->EffectApplyAuraName[j] == SPELL_AURA_PERIODIC_DAMAGE ||
                       spellProto->EffectApplyAuraName[j] == SPELL_AURA_PERIODIC_LEECH) )
                   {
                       x = j;
                       break;
                   }
               }
               int32 DotTicks = 6;
               if(spellProto->EffectAmplitude[x] != 0)
                   DotTicks = DotDuration / spellProto->EffectAmplitude[x];
               if(DotTicks)
               {
                   DoneAdvertisedBenefit /= DotTicks*int32(stack);
                   TakenAdvertisedBenefit /= DotTicks*int32(stack);
               }
           }
       }

can you any fast solution or i must rollback own server ?

[Oniryck]

Yeah, many coeff seems to be overevaluated. I modified them to find approximately the same score as before the update. Maybe you should do the same ?

[mns]

emergency patch

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index b5abcb9..7b49835 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -7830,7 +7830,8 @@ uint32 Unit::SpellHealingBonus(Unit *pVictim, SpellEntry const *spellProto, uint
                    DoneAdvertisedBenefit /= DotTicks*int32(stack);
                    TakenAdvertisedBenefit /= DotTicks*int32(stack);
                }
-            }
+            }else
+                return healamount;
        }
        // Distribute Damage over multiple effects, reduce by AoE
        CastingTime = GetCastingTimeForBonus( spellProto, damagetype, CastingTime );

[Milk13]

I work on the data for the database, but I don't plan to update the db before the next week end.

I'll share my work soon.

[Oniryck]

I guess the only way is to manage all the spells manually

For the example in this thread:

INSERT INTO `mangos`.`spell_bonus_data`(`entry`,`direct_bonus`,`dot_bonus`,`ap_bonus`,`comments`) VALUES 
( '10461','0','0','0','Shaman - Healing Stream Totem Rank 5'),
( '10460','0','0','0','Shaman - Healing Stream Totem Rank 4'),
( '6372','0','0','0','Shaman - Healing Stream Totem Rank 3'),
( '6371','0','0','0','Shaman - Healing Stream Totem Rank 2'),
( '5672','0','0','0','Shaman - Healing Stream Totem Rank 1');

At least I guess ! Milk13 will do this better than me.

[Milk13]

I begin the update here : http://gist.github.com/598779

I'll update the gist when I have more data.

Thx you to have pointed missing data.

[Oniryck]

Merci pour ton travail Milk13, je te dirais si je constate d'autres sorts à ajouter à la liste.

Thank you for you work, Milk13, I'll tell you if I found more data to add to the table.

[mns]

this can help to found missed spells

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index b5abcb9..7b49835 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -7830,7 +7830,8 @@ uint32 Unit::SpellHealingBonus(Unit *pVictim, SpellEntry const *spellProto, uint
                    DoneAdvertisedBenefit /= DotTicks*int32(stack);
                    TakenAdvertisedBenefit /= DotTicks*int32(stack);
                }
-            }
+            }else
+                sLog.outError("Missed spell_bonus_data : %u",spellProto->Id);
        }
        // Distribute Damage over multiple effects, reduce by AoE
        CastingTime = GetCastingTimeForBonus( spellProto, damagetype, CastingTime );

[VladimirMangos]

not all spell req. table data... most expect default way calculation.

[Oniryck]

not all spell req. table data... most expect default way calculation.

Okay, Vladimir, thanks for this clarification

[Milk13]

http://gist.github.com/598779 updated.