[10841] Drop charges of auras checked in Unit::SelectMagnetTarget()

[michalpolko]

Mangos rev: 10803

What does it fix?

SpellAuras such as Intervene - http://wowhead.com/spell=3411, or Grounding Totem Effect - http://wowhead.com/spell=8178 should drop charges when the target is harmed (data from dbc). Right now Intervene does not do this and it is redirecting attacks for it's whole duration (10 sec.) and not only 1 (2 with glyph) attack.

NOTE:

This patch doesn't completely fix Grounding Totem aura behaviour. When Polymorph is cast on target with Grounding Totem Effect, then the spell is redirected to the totem which is trated as an invalid target for this spell, thus nothing happens, even aura charge isn't dropped. So if You want to fix this problem then there must be something done with checking final target of Polymorph spell and any other of the kind.

Patch: http://pastebin.com/zVT8Uabd

[VladimirMangos]

Spell::CheckTarget can help

[added] i add to patch changes for allow use Spell::CheckTarget and check with its.

[VladimirMangos]

Work good with this addition. Some effects still redirected unexpactadly, look like dot triggred or target self-applied like debufs.

But anyway batter thta before.

In [10841] with described change. Thank you

[laise]

if it should drop charges when target is actually harmed then why do it on target selection ? both Grounding and Intervene have proc flags for on-hit case and also according to wowwiki & wowhead it is possible to redirect more than one spell same time if second spell is cast before first hits. about wrong redirects - seems like it should ignore all SPELL_SCHOOL_MASK_NORMAL(can add check in SelectMagnetTarget or before or maybe drop SPELL_DAMAGE_CLASS_NONE from condition) and AoEs

---

changed to proc using way in [11766]

[michalpolko]

Intervene not dropping charges now. Wrong proc_ex for spell 3411 set?

[laise]

Intervene not dropping charges now. Wrong proc_ex for spell 3411 set?

happens because actual aura is applied on target and damage, being redirected, hits caster, which doesn't have any related auras so can't proc. Need to call proc on target for redirected by this aura's spell, also need to confirm if this aura forces any type of procs happen on target when caster is hit or just this specific aura.