[9767][patch]Don't delete chars finally

[bodeguero]

+1

:lol:

[bulek]

sry for bumping old thread

or

this is patch working with new rev?:huh:

[DasBlub]

i haven't been working on this patch since longer time, and i haven't been keeping my repo up to date. so maybe you get a few merge errors, but it should (theoretically) work with the newest version(s) too. just try it, if you get merge error... merge it and post a diff

sorry, but as already stated in the udb forum, i'm out of time, so i can't update it.

-- DasBlub

[bulek]

i haven't been working on this patch since longer time, and i haven't been keeping my repo up to date. so maybe you get a few merge errors, but it should (theoretically) work with the newest version(s) too. just try it, if you get merge error... merge it and post a diff

sorry, but as already stated in the udb forum, i'm out of time, so i can't update it.

-- DasBlub

ok thanks for the reply:) certainly try and I try to patch it

[DasBlub]

i updated the 0.12 version of it: http://github.com/DasBlub/mangos/tree/no_char_delete-0.12

(well... i deleted + recreated the branch, so you might get errors if you've it already in your repo...)

if i find some time, i'll update the master branch too.

[Raynar]

anybody has the patch for mangos 9000+? It's very interesting...

[bulek]

anybody has the patch for mangos 9000+? It's very interesting...

no dont work

[DasBlub]

i am currently rewriting no_char_delete: http://github.com/DasBlub/mangos/commits/no_char_delete

the base functionality (everything which existed in the old patch) is done, i'm now implementing commands (for the console & ingame).

i'm doing the rewrite on the master branch and will then backport the changes to 0.12 (which should then also be usable on mangoszero).

the following commands will be supported:

.character deleted list {$name | $guid}

.character deleted restore {$name | $guid}

.character deleted delete {$name | $guid}

the list command is already implemented (but only with $name as search possibility, not with $guid), the others will be implemented *soon*.

[DasBlub]

i'm done with implementing it: http://github.com/DasBlub/mangos/commits/no_char_delete

tomorrow, i'll play around a bit with git-rebase to merge the commits (thanks for the tutorial, vladimir! )

if anyone here is using pgsql instead of mysql it would be awesome if you could test this for me, thanks! (just to be *really* sure that it also works there =))

[xeross155]

i'm done with implementing it: http://github.com/DasBlub/mangos/commits/no_char_delete

tomorrow, i'll play around a bit with git-rebase to merge the commits (thanks for the tutorial, vladimir! )

if anyone here is using pgsql instead of mysql it would be awesome if you could test this for me, thanks! (just to be *really* sure that it also works there =))

Tutorial, what tutorial are we talking about here, interactive rebase ? (Sorry for off-topic)

[DasBlub]

Tutorial, what tutorial are we talking about here, interactive rebase ? (Sorry for off-topic)

'tutorial' was maybe the wrong word... vladimir explained me how to work with interactive rebase

(pretty cool stuff, i'll try it this evening... )

[Oceanor]

ok maybe your patch have better features, but if you are interested in just dumping chars > than a level, specifying directory of .sql pdumped files and switch this feature on and off, here is a patch that i wrote some days ago:

Index: Player.cpp
===================================================================
--- Player.cpp  (revisione 917)
+++ Player.cpp  (revisione 918)
@@ -16,6 +16,10 @@
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 */

+#include "Config/Config.h"
+#include "PlayerDump.h"
#include "Common.h"
#include "Language.h"
#include "Database/DatabaseEnv.h"
@@ -4097,6 +4101,31 @@

void Player::DeleteFromDB(uint64 playerguid, uint32 accountId, bool updateRealmChars)
{
+       if(sConfig.GetBoolDefault("DumpActive", 0))
+       {
+               QueryResult *resultPlayer = CharacterDatabase.PQuery("SELECT name, level FROM characters WHERE guid='%u' ", playerguid);
+               if(resultPlayer)
+               {
+                       Field *fields = resultPlayer->Fetch();
+
+                       std::string pname = "";
+                       uint32 plevel = fields[1].GetUInt32();
+                       if(sConfig.GetBoolDefault("DumpTimestamp", 0))
+                               pname = fields[0].GetCppString() + "_" + Log::GetTimestampStr() + ".sql";
+                       else
+                               pname = fields[0].GetCppString() + ".sql";
+
+                       if(plevel >= sConfig.GetIntDefault("DumpMinLevel", 0))
+                       {
+                               std::string directory = sConfig.GetStringDefault("DumpPath", "") + pname;
+                               PlayerDumpWriter().WriteDump(directory, playerguid);
+                       }
+                       delete resultPlayer;
+               }
+       }
+
    uint32 guid = GUID_LOPART(playerguid);

    // convert corpse to bones if exist (to prevent exiting Corpse in World without DB entry)

really simple and short, maybe is not so good because it have to access to database everytime a character is deleted, but works both in 3.2.2a and 3.3.2a (i think also in 2.4.3 because is really simple but not yet tested)

you have to add in mangosd.conf file these lines (explanation excluded if u want ) :

###################################################################################################################
# Pdumps
#
#     DumpActive 
#         Enable/disable dumps before character delete, 0 by default
#
#     DumpPath
#         Path where dump files are stored, default empty
#
#     DumpMinLevel
#         Minimum level to dump characters, default 0
#
#     DumpTimestamp
#         Add timestamps to dumped files, default 0
#
###################################################################################################################

DumpActive = 1
DumpPath = ""
DumpMinLevel = 40
DumpTimestamp = 1

Directory/path works exactly as DataDir or LogsDir.

Hope this helps.

[DasBlub]

i found out, that pgsql does not have the DATE_ADD function, therefore i'll have to redo that part of the patch, probably using c++ and the date_t struct. i'll do that in the next few days and then merge all commits.

@oceanor: my patch adds the "delete option". maybe i can merge pdump with it later (meaning: adding it as another delete option)

[DasBlub]

i'm now done with the implementation, everything seems to work fine: http://github.com/DasBlub/mangos/commits/no_char_delete

if you upgrade from a previous version, make sure that use use that sql update instead of 9999_03_characters_characters.sql: http://gist.github.com/363079

-- DasBlub

[DasBlub]

i am _finally_ done: http://github.com/DasBlub/mangos/commits/no_char_delete

it is now splitted up in two commits, one adding another helper function and one adding the real implementation.

it compiles fine with 9756, but due to the fact, that i didn't update my client yet, i haven't tested it with the new revision.

-- DasBlub

[VladimirMangos]

in [9767]. Thank you