[Mangos One] Fearbug

[Hundekuchen]

If someone is over the threat of creatures victim during the creature is in fear.

the creature only runs behind the new victim and do nothing more after fear.

best regards

[VladimirMangos]

more generic question: if threat must be added to target under fear?

[Hundekuchen]

yes exactly, the easiest way to imitat the bug is: you take 1 priest and 1 paladin... the priest attack a mob and cast psychic scream, than the pala cast righteous defense, and than the mob is buggy.

[VladimirMangos]

I talk not about bug but about expected for retail threat work: is it added to feared target or not added.

Dependent from this need do 2 totally different way fixing.

[Hundekuchen]

it should not added.

[Hundekuchen]

do you have now an idea how to fix it, or someone else?

[mns]

do you have now an idea how to fix it, or someone else?

not related to threat .

in fact finalize motion master broken .

I could not understand finalizing motionmaster system .

But this patch can fix problem.

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 60c41c6..d500b35 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -10920,6 +10920,8 @@ void Unit::SetFeared(bool apply, uint64 const& casterGUID, uint32 spellID, uint3

        if (GetTypeId() != TYPEID_PLAYER && isAlive())
        {
+            clearUnitState(UNIT_STAT_FLEEING|UNIT_STAT_FLEEING_MOVE);
+
            Creature* c = ((Creature*)this);
            // restore appropriate movement generator
            if (getVictim())
@@ -10956,6 +10958,8 @@ void Unit::SetConfused(bool apply, uint64 const& casterGUID, uint32 spellID)

        if (GetTypeId() != TYPEID_PLAYER && isAlive())
        {
+            clearUnitState(UNIT_STAT_CONFUSED|UNIT_STAT_CONFUSED_MOVE);
+
            // restore appropriate movement generator
            if(getVictim())
                GetMotionMaster()->MoveChase(getVictim());

[VladimirMangos]

clearUnitState(UNIT_STAT_FLEEING|UNIT_STAT_FLEEING_MOVE); called in FleeingMovementGenerator<T>::Finalize

and must be called only in FleeingMovementGenerator. if flags not removed then movegen not removed by some reson then.