[patch] Grounding & Totems in general

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

Makes Totems immune to DoTs but no longer to spell wich contains DoT effects.

Grounding Totem is now destroyed after it redirects any kind of offensive spell.

For which revision was the patch created?

6870+ [c950ac20e7ec408d6ee032c0e5daa223b8a22435]

Is there a thread in the bug report section? If yes, please add a link to the thread.

http://getmangos.eu/community/viewtopic.php?id=1487

Patch: http://pastebin.ca/1271087

Who has been writing this patch? Please include either forum user names or email addresses.

Me (Ebrithil) & Maxxie

Other Informations:

Not sure that check inside Totem.cpp is the best solution-way, if someone has a better idea plz tell me

[Auntie Mangos]

For grounding totem, there http://getmangos.eu/community/viewtopic.php?id=2340 was working patch ... that was not accepted probably because of being too hacky (which is imo the case of your patch as well) .

For the "totems immune to all spells with DoT effect" I have patch too http://pastebin.ca/1272859 which tries opposite approach - in spite of checking for certain effect that totem should be immune to (and I think it is all auras, not only periodic damage/leech), check for effect it should not be immune to. Not sure if I covered all necessary effects, though.

Nevertheless, unless this issue is fixed, by using my patch, Ebrithil's patch or another way, I suggers reverting 9b52097262fa3cd9390fd6e79ed930ec3f4f64c8 as it uses wrong way to fix something and causes more serious problem I think.

[Auntie Mangos]

For grounding totem, there http://getmangos.eu/community/viewtopic.php?id=2340 was working patch ... that was not accepted probably because of being too hacky (which is imo the case of your patch as well) .

For the "totems immune to all spells with DoT effect" I have patch too http://pastebin.ca/1272859 which tries opposite approach - in spite of checking for certain effect that totem should be immune to (and I think it is all auras, not only periodic damage/leech), check for effect it should not be immune to. Not sure if I covered all necessary effects, though.

Nevertheless, unless this issue is fixed, by using my patch, Ebrithil's patch or another way, I suggers reverting 9b52097262fa3cd9390fd6e79ed930ec3f4f64c8 as it uses wrong way to fix something and causes more serious problem I think.

Bump, this is serious bug and need to be fixed as soon as possible :\\

[Ebrithil]

The problem is that with the current spell system is impossible to be immune to a single spell effect, instead of all the spell.

Dunno if DiSlord patch solve this, but is a necessary implementation for solving problems like dots immunity

[thenecromancer]

Hi, as for Totem::IsImmunedToSpell, you would better create helper in spell mgr returning if spell has any direct damage effect ( like IsDirectDamageSpell ) it might be rather useful in future. Alternativly you may choose to use state immunity, but that one will not pop immune damage log.

As for destroying grounding totem, don't be so specific, in procflag it only removed aura ( I'm however not sure if it was fixed to send proc with virtual 1 damage to correctly remove on non damaging spells though, but that's another story )

Totems should be probably learnt to die when their aura fades for whatever reason in my opinion.

While your way is nice, you never really know when some NPC with multi-charge totem with plenty of health will be added. Then it won't work nice and will require to be rewritten again.

The problem is that with the current spell system is impossible to be immune to a single spell effect, instead of all the spell.

As I said already: state immunity makes this

[Ebrithil]

Usefull explaination as always, thank you

I'm working in this ^^

[Edoz]

I'm working in this ^^

keep us updated

[Tassader2]

The problem is that with the current spell system is impossible to be immune to a single spell effect, instead of all the spell.

Hmm bosses are immune to frostbolt snare, but not to its damage ... that works (and IMMUNE message appears)

[nick christensson]

anyone still have this patch? the url isnt working

[Unkle Nuke]

This thread is so old I'm not even sure this patch is still needed!

Shouldn't this be considered "abandoned" and moved to rejected?

[laise]

links are broken =\\ anyway totem immunity, should be fixed in [11708].