[Patch] Reflect must only Deflect Freezing Trap

[jluis859]

Mangos Version: 11717

Database Name: ytdb

Custom Patches: przemratajczak

How does it work:

Freezing trap is reflected by Spell Reflection of warrior.

How it SHOULD work:

It must only deflect the freezing trap.

Here the patch:

http://paste2.org/p/1535704

if(spell->SpellFamilyName == SPELLFAMILY_HUNTER && spell->SpellFamilyFlags.test<CF_HUNTER_FREEZING_TRAP_EFFECT>())
return SPELL_MISS_DEFLECT;

I put it into the method SpellMissInfo Unit::SpellHitResult(Unit *pVictim, SpellEntry const *spell, bool CanReflect) of Unit.cpp after:

// Try victim reflect spell
   if (CanReflect)
   {

Here is the complete method:

http://paste2.org/p/1535708

I have some problems with the git software, that's why I've made in this way the patch.

Best regards.

[michalpolko]

this solves problem for only 1 spell, but there are more such spells, that says that this solution is wrong.

maybe:

spell with attribute for reflecting = reflect spell

AoE spell with attribute for reflecting = deflect spell?

[jluis859]

this solves problem for only 1 spell, but there are more such spells, that says that this solution is wrong.

maybe:

spell with attribute for reflecting = reflect spell

AoE spell with attribute for reflecting = deflect spell?

Ok, maybe this is a started patch, do you have a list of what spells must be deflected? I also will look for more information to make a proper patch.

Thanks for your answer

[Princess]

this solves problem for only 1 spell, but there are more such spells, that says that this solution is wrong.

maybe:

spell with attribute for reflecting = reflect spell

AoE spell with attribute for reflecting = deflect spell?

thunderstom is AoE and must be reflected

[Schmoozerd]

guys, provide please spell IDs or it never happened

[michalpolko]

Only knockback of Thunderstorm is reflected, dmg is deflected, something like that ;P

[zergtmn]

MaNGOS doesn't have SpellFamilyFlags.test<> stuff.

And the way chosen is wrong.

[Princess]

typhoon too michalpolko.

[darkstalker]

MaNGOS doesn't have SpellFamilyFlags.test<> stuff.

And the way chosen is wrong.

that's patch for R2's extended ClassFamilyMask