[Patch] Creature Off Hand Attack.

[maxxx2021]

Hi everyone. I would write a patch that NPC could attack the left hand if they have in it the weapon. Your opinion is necessary.

Patch on github:

https://github.com/bwsrv/mangos/commit/c6c041d1309076e9d0063876505e400e19930cfc

Some change on old patch. Fix attack timers and remove new Field:

Patch On Git

[zhenya``]

broken link

[maxxx2021]

fixed

[Schmoozerd]

I am a bit wondering about how the timers should actually work.

atm you let them work that the main-attack is done if possible, and if it was done, the off-attack is skipped - is this correct?

should the off-attack happen on the next tick, or in the same tick, or with some time delay?

also in case both timers are down, but getVictim is out of melee reach, you will need two additional tests for this, I guess this can be improved to be faster.

[maxxx2021]

I am a bit wondering about how the timers should actually work.

atm you let them work that the main-attack is done if possible, and if it was done, the off-attack is skipped - is this correct?

should the off-attack happen on the next tick, or in the same tick, or with some time delay?

also in case both timers are down, but getVictim is out of melee reach, you will need two additional tests for this, I guess this can be improved to be faster.

if (m_creature->isAttackReady(attType) && m_creature->CanReachWithMeleeAttack(m_creature->getVictim()))

If attack ready (change timer) and victim in the attack distance:

m_creature->AttackerStateUpdate(m_creature->getVictim(), attType);

"the main-attack is done if possible, and if it was done, the off-attack is skipped - is this correct?" Yes its right!

P.S. In any way he not strike if the getVictim is far.

[VladimirMangos]

UpdateFields.h is generated file, so please use existed enums instead adding new

[maxxx2021]

UpdateFields.h is generated file, so please use existed enums instead adding new

But in sniff "UNIT_FIELD_BASEATTACKTIME_2" use how time for Off Hand attack.

UNIT_FIELD_BASEATTACKTIME = OBJECT_END + 0x0038

UNIT_FIELD_BASEATTACKTIME + 1 in core = OBJECT_END + 0x0039

now UNIT_FIELD_BASEATTACKTIME_2 = OBJECT_END + 0x0039 How in sniff

[zergtmn]

UNIT_FIELD_BASEATTACKTIME is just array of two int.

SetUInt32Value(UNIT_FIELD_BASEATTACKTIME, main hand attack time);
SetUInt32Value(UNIT_FIELD_BASEATTACKTIME+1, offhand attack time);

[maxxx2021]

UNIT_FIELD_BASEATTACKTIME is just array of two int.

SetUInt32Value(UNIT_FIELD_BASEATTACKTIME, main hand attack time);
SetUInt32Value(UNIT_FIELD_BASEATTACKTIME+1, offhand attack time);

Need remove UNIT_FIELD_BASEATTACKTIME_2 ?

Patch with removed UNIT_FIELD_BASEATTACKTIME_2:

Patch Here

[maxxx2021]

Some change on old patch. Fix attack timers and remove new Field:

Patch On Git

[SilverIce]

In [11825]. Thank you