[spell] Fear

[angeleyes]

MaNGOS rev 11376

SD2: 2036

UDB: 401

Warlock spell "Fear" (spellid= 5782) is removed from target even with the smallest damage, this is not correct.

[sart13]

require implement CrowdControl calculation.

[lillecarl]

require implement CrowdControl calculation.

Are there anywhere to port that from? Then i could possibly try doing it

- LilleCarl

[sart13]

Are there anywhere to port that from? Then i could possibly try doing it

- LilleCarl

Sorry, but port most code from R2 require porting many other required code, implemented to R2 in 2010-2011.

Of course it's possible - not so long ago Laise added to mangos DungeonEncounters, but at the current speed of work on Mangos - I think it takes several years to get to these sections of code ... Besides, I'm much more tolerant to small hacks than mangos team.

[michalpolko]

Because You have different goals than mangos team and it is always easier to do own stuff than review somebody's code.

[sart13]

Because You have different goals than mangos team and it is always easier to do own stuff than review somebody's code.

I think you exaggerate greatly the quality of the code from the mangos team. very many commits from there cause no less questions, than most disputable commits in R2. to the same clean mangos code, at least at the present time, much less tested extensively in practice than the R2 code.

[angeleyes]

Sorry, I just saw the bug, but have no clue how to fix.

But do I understand correctly that this is so difficult it would take years to fix?

[Schmoozerd]

no, sart is just blabbering.

Fixing itself will not be difficult. The problem is to know how to fix it proper.

If you can provide reasonable sources when fear is removed due damage on retails, implementing such a change is easy.

(reasonable source would be for example wowwiki or elite-jerks)

[sart13]

The problem is to know how to fix it proper.

that's it. if it is absolutely certain - we must choose between different versions of the hacks, the current (very simple and useless) or more other from various authors. info sources such as wowwiki completely exhausted more than a year ago.

[angeleyes]

no, sart is just blabbering.

Fixing itself will not be difficult. The problem is to know how to fix it proper.

If you can provide reasonable sources when fear is removed due damage on retails, implementing such a change is easy.

(reasonable source would be for example wowwiki or elite-jerks)

Information such as http://www.wowwiki.com/Fear

or http://www.wowpedia.org/Fear

or http://code.google.com/p/trinitycore/issues/detail?id=2735 (sorry to put trinity here, it's just that they already did some (maybe helpful) research).

[Schmoozerd]

unfortunately these links don't hold enough information.

And for research you need something trustworthy, and tc is unfortunately not trustworthy, though now and then they get something right ofc

Basicly the problem boils down to a required formula:

max_dmg = function(caster, feared);

Where currently this formula in mangos is

uint32 max_dmg = getLevel() > 8 ? 25 * getLevel() - 150 : 50;

Possible we also need some additional way to store the amount of total already dealt damage (as it is said that the dear should break after a total amount of dmg is done)