Hunter's Mark

[NoHad]

Hunter's mark is bugged if you cast it on creature , creature get aggro on you but , if you cast it , it's get your's target to combat.

But it must work as if you cast it on target, he is still not at combat he can cast everything..

Thx for reply and for ideas :-)

[NoHad]

If semone knows where is the bug part of code with this, or what function is to spell effect non combat spell write it in to this topic thanks

[Cupcake]

You didn't mention what rev. are you using and if you're using custom patches or not. Afaik HM works fine both on master and One, I didn't notice anything wrong with it, especially the problem you mentioned.

[NoHad]

So ok there is Info: I use Mangos One and IDK but on wotlk revision it works normall and for me and on one repository with mangos one it works i can't find commit with this fix but i really need it when you use it on your's target it set you in combat with target and he got aggro on you.. this is fail it must have only aura .. no combat, no aggro

[Cupcake]

I just tested it again on One s1452 and it works fine. You still didn't mention what revision are you using.

[NoHad]

0870 it Means [s870] maybe i'll update but i must step by step because i have some fixes in this repo and i don't want to delete them ...

[Senpuria]

wow, that's a really old revision.

Try updating, then reapply your patches

[NoHad]

Hey man, i'll update it by hand but i need just 1 thing to know, on bitbucket if i click on commit what is on bitbucket's repo i can view a patch and get him to my core with git bash.. Can github repository of mangos make it too ? ( These patch.files ) are important

[DaC]

You've got git with all possibilities to merge repositories / cherry-pick single commits / rebasing your local stuff ...

but just append ".patch" to the commit hash on github to retrieve the patchfile.

greetings.

[NoHad]

OMG... i don't want to merge something to lost my work ... I only need fix, where the problem is or something.

[DaC]

so read the second line of my last post, please!

[NoHad]

I really don't know how on GitHub if you can send me PM or send me your's skype thx :-)

[DaC]

for example

your needed commit is at: https://github.com/mangos-one/server/commit/35ec3d478eeb5d284be8dd501fbdbe81dcbd4543

you'll find the patchfile at: https://github.com/mangos-one/server/commit/35ec3d478eeb5d284be8dd501fbdbe81dcbd4543.patch

sorry for being that offtopic

[Schmoozerd]

besides there is really not much use in giving support to someone who insists to stay on a very outdated revision to avoid work related to custom code.

If you have custom code, then don't complain about the work that follows as of it.

[NoHad]

OoOO Big thanks :-) man

[Unkle Nuke]

Well, you could learn to make patches out of your custom features, then re-apply them to the newest MaNGOS core so you have all kinds of fixes and improvements, NoHad.

[NoHad]

Yes now i have important patches.. but there is problem some code lines are in different zone it means path code in level3.cpp started on 3354 line but me started on 3358 when i remake path lines, it doesn't work and i really don't know why.. i've got errors like :

error: patch failed: src/game/Level3.cpp:3358

error: src/game/Level3.cpp: patch does not apply

So I really don't know why is there this problem..

[faramir118]

Patches are garbage, use git features like merge or cherry-pick instead.