[One] Creature Spell Crit

[Cupcake]

Mangos One: s1454

SD2: s2384

TBCDB 1.2.1

ACID 2.0.6a

--No custom patches--

It's common knowledge that NPCs shouldnt be able to crit with their spells, but i noticed that Jan'alai's Flame Breath spell critted on me while testing it. Is it possible to prevent a spell from critting individually or this is a major bug that needs to be fixed somewhere else?

[tibbi]

as i see, official mangos is missing a check at https://github.com/mangos/mangos/blob/master/src/game/Unit.cpp#L6683

It should have

if (GetObjectGuid().IsCreature())

return;

[Cupcake]

Thanks, i'll test and see if that does the trick.

EDIT: Thanks again , tested it and not sure if it's the best approach or if there are any side-effects but seems problem is solved. Patch here if anyone is interested, credits to tibbi : http://paste2.org/p/1876585

[tibbi]

I dont think it has side-effects, since npcs really shouldnt crit.