Jump to content

Patch] Lava/Water Fix


Auntie Mangos

Recommended Posts

What bug does the patch fix? What features does the patch add?

Related to : http://getmangos.eu/community/viewtopic.php?id=5348

Lava/Water Fixs

In order of appear :

1/

- When a player is in water and he isn't underwater (his head is below the water) the breath timer appears and works like player is underwater.

- With this it's fixed

2/

- Water in Undercity deal damage like lava

- With this it's fixed

Maybe other area need to add/remove lava damage mods ?

For which repository revision was the patch created?

7009

Who has been writing this patch? Please include either forum user names or email addresses.

@@ -18864,15 +18868,15 @@ void Player::UpdateUnderwaterState( Map* m, float x, float y, float z )
    uint8 flag1    = m->GetTerrainType(x,y);

    //!Underwater check, not in water if underground or above water level
    if (height_z <= INVALID_HEIGHT || z < (height_z-2) || z > (water_z - 2) )
        m_isunderwater &= 0x7A;
-    else if ((z < (water_z - 2)) && (flag1 & 0x01))
+    else if ( (z < (water_z - 2)) && ((flag1 & 0x01) || IsInWater()) )
        m_isunderwater |= 0x01;

    //!in lava check, anywhere under lava level
-    if ((height_z <= INVALID_HEIGHT || z < (height_z - 0)) && (flag1 == 0x00) && IsInWater())
+    if ((height_z <= INVALID_HEIGHT || z < (height_z - 0)) && (flag1 == 0x00) && IsInWater() && GetAreaId()!=153)
        m_isunderwater |= 0x80;
}

void Player::SetCanParry( bool value )
{

Note : it seems that since [7005] lava damage in water related here was fixed

Someone can confirm it ?

Link to comment
Share on other sites

  • 39 years later...
- In contrary (Molten core for example) it's an instant dead !

(I'm not sure of this it's a live player who tells me it)

If someone can confirm this...

I visited MC at 243 times with my level 70 character and lava ticked for 600 dmg. It was easily healable by a single priest. I doubt they have changed this in the meantime, what was the time your source has been in that instance?

Link to comment
Share on other sites

He is beginner and he says me that (in Ragefire Chasm) a player who fall in lava die so he thinks it's the same way for all dungeons.

Sorry I didn't think that a player with 200hp at level 15 take a one hit kill with lava damage at 600, I remove it.

About other "bugs", the code is it correct ?

It's possible to change topic name to just "[Patch] Lava/Water Fixs" ?

Link to comment
Share on other sites

Ähm, sry, but i on 7018 i found no changes on map extracor or anything, do you ?^^

  {
        switch(getClass())
        {
- case CLASS_WARRIOR: val2 = level*3.0f + GetStat(STAT_STRENGTH)*2.0f - 20.0f; break;
- case CLASS_PALADIN: val2 = level*3.0f + GetStat(STAT_STRENGTH)*2.0f - 20.0f; break;
+ case CLASS_WARRIOR: val2 = level*3.0f + GetStat(STAT_STRENGTH)*2.0f - 20.0f; break;
+ case CLASS_PALADIN: val2 = level*3.0f + GetStat(STAT_STRENGTH)*2.0f - 20.0f; break;
            case CLASS_DEATH_KNIGHT: val2 = level*3.0f + GetStat(STAT_STRENGTH)*2.0f - 20.0f; break;
- case CLASS_ROGUE: val2 = level*2.0f + GetStat(STAT_STRENGTH) + GetStat(STAT_AGILITY) - 20.0f; break;
- case CLASS_HUNTER: val2 = level*2.0f + GetStat(STAT_STRENGTH) + GetStat(STAT_AGILITY) - 20.0f; break;
- case CLASS_SHAMAN: val2 = level*2.0f + GetStat(STAT_STRENGTH)*2.0f - 20.0f; break;
+ case CLASS_ROGUE: val2 = level*2.0f + GetStat(STAT_STRENGTH) + GetStat(STAT_AGILITY) - 20.0f; break;
+ case CLASS_HUNTER: val2 = level*2.0f + GetStat(STAT_STRENGTH) + GetStat(STAT_AGILITY) - 20.0f; break;
+ case CLASS_SHAMAN: val2 = level*2.0f + GetStat(STAT_STRENGTH) + GetStat(STAT_AGILITY) - 20.0f; break;
            case CLASS_DRUID:
            {
                //Check if Predatory Strikes is skilled

Link to comment
Share on other sites

  • 2 weeks later...

Atleast fixed for my converted 2.4.* char...

The funny thing was that new 3.0.* chars lost dmg in some places (and my 2.4.* dident, and where i lost dmg on my 2.4.* char the ones from 3.0.* diden't ^^)

But i dont seem to lose any Hp from water in any of the locations from this topic anymore..

Link to comment
Share on other sites

  • 2 weeks later...

Server: 7208

Client: 9506

Bug: Water is some places still deals lava damage.

examples: outer ring in undercity, first big pool in blackfathom deeps (blackfathom deeps instance unplayable).

vmaps are enabled

dbc/maps/vmaps freshly re-extracted from client 9506 with the binaries provided in git. Do I need to recompile ad/vmaps exes and re-extract?

Link to comment
Share on other sites

  • 2 weeks later...
  • 2 years later...
Guest
This topic is now closed to further replies.
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use