[patch][7255] Allow saving characters in BG

[Auntie Mangos]

Simply fantastic, maybe is ready to be in Under Review section!

Only after more tests...

I updated patch (see first post)

Also I recommend test with this patch - http://getmangos.eu/community/viewtopic.php?id=5747

[Auntie Mangos]

my problem with mangos was fixed here http://getmangos.eu/community/viewtopic.php?id=6280 .. thank you for the fix, and belive me next time ... i'm posting mangos bug in mangos forum ,and other engines bug in other engines forums ._.

[GriffonHeart]

This patch allows saving characters in Battle Grounds

1) Player can join to BG after logout during 5 minutes, if BG in progress

2) All players after server crash should appear at the battlemaster

ADDED 23.01.2009

+ Cleanup code

+ Restore block movement and show stat after relogin when BG ended

+ Remove cast deserter

+ Fixed possible crash

ADDED 3.02.2009

+ Fixed: Join to bg-raid group after relogin

Patch+SQL on filebeam: DOWNLOAD NOW!

Patch on pastebin: http://paste2.org/p/140263

SQL-update on pastebin: http://paste2.org/p/134340

[charlie2025]

Nice one !

[Lascax]

Can you please say for which rev and branch of MaNGOS it is for? And which files modifies?

[GriffonHeart]

Can you please say for which rev and branch of MaNGOS it is for? And which files modifies?

Branch - master

Rev - 7103

Modificated files:

BattleGround.cpp, BattleGround.h, CharacterHandler.cpp, Player.cpp, WorldSession.cpp

[bsidebg]

I hope that this patch will be accepted

[Abim]

[...] 2) All players after server crash should appear at the battlemaster

With or without deserter ?

Edit: Sry, at university right now and no access to filebeam to check sourcecode. But i guess more people are interested in that information.

[Sephiroth1983]

Simply fantastic, maybe is ready to be in Under Review section!

[GriffonHeart]

ADDED 23.01.2009

+ Cleanup code

+ Restore block movement and show stat after relogin when BG ended

+ Remove cast deserter

+ Fixed possible crash

Patch+SQL on filebeam: DOWNLOAD NOW!

Patch on pastebin: http://paste2.org/p/134339

SQL-update on pastebin: http://paste2.org/p/134340

[Wyk3d]

Why all those extra columns ? I might understand id and team but why map,x,y,z,o ? Isn't the player location enough ?

[GriffonHeart]

Why all those extra columns ? I might understand id and team but why map,x,y,z,o ? Isn't the player location enough ?

map,x,y,z,o are BattleGroundEntryPoint. It is coordinates, where the player was before teleport to BG

[Wyk3d]

map,x,y,z,o are BattleGroundEntryPoint. It is coordinates, where the player was before teleport to BG

Can there be more than one location for a player of a certain faction to be teleported to a specific battleground ?

[GriffonHeart]

Can there be more than one location for a player of a certain faction to be teleported to a specific battleground ?

It can be any point in the world, near the battlemaster where player join to queue.

See SetBattleGroundEntryPoint function.

But I think we can move this method from WorldSession::HandleBattleGroundJoinOpcode and WorldSession::HandleBattleGroundArenaJoin to BattleGroundMgr::SendToBattleGround

[Wyk3d]

Does it matter if you don't appear in the exact same location just any random location near the battlemaster ?

[darkplayer]

i havent checked the code but remember the entry position is the place where the group leader signed aswell

(bl1zzlike)

[VladimirMangos]

so remeber entry position required.

Another question:

character at disconnect still in world sometime. and player have time for reconnect to and continue fight.

Is at BG character can be removed from world and then reconnected, or chaarcter still be in world until reconnection?

[Tassader2]

Does it matter if you don't appear in the exact same location just any random location near the battlemaster ?

So store guid of the battlemaster insead?

[VladimirMangos]

this will need rewrite current way of entry point store for BG. And battlemaster point not exactly point where player stay at teleport

[Darkpeninsula]

i don't see raid members after login during 5 minutes

if player will logout and bg will end the players don't get deserter debuff

[Darkpeninsula]

if the server crash during preparation , players will have preparation buff outside bg

if the server or the client crash during arena preparation , players lost all items.

[GriffonHeart]

ADDED 3.02.2009

+ Fixed: Join to bg-raid group after relogin

Patch+SQL on filebeam: DOWNLOAD NOW!

Patch on pastebin: http://paste2.org/p/140263

SQL-update on pastebin: http://paste2.org/p/134340

Problem with storing BG-auras (flags, preporation etc) was fixed by another patch (DOWNLOAD NOW!)

[Darkpeninsula]

ADDED 3.02.2009

+ Fixed: Join to bg-raid group after relogin

Patch+SQL on filebeam: DOWNLOAD NOW!

Patch on pastebin: http://paste2.org/p/140263

SQL-update on pastebin: http://paste2.org/p/134340

Problem with storing BG-auras (flags, preporation etc) was fixed by another patch (DOWNLOAD NOW!)

if the server or the client crash during arena preparation , players lost all items.

is this fixed ?

Problem with storing BG-auras (flags, preporation etc) was fixed by another patch (DOWNLOAD NOW!)

wrong link , i think

[GriffonHeart]

wrong link , i think

Already in git

[VladimirMangos]

Patch in [7255] Thank you

Problem with preparation spells fixed in [7253]

if the server or the client crash during arena preparation , players lost all items.

Not mangos bug: ALWAYS use InnoDB for characters DB. If you not use this engine then this is not mangos team problem.