Jump to content

Patch [SQL] rename TABLE character_tutorial TO account_tutorial

Guest Etznab

Recommended Posts

  • * What bug does the patch fix? What features does the patch add?

In previous commits the tutorial relation has been changed from character to account.

The table name (character_tutorial) was not changed to reflect changes inside the table (account_tutorial).

  • * For which repository revision was the patch created?

[7208] aab9a8d92f542fb7fd34b19a5d5a0e77ee8a8177

  • * Is there a thread in the bug report section or at lighthouse?


  • * Who has been writing this patch?


Patch C++:


Patch SQL:

RENAME TABLE character_tutorial TO account_tutorial;

Link to comment
Share on other sites

My main reason for the renaming:

  • * this table does not contain any character related data.

About the clarity, there is a table named "account_data" this table does almost the same thing as character_tutorial:

  • * keep track of account specific info for the current realm.

This to me makes no sence to have 2 tables with different pretext that do the same:

  • * account_data
    * character_tutorial

In my view all tables that store the same (related) data, should for the sake of consistency have the same pretext example:

  • * account_ (data, tutorial)
    * arena_ (team, team_member, team_stats)
    * character_ (achievement, achievement_progress, action, etc)
    * etc

My C++ skills are louzy so the patch i created could use cleanups.

Hoping i could clarify my view and reasoning.


Link to comment
Share on other sites

if the tutorial is realy saved per account, i think this name makes it much more clear.. on the other hand, it at least doesn't confuse anyone

about the patch: i greped the code for all characters_tutorial occurences and they get all changed through the patch..

but in playerdump.h the line "account_tutorial" doesn't need to be added, cause it isn't in the DTT_CHAR_TABLE (i think someone forgot to remove this comment some day)

Link to comment
Share on other sites

  • 1 year later...
  • 3 weeks later...
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use