The_Game_Master

That's very nice of you.

I think the best way to test it is to add it to the main branch. Since atm this patch modifyes the characters tables and it's preutty hard to test with the risk of not beeing added. I would gladly test it and report but yet again if it's not added ...

I think i just sayd that 2 posts above. <_<

Any chance of seeing this patch in git by the end of 2009? Retedted the patch, and the output is not quite as expected.

Spell: Seal of Corruption Bug: Seal of Corruption removes any other paladins seals when you are striking the opponent. Fansite reference: http://www.wowhead.com/?spell=53736 Status: partially bugged Tested today with 8498.

I was wondering, shouln't now the AV nodes be rerwited to manage the new patch? :huh:

Ah sorry, i missed rank 3 that has 100% chance of proc.

Hi, tested. Replenishment still has 100% proc chance.

I had this problem so i tough that others may encounter. I found spell 5419 in character_spell (not on all the druid class characters) and was causing speed problems for thouse ones.

This should be added for 8416 as for the spells still remain in the character_spell table. Author: me Bug reports: None that i know of [color=blue][b]DELETE[/b][/color] [color=green]FROM[/color] [color=orange]character_spell[/color] [color=green]WHERE[/color] spell [color=green]in[/color] ( 1178, /* Bear Form (Passive) */ 3025, /* Cat Form (Passive) */ 5419, /* Travel Form (Passive) */ 5420, /* Tree of Life _passive_ */ 5421, /* Aquatic Form (Passive) */ 7376, /* Defensive Stance Passive */ 7381, /* Berserker Stance Passive */ 9635, /* Dire Bear Form (Passive) */ 21156, /* Battle Stance Passive */ 21178, /* Bear Form (Passive2) */ 24905, /* Moonk[color=green]in[/color] Form (Passive) */ 34123, /* Tree of Life _pasive_ */ 33948, /* Flight Form (Passive) */ 34764, /* Flight Form (Passive) */ 40121, /* Swift Flight Form (Passive) */ 40122 /* Swift Flight Form (Passive) */ );

Can anybody review this? We really need it atm!

I think it's showing every time it saves. Btw it should not be displayed every time you log in, it's not the correct behavior.

Yes it is, but unfortunettly i missed something and when you type /played you broadcast to every player ingame.

As some of you may know /played stopped working after 3.x.x client switch. This little patch will make the command running again. void WorldSession::HandlePlayedTime(WorldPacket& /*recv_data*/) { uint32 TotalTimePlayed = GetPlayer()->GetTotalPlayedTime(); uint32 LevelPlayedTime = GetPlayer()->GetLevelPlayedTime(); WorldPacket data(SMSG_PLAYED_TIME, 9); data << TotalTimePlayed; data << LevelPlayedTime; - data << uint8(0); + data << uint8(1); SendPacket(&data); } On the other hand, i think i missed something. Patch writen by Tom_RUS with some modifications for 3.2.0 branch. I think should be applied to 3.1.3 as well.

Anybody tested this?> Later Edit: Tested, works as intented.

Bump! Need some help please.

Revision: 8036 src/game/AchievementMgr.cpp [color=Red]- [/color]sLog.outError("Not existed achievement [b]creataria[/b] %u data removed from table `character_achievement_progress`.",id); [color=SeaGreen]+[/color] sLog.outError("Not existed achievement [b]criteria[/b] %u data removed from table `character_achievement_progress`.",id); Just a quick patch for a small typo.

Good job guys! Very mutch appreciated!

Core 7947 SD2: 1113 OS: Linux 64 bits No patches. Program received signal SIGABRT, Aborted. [switching to Thread 0x42a28950 (LWP 5582)] 0x00007f0fd3a58f05 in raise () from /lib/libc.so.6 (gdb) bt full #0 0x00007f0fd3a58f05 in raise () from /lib/libc.so.6 No symbol table info available. #1 0x00007f0fd3a5a960 in abort () from /lib/libc.so.6 No symbol table info available. #2 0x00007f0fd3a935bb in __libc_message () from /lib/libc.so.6 No symbol table info available. #3 0x00007f0fd3a9abca in _int_free () from /lib/libc.so.6 No symbol table info available. #4 0x00007f0fd3a9e75c in free () from /lib/libc.so.6 No symbol table info available. #5 0x00000000004f5e08 in std::vector<unsigned char, std::allocator<unsigned char> >::_M_fill_insert () No locals. #6 0x0000000000763f7d in UpdateData::BuildPacket () No locals. #7 0x00000000007c678c in MaNGOS::VisibleNotifier::Notify () No locals. #8 0x00000000005e96eb in Map::UpdateObjectsVisibilityFor () No locals. #9 0x00000000005ea3b4 in Map::Remove () No locals. #10 0x00000000006bafb9 in Player::TeleportTo () No locals. #11 0x000000000070a7ca in Spell::EffectStuck () No locals. #12 0x00000000006f313f in Spell::DoSpellHitOnUnit () No locals. #13 0x00000000006f3dbb in Spell::DoAllEffectOnTarget () No locals. #14 0x00000000007021ff in Spell::handle_immediate () No locals. #15 0x0000000000701353 in Spell::cast () No locals. #16 0x00000000007022e0 in SpellEvent::Execute () No locals. #17 0x000000000083bbc2 in EventProcessor::Update () No locals. #18 0x000000000074a266 in Unit::Update () No locals. #19 0x00000000006c071c in Player::Update () No locals. #20 0x000000000060bfdb in ObjectAccessor::UpdatePlayers () No locals. #21 0x0000000000602815 in MapManager::Update () No locals. #22 0x000000000077412a in World::Update () No locals. #23 0x00000000004eb88d in WorldRunnable::run () No locals. #24 0x000000000082077a in ACE_Based::Thread::ThreadTask () ---Type <return> to continue, or q <return> to quit--- No locals. #25 0x00007f0fd421638b in start_thread () from /lib/libpthread.so.0 No symbol table info available. #26 0x00007f0fd3afcced in clone () from /lib/libc.so.6 No symbol table info available. (gdb)

Never said that we don't understand git so we criticise it. Like i don't have to be a fan of it or agains it to discuss a problem that occured. This is very mutch true. Perhaps aproved branches?

If you're working on the master branch then yes, git is working fine. But if you need to apply a dosen of other patches, then no, git is not working fine.

I don't know if anybody noticed but in the past 2 weeks or more the Git Network it stopped updating. I'm refering to this link http://github.com/mangos/mangos/network so don't imagine anything else. I was expecting more then 6 months until Git craps his pants and start overloading (remember SVN a while ago?), but looks i was mistaking. Anybody got any ideea what may have caused the event? There's no data about it anywhere.

Needs update. Crashes the client atm.

Finaly a fix for this! Thanks alot, i'll test and report back later.

Teasted in diffrent scenarious and works as intented. This can be removed from patch, not needed - if( !isInCombat() || HasAuraType(SPELL_AURA_MOD_REGEN_DURING_COMBAT) || + if (!isInCombat() || HasAuraType(SPELL_AURA_MOD_REGEN_DURING_COMBAT) ||