VladimirMangos

In [6189]. Thank you

Related to getMSTime use: range of values for getMSTime limited and counter can overflow and start from 0. For correct comparison 2 getMSTime values better use getMSTimeDiff call instead explicit comparison.

Typo fxied in [6177]. Thank you.

Hm, .. I see... I look in first time at wrong function. [added]in [6174]. Thank you. I remove sma echeck and in WS case. In general drop flag must be allowed in any state in different from other events.

Where it called at end of BG? Can you provided backtrace or just code line... Remove in general can allow cheating...

This is positive or negative remark? If he understand that big changes need discussed then ok for me.

Similar patch already present in Under review, but will not appropriate for svn as hack.

Patch in [6150]. Thank you

Last patch rejected: bad way attempt fix "generic" solution by adding random options to function. At this moment TeleportTo already have view: TeleoprtTo (map,x,y,z,bug1workaround,bug2workaround,...). Not need add more. Instead i plan add patch http://pastebin.ca/1052441 Now I test it. [added]In [6145] must be fixed.

In mangos fields numbered from 0. in some DBC viewers from 1. Also structure in DBC viewer show in outdated state.

Patch in [6136]. Thank you. I think deserter don't must applied at BG switch so current suggested code prefered.

In [6135]. Thank you

This is already fixed in [6105]

Is this still need? For other platform this MSG_NOSIGNAL define in dep\\include\\sockets\\socket_include.h And for #elif defined MACOSX have #define MSG_NOSIGNAL 0

In [6117]. Thank you

When you select client send class/race pair to server and server can allow created or send back error message.

You can do it only modify sources (add check to prevent creating chaarcters with selected class) in WorldSession::HandleCharCreateOpcode

Patch in [6067]. Thank you

I can wait with review for files tabilization by content, or you can write end line and additional changes place in another patch. By your choice. Please, place in first post _final_ version for review in any case when _this_ patch will ready.

In [6029]. Thank you

In [6009]. Thank you

in [5979]. Thank you

In [5978]. Thank you! Sorry, for my noobish not finish changes at sql/tools/Makefiel.am adding.

Patch in [5962]. Thank you.

Ok, I test spells with removed custom code and have (with debug check): 1) spell 27223 and related applied now "-5% of total per any additional effect" so result bonus less original code where just 50% reduction set. Not sure for 100% is this correct, but i think yes. And then more correct in new code. 2) spell 30911 and related no changes in final value (DotFactor 1->2 CastingTime 100% -> 50%) 3) spell 27220 and related in old code have 2500 cast time, but in generic code Castem time set to 1500, after 50% reduction this is 750, so 1/3 from old code bonus size. But it not listed as exceptions so notmal code must generate correct value. If it not generate then this is not patch problem. 4) spell 2944 and related no changes in final value (DotFactor 0.8->1.6 CastingTime 100% -> 50%)