Jump to content

VladimirMangos

Members
  • Posts

    2813
  • Joined

  • Last visited

    Never
  • Donations

    0.00 GBP 

Everything posted by VladimirMangos

  1. and if this bug related to specific NPC then this not core bug but problem in DB/scripts. Ok, _possible_ this porblem in core. But in like case need provided data related to core about found problem. Form core point existance or not some npc spawn not core -porblem.
  2. Current queue level ranges based at dbc data. If you want overwrite its then you need modify related code to use own ranges. This can be not easy or maybe not...
  3. Alt. patch (but similar laise vesion ) added in [9239]. I just not search forum when look at spell problem...
  4. Similar patch added from other author in [9238]. Thank you anyway
  5. Ok, display part as show above still used from DB by client. Mangos have DBC preference in use because this more stable (no client crashes at wrong display id) Do you read thread?client still read data from DB but _ignore_ some. In in ignored part you can;'t do anything.
  6. Second patch added in to [9235]. Maybe it also have problems but base at reports less often and logicaly it more correct base at way how pkg-check called from it.
  7. Possible this can be better in general but in result includes in ObjectAccessor.h we will have cyclic dependences in .h files. Need first cleanup ObjectAccessor.h part.
  8. Must be fixed in [9233]
  9. Second patch added in [9228] with described excluded/modifed parts. Thank you. So from patches not added only second part of first patch. In suggested form it not compatibel with mangos sources.
  10. I think all ok, except use uint64 as key foru group map.No reason use full guid as key for map because uint64 key _lot_ more slow as key at x86 Alsoreplace mGroupMap.erase(itr++) by relookup removed element by guid will more slow that existed case, so i will not include this change also.
  11. First part of first patch added in rewrited form in [9227]. Thank you. I think now we check all cases looting state for source and targeted items.
  12. Duration items possible autobound all. If functionality base at this then need check this at loading. By function emaning this too hacky way place like сheck to it.Also this not catch all cases... with loot state merge. Spcially when looting item auto slected as merge slot. I will add rewrited patch for this part. This function is not exist in mangos. Agree. This is make safe many places with possible absent or not so clear check inclding guild bank and etc.
  13. Ok, i will unban Wowka321. Sorry for overraction. I i remmeber old non nice cases when in result have wrong author names in commits ((((
  14. Sorry, i like do typos in commit notes ^^
  15. alein , your build porblem with original patch or with second way?
  16. In [9226]. Thank you
  17. in [9222]. Thank you. In [9223] added count=2 for dagger case for porper providing 2 daggers to rogue base at DBC data.
  18. I not sure that this data based at collected data at official servers, but requirement for items provided by dbc good reason accept its anyway...
  19. In code bracket used for level breakets at same BG, so i replace it uses to more wide in code name: arena slot In [9221]. Thank you
  20. In [9220]. Thank you
  21. Wowka321, you cheating me (maybe not specially) make me think that this is your patch in comment at github. So i will at first time ban you at week. Maybe this will teach you and other _always_ provided info about authors. mumion, sorry for wrong author info in commit. Patch in [9215]
  22. I think Lightguard good candidate for join to team now. No big style/hack problems in suggested patches mostly. And suggest many for long time presence at forum. Also long time presence at #mangos and not show sign 'crazy' man For me will lot easy some diascuss details that do full review his patches
  23. Spell not required any additiona DB support and work fine for me. So i just expecte that reporter have some garbage in DB or modified code.
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use