Jump to content

VladimirMangos

Members
  • Posts

    2813
  • Joined

  • Last visited

    Never
  • Donations

    0.00 GBP 

Everything posted by VladimirMangos

  1. In [9307]. Thank you Possible more simplifications but after make creatures/go really map-local stored.
  2. 1. You skip GetArmorPenetrationPct() and then skip apply SPELL_AURA_MOD_TARGET_ARMOR_PCT auras affect. I think this jusy wrong... 2. This not very good style place client used hacky formulas with raw coeffs from level explcitly in function. Better place level dependent formula itself int o Formulas.h maybe If some formula published at well known wiki not make it 100% sure correct and include on all specific cases and details.
  3. 1) we still not restored from adding old part... so i not plan add more form this thread until prev. resolving.. 2) please mot make from threads list of patches. 1 thread for 1 patch. I close thread for avoid continue this
  4. because before patch has been not clear correct or not for me, and working remark not make patch 100% acceptable. Not it more short and more clear. But i still not sure is this most clean way do this...
  5. in [9306]
  6. in [9305]. Thank you
  7. I can help you by ban until switch? ok? You will know at forum return exactly date ;P At this post just joke for while.
  8. You quote warnings can not affect build success. You also not write what VS you use. I also note that for me mangos fine build at VS 2008
  9. Some ppl is very slow... you can comment anything, bit in some cases client use _own_ dbc data when early use server side data. You can't overwrite like work any server side changes in code.
  10. i not remember any lot discussion with him for self case, but if you think that at least we must invite to channel then why not invite in channel for start... Just for note: I have his pool patch but not find time for review yet.
  11. totems already have special code for use owner spellpower, but i will test in debug...
  12. I personally support view point that propertly writen code can be self docummented. Ofc, exist some cases where comments can be need because C++ code itself not let in like places cleary described in short way what done. As pointed Doxygen can help good for ppl that can't fast extract and see data base just by code.
  13. With fixed referenced lines added in [9298]. Thank you
  14. Heal spell itself already have proper data for spell power: Not very nice way check ranks..
  15. I worry about affects from item use, like potions, it also casted as item effects but not expected allow stack effects from 2 scroll.
  16. As i understand this applied and for master? same problem expected... [added]Hmm, referenced enchantment spell affects in master not allowed stacked by aura type for spells with not specified stack size amount... (0) Same for 0.12. You sure that see working this after patch for 0.12... [added2]Ah, i see now own typo for master version that i attempt prepare...
  17. in [9296]. Thank you
  18. Fixed in [9294]. Thank you
  19. You not understand my point. Scripting implemented in scripting library, and you can add lua engine to scripting library. Mangos code not need know what scripting language you use in scriping library and then this not mangos core problem. You can add to same scripting DLL and LUA and python and VB and anything more. For mangos core only need that when it call some scritpintg API then scritps proccess its propertly.
  20. You need _not_ mangos support lua but scripting library support lua. Mangos core not related to this in fact.
  21. Please avoid report crashes with outdated revision when in thread already writed that applied more recent fixes
  22. Maybe but i am not sure for all cases... Patch itself in [9288]. Thank you
  23. no, in fact commit do opposition thing: make heal taken from any sources to target affected by some auras.
  24. not confirmed. Less use mail affected patches...
  25. mangos not support 3.3.2 and specially not suppor ppl who can't look at what update applied to client and how this will affect to compatibility with mangos.
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use