VladimirMangos

we send all data from DB in item data requests from client. But client now partly ignore this data and use own. That why like diff. values spam at server loading. Before this only affect icons in inventory but now (base at your report this more wide affected). So this client side limitation.

maybe, but you sure that data generated by like buiild binary correct? Do you compare its with x86 binaries generated version? As i remember extractor code hard based at x86 only code by used types and etc...

How this related? New client version support not slowdown and not speedup still existed features adding... but delay client swit make lot more hard development in general. Where you will get all info if all information resources switch to show new data. Also switch allow prevent useless work at dropped or changed features.

In [9139]. Thank you Ops... forgot include sql update... will do shortly Also note: why you always include schoolmask [added]Ah, sorry. sql update not need, it already included in mangos.sql

Starting from [9136] MaNGOS support only client version 3.3.0A (11159) at master branch (Client 2.4.3 still limited supported at mangos-0.12 branch, for client 1.12.1 exist independent project mangoszero as friendly fork from mangos-0.12 with downgrade to more old client version) You need update DBC files. You can regenerate .map/vmap files to be sure in 100% correct its work.

MaNGOS is an object-oriented Massively Multiplayer Online Role-Playing Game Server (MMORPGS). It's an educational project, to help developers get familar with large scale C++ development projects. The 0.15 release based on GIT commit [9134] is the fifteenth release on the MaNGOS roadmap. As a source-only release, it is intended only for developers and advanced users who understand they will probably experience bugs and/or rough edges. The following list only gives you a higher level overview, for further details see the ChangeLog file included in the source releases. ==== Game Features ==== * Added: Implement AV battleground. * Added: Implement threat level show in client. * Added: Implement dead visible creatures support. * Added: Implement new dungeon/raid difficulties work. * Added: Implement mails sending at player levelup. * Added: Implement new DB-based gossip system for creatures/gameobjects. * Improved: More proper creature movement animation in fly. Improvements in movement generators. * Improved: Fixes in pool system that must allow more wide use pool of pools mode. * Improved: Rewrited battleground spirit guids code for more correct work. * Improved: More achievement types support. Including with DB/script-based achievement requirement checks. * plus lots of fixes for auras, effects, spells, talents, glyphs and more. ==== Server Features ==== * Added: More chat/console commands and config options. * Added: Implement realmd support realms for different client versions. * Added: New memory allocator for MaNGOS, based on Intel Threading Building Blocks library. * Improved: Some guid generation and object stores made map local. More improvements can be possible in future for this part. * Improved: Player updates move to map local code. * Improved: More other changes for thread safe work code in future per-map threads. * Improved: More wide use ACE features instead explicitly hardcoded. * Improved: Rewritten mail preparing code, and cleanup mail system code in general. * Improved: More checks at loading DB data for problems detection. * Improved: Some optimizations in amount data send to client. * Improved: Avoid characters save calls in some redundant cases. * Improved: Progress in move before used at loading values from `data` field to own fields/tables. ==== Statistics ==== * Fixed Bugs: 100 tickets and many bugs reported at forum resolved * Total number of changes: 547 revisions (560 commits) MaNGOS team not plan create special branch for 0.15 release. Tag will created release commit from other side. We plan continue provide limited support for existed mangos-0.12 branch with appropriate patches backporting from master.

In [9133] with added removing main spell at stack cancel and different DB data. Thank you

Added to 330 branch. Thank you

thanks, i have same code also, but have problem: when player cancel aura by icon click then it remove 28682, not 11129. Is this correct that 11129 will still active? until 3 crit ofc

This better do in specail function exist for like aura boosts

Not see any reason use this: we have same req. for spell

In [9118-9119]. Thank you

0.12 version commited also. Thank you

This meaning that in 3.3.0 client start get weapon type from own DBC insteed sent DB data. I can make only one recommendation true for current and later clients forcustom items: find in items.dbc unused for normal accessable to players item id with _excatly_ item type, and use it. And strongly not recommend use item ids that not exist in items.dbc. Fromclient version to next it will more and more broken because from version toversion client startmore base own work at item.dbc instaed any sent DB data.

1) And in general idea wrong. Not all casts must interrupt stealth/invisibility. In fact most trigered casts don't must and many client side casted also. 2) already exist code that remove stealth/invisibility at spell hit/cast in target hit/cast code.

What you meaning?

singletones from core can't be used in script DLL. if you need output message use WorldSession::SendNotification

I already added similar patch in [9081], yes. So, considereing as fixed.

Please, test this draft patch: diff --git a/src/game/SpellAuras.h b/src/game/SpellAuras.h index bae2f36..aeb8045 100644 --- a/src/game/SpellAuras.h +++ b/src/game/SpellAuras.h @@ -367,6 +367,7 @@ class MANGOS_DLL_SPEC Aura int32 m_maxduration; // Max aura duration int32 m_duration; // Current time int32 m_timeCla; // Timer for power per sec calcultion + public: int32 m_periodicTimer; // Timer for periodic auras AuraRemoveMode m_removeMode:8; // Store info for know remove aura reason diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index 57feb9d..8be1bec 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -3624,7 +3624,20 @@ bool Unit::AddAura(Aura *Aur) int32 remainingTicks = 1 + (aur2->GetAuraDuration() / aur2->GetModifier()->periodictime); int32 maxTicks = aur2->GetAuraMaxDuration() / aur2->GetModifier()->periodictime; - Aur->GetModifier()->m_amount += int32(remainingTicks * aur2->GetModifier()->m_amount / maxTicks); + // increase current aura damage and make it similar new aura work + aur2->GetModifier()->m_amount = Aur->GetModifier()->m_amount + int32(remainingTicks * aur2->GetModifier()->m_amount / maxTicks); + aur2->GetModifier()->periodictime = Aur->GetModifier()->periodictime; + aur2->m_periodicTimer = Aur->GetModifier()->periodictime; + + // hide old aura icon + aur2->SetAura(true); + aur2->SetAuraFlags(AFLAG_NONE); + aur2->SetAuraLevel(0); + aur2->SetAuraSlot(0xFF); + + // delay new aura tick until old finish + Aur->m_periodicTimer = aur2->m_periodicTimer + (aur2->GetAuraDuration()/Aur->GetModifier()->periodictime+1)*Aur->GetModifier()->periodictime; + break; } // can be only single (this check done at _each_ aura add RemoveAura(i2,AURA_REMOVE_BY_STACK); I mostly want ask is it visual and expected damage log fit expected. If it wrk ok i will prepare more clean version without hacks

Ok, i understand, So current implementation totally wrong in merge buffs part. Must just allowing independent stacking in some way with own timers from same caster.

In [9075] and 0.12. Thank you

lol, you can disable anything by self, mangos core niot disable something if it not work.

Fix added to branch. Please, next time post fixes to under review section.

Not support not meaning that we not accept patches for it. And this real patch for current C++ version that not accept like >> in templates. We can without any porblem by ban anyone who not follow. And this not breaking GPL. But in this case i not see any confirmed facts.

Added in [9068]. Thanks author for patch and KAPATEJIb for pointing