VladimirMangos

In [9030]. Thank you

And how this related to core? Discuss this at some DB project forum

i not care about normal/not normal. I only note that in this specific code point current way correct. If bug exist this in some another place

In [9025] with apply idea use AddTriggeredSpell to current casted spell that resolve apply oder. Thank you to author, patch preperer and idea suggester

Why you think so??? `damage` used in damage += damage/4; is basic spells damage caluclated from spell.dbc base values , at call you just increase it at 25% all spell bonuses applied to this `damage` _after_ this formula

Maybe some flag exist in spell data... Ofc, possible add special arg to cast function and send into main spell entry for make difference casted subspell from main spell from just script casted boss spell, but for example exist spell do oofhand attack and it expected to have own miss chance... I also think that bool canMiss = (m_triggeredByAuraSpell || !m_IsTriggeredSpell); too strong, and m_IsTriggeredSpell originally only meaning that this not client side cast and then it not get spell casting slot for caster. Why and from what it triggred not defined...

In [9024]. Thank you

Hmm, i apply already semilar patch in [9023] before see this. Anyway thanks

In [9021]. Thank you

base at fact that after more look i agree mostly with you first implementaion except 1) triggred use (canbe in dummy auras) 2) unmount at expire (base how writed at well knonw wiki buf not provided time of morph but time when this morph can be applied at mounting) - so with droped this part. I already test patch with this smalll modifications Sorry for my long understanding time logic of your original patch ^^

I am not sure. oroginaly i thionk it just replace model with not ouching aura. and in case morph expired restore original, yes. But now not sure You sure that 25860 related to this item 21213 We have item 21213 -> dummy aura 62061 (time limit, visually reaplly at new mount while not expired) From well know wiki: So look like at aura apply it just replace mount model and at mount checked for aura and do same At aura expire model restored. item 21212 -> dummy aura 25860 (until dismount, no time limit) already implemented and just replace mount by same speed. Ah, ok first also can be implemented in this way, i see now, except expire case. Maybe i wrong and it must dismount at tine expire, or expire only meaning that new mount will not transformed? In last cases just case 62061: redundant and better move triggered spell to Dummy aura apply code symmetric with mount cases I will do test and apply in last version.

Why it remove mount? As i read descriptions it aplied if mount active and all duration time. you can unmount and remount after. And it not related to bonus speed mounts in any form, just visual model replace...

then test with debug and see difference in telnet and raw connection... if you fix this then this will great.

With this changes in [9019]. Thank you

hm... 47498 in mangos.sql not have all ranks (with your data also ) 7386 and ranks not have fixed threat and 58567 must be called with scalled effect 1 value, so need fix in another thread. I add instead drop all related old ranks. Typo in spell id (48470, 322), expected 48479

In [9018]. Thank you

In [9018] Thank you

As i check from start values must be: (7, 12, 114, 206), so aprox. recalculation work incorrectly and need check all levels. And for 12 level is same as old value. Possible it updated not from start. So maybe possible less work do just by found point when value start different from already listed. This more work ofc but will let have expected health really. Ofc, for 1-9 levels it still aprox. values. Suggested by you levels for 70-80 as i check some correct. Can you check other levels when possible... ?

it can't. It get damage bonus explcitly in own damage, in different casting different spell at dispel case. And i already write that fix it.

Double apply spell power bonus eliminated in [9015] for both. Ofc, for dispel case still possible applied not spell power source bonuses, but i not sure for this part. "conflagrate" code has been just bug: spell not have applied bonuses to damage and anyway additional bonus is percent from original.

caster->SpellDamageBonus need in both cases becaus dot m_amount not include spell bonuses. it wrongly applied after cast final damage, not before cast calucaltion. But maybe i wrong... spell tolltip always not include spell damage bonuses except spellmods

when health or another stats checks need propertly check if total percent talents applied and remove this percent from toall value before subtract buff. I read that data updates, but i need find time to check it partly at least. As always too many task in queue (or random pool maybe).

multiplier correct, read release notes for 3.2.x ... full damage / 5 tick * 8 = expected damage _if_ no any spell bonuses. Single problme possible just absent sql record in spell_bonus table witjh 0% coef for any spell damage bonus for dispel damage spell If someone from _check_ and suggest related patch (in under review section) i will review.

unsupported meaning: you will not get answers at related to 3.3 questions at this forum. If you want use dev branch then you must be powerful to do this without questions.

I not apply this because prefer limit in comit to cooldowns and related. Not check is this correct or not and will move to new thread.