Wojta

How is that possible? Id changed(client version switch etc.) or just dev mistake?

First post updated.

V2 links dosnt working for me pls upload patch to pastebin .

V3 uploaded instead of this

Juggernaut and Warbringer works fine now, but Fingers of Frost charges still not work

First post updated.

Lynx3d: I havent a lot of experience with mangos and c++, so I dont understand to spellModifiers, but i will try ...

EDIT: in unit.h 85, there are defined some spellmods. What is this?

Yes, it would be nice, thank you. I want to submit my patch wit working sudden death, but at first, I need to test recent changes - but on my PC, mangos just crashs after start, so I have to wait for my friend

PS: I think theres something different in DBC for this auras, but I cant even find code which using Clearcasting, Combustion etc for removing auras on spell cast

PS2: Now, when I know that there are more than one spells which using this aura, I named it SPELL_AURA_IGNORE_UNIT_STATE

Yes, I tried this too, but why combustion, Clearcasting and many, many more works fine and these ones no?

bump, works fine

Actually, aura 262 allows to igore some conditions, like combat, stance(warrior's Warbringer&Juggernaut and Sudden Death) or other states. Currently this aura is ignored, but IMO it's bad idea to implement it as "Finger of Frost aura", because it's more universal aura. I thought this aura is only for warrior, but mage's FoF also uses it.

Client side sees execute as usable, but server doesn't allow to cast it because enemy has more than 20% hp. IMO clients gets info from server in case of charge spell. I don't know what about FoF.

Please, read my post before yours....

PS: Sorry for double post, I am forgot to "edit"

Thank you

Well, Im sorry, but I cant work on that today, but tomorrow I will have lot of time )

EDIT: Good I have working deep freeze right now, working on juggernaut and sudden death....

EDIT2: Sudden Death Working... I will do rest and post patch tomorrow.

But I still dont know what to do with charges...how can i tell aura when it should drop charge?

And if sudden death should disappear after one execute, it dont work too....

EDIT3: I have some more problem with Juggernaut....in case of Sudden death, client itself allows execute, but with juggernaut, Charge is "gray" in combat - client needs some special packet for this aura/only for charge?

Yes, maybe this will help with deep freeze(I will try), but in this isnt anything which modifies Ice lance and shatter to do dmg as if frozen....

And still..what about charges? Why buff does not disappear after two spells?

Im writing from cell phone right now, so i cant try you suggestion. But what about charges?

and i cant look to wowhead for purpose of spells ith aura 262, too (btw what name should this aura have?)

EDIT: well...its looks like this aura needs extra code for all these spells....

EDIT2: Now Im on PC, I think that aura name can be SPELL_AURA_ALLOW_ABILITY....

EDIT3: So...you think it would be better to create new void, which checks for this aura?

I post diff with changes in SpellAuras.cpp instead in Unit.cpp tomorrow.

For charges, maybe missing data in DBC?

EDIT: but...target have to have aura state frozen, not caster. What if caster switchs target? Only record targets some way... maybe change void which returns aura state would be better...

What bug does the patch fix? What features does the patch add?

Glyph of Corruption

For which repository revision was the patch created?

Tested on 8557

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

I did not find any....

Who has been writing this patch? Please include either forum user names or email addresses.

Me

Really small fix - NightFall have same effect...data in spell_proc_event data are already in DB

PS: Sorry if diff is wrong

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index c409046..cded2c9 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -5269,9 +5269,10 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu
            }
            switch(dummySpell->Id)
            {
-                // Nightfall
-                case 18094:
+                // Nightfall & Glyph of Corruption
+                case 18094:  
                 case 18095:
+                case 56218:  
                {
                    target = this;
                    triggered_spell_id = 17941;

I think that either the first argument of EnergizeBySpell should be removed or this patch should be used instead.

http://www.pastebin.org/18920

Anyway nice catch, i wasn't able to find the bug until i saw your fix

Yes, this is better way to fix it

This should be the diff so people can apply it

Thanks a lot, Reeshack

You control NPC, so....set inhabittype=4?

Okay, thanks a lot

VF_MOVEMENT = 0x0040, // vehicle will move on its own, not depending on rider, however rider can cast spells

What do you mean, "its own"? Waypoints or something else?

//Czech

Myslím že jsi taky čech, zkrátka mám tu Q ve kterém mám pokecat s NPC a to mě má vysadit na gargoyla, který se mnou obletí ZulDrak. Není to dělané přes klasický letecký cesty(nebo jsem je nenašel...), a nevím jak mu nastavit aby lítal tak jak chci....

Díky za odpověď...

//End Czech

All revs which I am tried, this one is 7809, DB isn't important - MaNGOS did not even connect.

mangos.exe & realmd.exe crashs immediately after start (screen).

I tried many precompiled revs, but i can't compile MaNGOS by myself, because I don't know how to add ScriptDev2 and ACID to project...

This happens to me on really old computer: AMD Duron 900 Mhz, 384 MB SDRAM....

original .dmp file

EDIT: But wehen i tried to compile it again now (successfully), everything works fine...maybe its because I used Visual C++ 2005, and all precompiled repacks were from Visual C++ 2008...

PS: Sorry for my bad english ...

Microsoft (R) Windows Debugger Version 6.11.0001.404 X86
Copyright (c) Microsoft Corporation. All rights reserved.


Loading Dump File [C:\\Documents and Settings\\Vojtěch Boček\\Plocha\\mangos2.dmp]
User Mini Dump File with Full Memory: Only application data is available

Comment: 'Dr. Watson generated MiniDump'
Symbol search path is: C:\\symbols;srv*C:\\Symbols*[url]http://msdl.microsoft.com/download/symbols[/url]
Executable search path is: 
Windows XP Version 2600 (Service Pack 2) UP Free x86 compatible
Product: WinNt, suite: SingleUserTS
Machine Name:
Debug session time: Mon Jul 20 21:38:47.000 2009 (GMT+2)
System Uptime: 0 days 11:53:01.245
Process Uptime: 0 days 0:00:08.000
.......................
This dump file has an exception of interest stored in it.
The stored exception information can be accessed via .ecxr.
(128.9c0): Illegal instruction - code c000001d (first/second chance not available)
eax=00ae3f80 ebx=00000000 ecx=00ae3f5c edx=00ae3f80 esi=009f1a58 edi=00afe97c
eip=00412ad5 esp=0012fda0 ebp=0012fedc iopl=0         nv up ei pl zr na pe nc
cs=001b  ss=0023  ds=0023  es=0023  fs=003b  gs=0000             efl=00000246
*** ERROR: Symbol file could not be found.  Defaulted to export symbols for mangosd.exe - 
mangosd!std::stack<MovementGenerator *,std::Deque<MovementGenerator *,std::allocator<MovementGenerator *> > >::_Get_container+0x1465:
00412ad5 f30f10055c239f00 movss   xmm0,dword ptr [mangosd!GridReference<Corpse>::`vftable'+0xb0 (009f235c)] ds:0023:009f235c=40800000
0:000> !analyze -v
*******************************************************************************
*                                                                             *
*                        Exception Analysis                                   *
*                                                                             *
*******************************************************************************

*** WARNING: Unable to verify checksum for libmySQL.dll
*** ERROR: Symbol file could not be found.  Defaulted to export symbols for libmySQL.dll - 
*** ERROR: Symbol file could not be found.  Defaulted to export symbols for libeay32.dll - 
*** ERROR: Symbol file could not be found.  Defaulted to export symbols for ACE.dll - 
*************************************************************************
***                                                                   ***
***                                                                   ***
***    Your debugger is not using the correct symbols                 ***
***                                                                   ***
***    In order for this command to work properly, your symbol path   ***
***    must point to .pdb files that have full type information.      ***
***                                                                   ***
***    Certain .pdb files (such as the public OS symbols) do not      ***
***    contain the required information.  Contact the group that      ***
***    provided you with these symbols if you need this command to    ***
***    work.                                                          ***
***                                                                   ***
***    Type referenced: kernel32!pNlsUserInfo                         ***
***                                                                   ***
*************************************************************************
*************************************************************************
***                                                                   ***
***                                                                   ***
***    Your debugger is not using the correct symbols                 ***
***                                                                   ***
***    In order for this command to work properly, your symbol path   ***
***    must point to .pdb files that have full type information.      ***
***                                                                   ***
***    Certain .pdb files (such as the public OS symbols) do not      ***
***    contain the required information.  Contact the group that      ***
***    provided you with these symbols if you need this command to    ***
***    work.                                                          ***
***                                                                   ***
***    Type referenced: kernel32!pNlsUserInfo                         ***
***                                                                   ***
*************************************************************************

FAULTING_IP: 
mangosd!std::stack<MovementGenerator *,std::Deque<MovementGenerator *,std::allocator<MovementGenerator *> > >::_Get_container+1465
00412ad5 f30f10055c239f00 movss   xmm0,dword ptr [mangosd!GridReference<Corpse>::`vftable'+0xb0 (009f235c)]

EXCEPTION_RECORD:  ffffffff -- (.exr 0xffffffffffffffff)
ExceptionAddress: 00412ad5 (mangosd!std::stack<MovementGenerator *,std::Deque<MovementGenerator *,std::allocator<MovementGenerator *> > >::_Get_container+0x00001465)
  ExceptionCode: c000001d (Illegal instruction)
 ExceptionFlags: 00000000
NumberParameters: 0

PROCESS_NAME:  mangosd.exe

ERROR_CODE: (NTSTATUS) 0xc000001d - {V JIMKA}  Neplatn  instrukce.  Prob

EXCEPTION_CODE: (NTSTATUS) 0xc000001d - {V JIMKA}  Neplatn  instrukce.  Prob

NTGLOBALFLAG:  0

APPLICATION_VERIFIER_FLAGS:  0

FAULTING_THREAD:  000009c0

DEFAULT_BUCKET_ID:  STATUS_ILLEGAL_INSTRUCTION

PRIMARY_PROBLEM_CLASS:  STATUS_ILLEGAL_INSTRUCTION

BUGCHECK_STR:  APPLICATION_FAULT_STATUS_ILLEGAL_INSTRUCTION

LAST_CONTROL_TRANSFER:  from 0040696c to 00412ad5

STACK_TEXT:  
WARNING: Stack unwind information not available. Following frames may be wrong.
0012fedc 0040696c 0e8cc36c 00ae3f58 003c2da0 mangosd!std::stack<MovementGenerator *,std::Deque<MovementGenerator *,std::allocator<MovementGenerator *> > >::_Get_container+0x1465
0012ff30 0092cbc0 0e8cc330 00ae3f58 009f1a54 mangosd!Database::Database+0x3c
0012ff6c 009e146d 0012ff80 78542201 00000001 mangosd!DatabaseMysql::DatabaseMysql+0x30
0012ff74 78542201 00000001 0012ffc0 0043914d mangosd!std::_Init_locks::operator=+0x439df
0012ff80 0043914d 009f1a50 009f1dcc 0e8cc39c msvcr90!_initterm+0x13 [f:\\dd\\vctools\\crt_bld\\self_x86\\crt\\src\\crt0dat.c @ 903]
0012ffc0 7c816d4f 00360036 00370036 7ffdc000 mangosd!Reference<GridRefManager<Corpse>,Corpse>::getSource+0x20f8d
0012fff0 00000000 00439352 00000000 78746341 kernel32!BaseProcessStart+0x23


STACK_COMMAND:  ~0s; .ecxr ; kb

FAILED_INSTRUCTION_ADDRESS: 
mangosd!std::stack<MovementGenerator *,std::Deque<MovementGenerator *,std::allocator<MovementGenerator *> > >::_Get_container+1465
00412ad5 f30f10055c239f00 movss   xmm0,dword ptr [mangosd!GridReference<Corpse>::`vftable'+0xb0 (009f235c)]

FOLLOWUP_IP: 
mangosd!std::stack<MovementGenerator *,std::Deque<MovementGenerator *,std::allocator<MovementGenerator *> > >::_Get_container+1465
00412ad5 f30f10055c239f00 movss   xmm0,dword ptr [mangosd!GridReference<Corpse>::`vftable'+0xb0 (009f235c)]

SYMBOL_STACK_INDEX:  0

SYMBOL_NAME:  mangosd!std::stack<MovementGenerator *,std::Deque<MovementGenerator *,std::allocator<MovementGenerator *> > >::_Get_container+1465

FOLLOWUP_NAME:  MachineOwner

MODULE_NAME: mangosd

IMAGE_NAME:  mangosd.exe

DEBUG_FLR_IMAGE_TIMESTAMP:  4a06d519

FAILURE_BUCKET_ID:  STATUS_ILLEGAL_INSTRUCTION_c000001d_mangosd.exe!std::stack_MovementGenerator_*,std::Deque_MovementGenerator_*,std::allocator_MovementGenerator_*_____::_Get_container

BUCKET_ID:  APPLICATION_FAULT_STATUS_ILLEGAL_INSTRUCTION_BAD_IP_mangosd!std::stack_MovementGenerator_*,std::Deque_MovementGenerator_*,std::allocator_MovementGenerator_*_____::_Get_container+1465

WATSON_STAGEONE_URL:  [url]http://watson.microsoft.com/StageOne/mangosd_exe/0_0_0_0/4a06d519/mangosd_exe/0_0_0_0/4a06d519/c000001d/00012ad5.htm?Retriage=1[/url]

Followup: MachineOwner
---------