Wojta

February 10, 2010

Repo updated to [9354].

February 8, 2010

I think its related to http://github.com/mangos/mangos/commit/defd3a9274c3935509371383e225958fa63d0e20

February 2, 2010

Why is it that I keep on getting this even if I've configured the configuration.php correctly?
Internal Server Error:

Can not execute query to mangos database ("mangos")!

Check you configuration.php for correct values.

I had same problem with character database, configuration was correct, so i just commented ( "/*" and "*/") this connection check and everything is fine

February 1, 2010

One bug - visual effect (not damage) of blizzard (and Rain of Fire I guess) does not end when caster stop channeling - with my 10% haste (which is not very much), visual effect continue about 1s after end of spell. Not serious bug, but does anybody know how to fix it?

January 29, 2010

As you suggested V1b: http://pastebin.ca/1770596.

I used

int32 ticks = int32(duration / periodic);

because I did not know if compiler get over this without int32 - result can be float.

January 28, 2010

What about that:

V1a: http://pastebin.ca/1769835

January 28, 2010

If you apply full haste to periodic time, ticks will be too short, now its like in tooltip, isnt it?

EDIT:

SPELL: 42846, m_maxduration: 4880, periodic: 976, ticks: 5.000000 and in tooltip is "..every 0.98 for 4.88". I will try just apply haste to periodic time...

EDIT2:

with just haste apply on periodic time its...

SPELL: 42846, m_maxduration: 4880, periodic: 975, ticks: 5.000000

I will try it with blizzard, there should be bigger difference....

EDIT3:

Blizzard

SPELL: 27085, m_maxduration: 7808, periodic: 976, ticks: 8.000000 - just with haste

SPELL: 27085, m_maxduration: 7808, periodic: 975, ticks: 8.000000 - my calculation

Penance

(Tooltip says ".. every 0.98 for 1.95") but thats crazy..penance does not get 3 ticks, only two... what the..? Oh...maybe because penance does not get first instant shot, and...thats caused by my patch...i will fix it

SPELL: 52988, m_maxduration: 1950, periodic: 975, ticks: 2.000000 - my calculation

SPELL: 52988, m_maxduration: 1950, periodic: 975, ticks: 2.000000 - just apply haste

hmm its almost same, but it looks like haste/ticks idea is correct...

EDIT4:

wait, priest on my server says that first tick of penance was never instant....

January 28, 2010

I tried it with many different haste ratings and I never lost last tick. Yes, its possible, but time is in ms, so even if its by one ms higher, I think its ok.

EDIT: hmm but it can be 1ms/tick higher....so for example blizzard (16 ticks) can really lost one tick...damn your right, I'll try to rewrite this.

January 27, 2010

Gives your Chill effects a 15% chance to grant you the Fingers of Frost effect, which treats your next 2 spells cast as if the target were Frozen. Lasts 15 sec.
Is bug

In spell tooltip? I dont see it.

January 26, 2010

I reverted it and it seems that its "stable" now. Uptime 2 hours and 16 min now(345 ppl), before it was 30-40 min max.

January 20, 2010

For flying vehicles I using this in my master branch: http://github.com/Tasssadar/Valhalla-Project/commit/f5aa6072bcd0a8fa1e498a26ea2d4eff9d941c0f

but its hacky, so I dont put it in vehicle branch.

http://github.com/Tasssadar/Valhalla-Project/commit/055b29706250538482080a221e48ccf68294ffcb - vehicles does not damage itself anymore...

and http://github.com/Tasssadar/Valhalla-Project/commit/07a89d6dd2b8b4d0bd634148b26e33164457a09e - vehicle combo points, packet structure from TC2.

January 19, 2010

Ok, my vehicle branch is up-to-date now, but I cant test it due to compile error on revision 9212, but everything should work fine because I using this patch in my master branch without problem

Tomorrow I will look at this thread again If I will have some time and add some new stuffs into my branch.

January 19, 2010

What? Did I say that I have custom patches? This is from clean mangos.

EDIT: But, you remind me vehicle branch - i will update it now.

EDIT2: wow, you must be really angry that i did not keep it up-to-date, as I look into some topics But i really dont read everything on mangos forum, one PM would be enough

EDIT3: Its up-to-date now, but due to this mangos compile error, i cant test it.

January 19, 2010

Hello,

since 9212 i get this:

../../../src/game/TargetedMovementGenerator.cpp:286: error: specialization of ‘void FollowMovementGenerator<T>::_updateSpeed(T&) [with T = Player]’ after instantiation
../../../src/game/TargetedMovementGenerator.cpp:292: error: specialization of ‘void FollowMovementGenerator<T>::_updateSpeed(T&) [with T = Creature]’ after instantiation

Comments on github are not working and nobody mentioned this, so I post it here.

December 30, 2009

you are aware that there are DEFINITE errors in the vehicle branch?
when you clone mangos and then pull the vehicle branch it LOOKS like it pulls clean but in actuality it writes a whole bad merge into pet.cpp complete with <<<<<<HEAD statements

¨

Sorry, my bad, its fixed now.

December 29, 2009

hmm...I think if we make vehicle spells able to target gobjects and destroy them, then, with this vehicle patch, we will be able to make Strand of the ancients working. What do you think?

Add anticheat on this branch?

...

December 27, 2009

core 9034

How GetMap() can be NULL ? During Teleport ?

../../../src/game/Object.h:501: Error: Assertion in GetMap failed: m_currMap
Stack Trace:
/home/git/core/bin/mangos-worldd(_ZN5Group22UpdatePlayerOutOfRangeEP6Player+0xaf) [0x57e6cf]
/home/git/core/bin/mangos-worldd(_ZN6Player34SendUpdateToOutOfRangeGroupMembersEv+0x22) [0x652ce2]
/home/git/core/bin/mangos-worldd(_ZN6Player6UpdateEj+0x574) [0x69b824]
/home/git/core/bin/mangos-worldd(_ZN3Map6UpdateERKj+0x5c) [0x5e11ec]
/home/git/core/bin/mangos-worldd(_ZN10MapManager6UpdateEj+0x87) [0x5f0107]
/home/git/core/bin/mangos-worldd(_ZN5World6UpdateEj+0x616) [0x75d936]
/home/git/core/bin/mangos-worldd(_ZN13WorldRunnable3runEv+0xd1) [0x4eb1b1]
/home/git/core/bin/mangos-worldd(_ZN9ACE_Based6Thread10ThreadTaskEPv+0x1c) [0x80119c]
/lib/libpthread.so.0 [0x7ff6bedc4fc7]
/lib/libc.so.6(clone+0x6d) [0x7ff6be3945ad]
[Thread 0x413d1950 (LWP 8733) exited]
[New Thread 0x413d1950 (LWP 8734)]
[New Thread 0x42394950 (LWP 8735)]
[New Thread 0x42b95950 (LWP 8736)]
[New Thread 0x43396950 (LWP 8793)]
[New Thread 0x40a48950 (LWP 8794)]
[New Thread 0x43b97950 (LWP 8795)]
[New Thread 0x44398950 (LWP 8796)]
[New Thread 0x44b99950 (LWP 8797)]
[New Thread 0x4539a950 (LWP 8798)]
[New Thread 0x45b9b950 (LWP 8799)]
[New Thread 0x4639c950 (LWP 8800)]
[New Thread 0x46b9d950 (LWP 8801)]

Program received signal SIGABRT, Aborted.
[switching to Thread 0x40a48950 (LWP 8794)]
0x00007ff6be2f6ed5 in raise () from /lib/libc.so.6
#0  0x00007ff6be2f6ed5 in raise () from /lib/libc.so.6
#1  0x00007ff6be2f83f3 in abort () from /lib/libc.so.6
#2  0x00007ff6be2efdc9 in __assert_fail () from /lib/libc.so.6
#3  0x00000000004f538b in WorldObject::GetMap (this=<value optimized out>)
   at ../../../src/game/Object.h:501
#4  0x0000000000652d60 in Player::GetViewPoint (this=0x7ff6573aeca0)
   at ../../../src/game/Player.cpp:18586
#5  0x000000000057e6cf in Group::UpdatePlayerOutOfRange (
   this=<value optimized out>, pPlayer=0x7ff649f0f970)
   at ../../../src/game/Group.cpp:1041
#6  0x0000000000652ce2 in Player::SendUpdateToOutOfRangeGroupMembers (
   this=0x7ff649f0f970) at ../../../src/game/Player.cpp:18950
#7  0x000000000069b824 in Player::Update (this=0x7ff649f0f970, p_time=114)
   at ../../../src/game/Player.cpp:1382
#8  0x00000000005e11ec in Map::Update (this=0x52120b0, t_diff=@0x40a47bec)
   at ../../../src/game/Map.cpp:595
#9  0x00000000005f0107 in MapManager::Update (this=0xb86c590, 
   diff=<value optimized out>) at ../../../src/game/MapManager.cpp:265
#10 0x000000000075d936 in World::Update (this=0x7ff6b80236a0, diff=114)
   at ../../../src/game/World.cpp:1690
#11 0x00000000004eb1b1 in WorldRunnable::run (this=<value optimized out>)
   at ../../../src/mangosd/WorldRunnable.cpp:60
#12 0x000000000080119c in ACE_Based::Thread::ThreadTask (param=0x2209)
   at ../../../src/shared/Threading.cpp:183
#13 0x00007ff6bedc4fc7 in start_thread () from /lib/libpthread.so.0
#14 0x00007ff6be3945ad in clone () from /lib/libc.so.6
#15 0x0000000000000000 in ?? ()
#0  0x00007ff6be2f6ed5 in raise () from /lib/libc.so.6
No symbol table info available.
#1  0x00007ff6be2f83f3 in abort () from /lib/libc.so.6
No symbol table info available.
#2  0x00007ff6be2efdc9 in __assert_fail () from /lib/libc.so.6
No symbol table info available.
#3  0x00000000004f538b in WorldObject::GetMap (this=<value optimized out>)
   at ../../../src/game/Object.h:501
   st = {static SYMBUFSIZ = 4096, 
 buf_ = "/home/git/core/bin/mangos-worldd(_ZN5Group22UpdatePlayerOutOfRangeEP6Player+0xaf) [0x57e6cf]\\n/home/git/core/bin/mangos-worldd(_ZN6Player34SendUpdateToOutOfRangeGroupMembersEv+0x22) [0x652ce2]\\n/home/gi"..., buflen_ = 720, 
 static UNSUPPORTED = 0x7ff6c02e84a0 "<stack traces unsupported platform>", 
 static UNABLE_TO_GET_TRACE = 0x7ff6c02e84d0 "<unable to get trace>"}
   __FUNCTION__ = "GetMap"
   __PRETTY_FUNCTION__ = "Map* WorldObject::GetMap() const"
#4  0x0000000000652d60 in Player::GetViewPoint (this=0x7ff6573aeca0)
   at ../../../src/game/Player.cpp:18586
   viewPoint = (const class WorldObject *) 0x7ff6573aeca0
   far_sight = 17388398644142538753
#5  0x000000000057e6cf in Group::UpdatePlayerOutOfRange (
   this=<value optimized out>, pPlayer=0x7ff649f0f970)
   at ../../../src/game/Group.cpp:1041
   itr = (class GroupReference *) 0x7ff6573b1520
   player = (class Player *) 0x7ff6573aeca0
   data = {<ByteBuffer> = {static DEFAULT_SIZE = 4096, _rpos = 0, 
   _wpos = 10, 
   _storage = {<std::_Vector_base<unsigned char, std::allocator<unsigned char> >> = {
       _M_impl = {<std::allocator<unsigned char>> = {<__gnu_cxx::new_allocator<unsigned char>> = {<No data fields>}, <No data fields>}, 
         _M_start = 0x7ff63a2fb840 "\\aÅÛ\\003\\200", 
         _M_finish = 0x7ff63a2fb84a "%\\001ö\\177", 
         _M_end_of_storage = 0x7ff63a2fb84e ""}}, <No data fields>}}, 
 m_opcode = 126}
#6  0x0000000000652ce2 in Player::SendUpdateToOutOfRangeGroupMembers (
   this=0x7ff649f0f970) at ../../../src/game/Player.cpp:18950
   group = (Group *) 0x2209
#7  0x000000000069b824 in Player::Update (this=0x7ff649f0f970, p_time=114)
   at ../../../src/game/Player.cpp:1382
   now = 1261564121
   pet = <value optimized out>
#8  0x00000000005e11ec in Map::Update (this=0x52120b0, t_diff=@0x40a47bec)
   at ../../../src/game/Map.cpp:595
   plr = (class Player *) 0x2209
   updater = {i_timeDiff = 1084521452}
   grid_object_update = {i_visitor = @0x72}
   world_object_update = {i_visitor = @0x40a47b90}
   __PRETTY_FUNCTION__ = "virtual void Map::Update(const uint32&)"
#9  0x00000000005f0107 in MapManager::Update (this=0xb86c590, 
   diff=<value optimized out>) at ../../../src/game/MapManager.cpp:265
No locals.
#10 0x000000000075d936 in World::Update (this=0x7ff6b80236a0, diff=114)
   at ../../../src/game/World.cpp:1690
   autobroadcaston = 0
#11 0x00000000004eb1b1 in WorldRunnable::run (this=<value optimized out>)
   at ../../../src/mangosd/WorldRunnable.cpp:60
   diff = 114
   realCurrTime = 3138703624
   realPrevTime = <value optimized out>
   prevSleepTime = 0
#12 0x000000000080119c in ACE_Based::Thread::ThreadTask (param=0x2209)
   at ../../../src/shared/Threading.cpp:183
   _task = (class ACE_Based::Runnable *) 0x7ff6b8e40e10
#13 0x00007ff6bedc4fc7 in start_thread () from /lib/libpthread.so.0
No symbol table info available.
#14 0x00007ff6be3945ad in clone () from /lib/libc.so.6
No symbol table info available.
#15 0x0000000000000000 in ?? ()
No symbol table info available.
 14 Thread 0x46b9d950 (LWP 8801)  0x00007ff6be394b78 in epoll_wait ()
  from /lib/libc.so.6
 13 Thread 0x4639c950 (LWP 8800)  0x00007ff6be394b78 in epoll_wait ()
  from /lib/libc.so.6
 12 Thread 0x45b9b950 (LWP 8799)  0x00007ff6be394b78 in epoll_wait ()
  from /lib/libc.so.6
 11 Thread 0x4539a950 (LWP 8798)  0x00007ff6bedcb7db in read ()
  from /lib/libpthread.so.0
 10 Thread 0x44b99950 (LWP 8797)  0x00007ff6be394b78 in epoll_wait ()
  from /lib/libc.so.6
 9 Thread 0x44398950 (LWP 8796)  0x00007ff6bedcc0e1 in nanosleep ()
  from /lib/libpthread.so.0
 8 Thread 0x43b97950 (LWP 8795)  0x00007ff6be362ff1 in nanosleep ()
  from /lib/libc.so.6
* 7 Thread 0x40a48950 (LWP 8794)  0x00007ff6be2f6ed5 in raise ()
  from /lib/libc.so.6
 6 Thread 0x43396950 (LWP 8793)  0x00007ff6bedcc0e1 in nanosleep ()
  from /lib/libpthread.so.0
 5 Thread 0x42b95950 (LWP 8736)  0x00007ff6bedcc0e1 in nanosleep ()
  from /lib/libpthread.so.0
 4 Thread 0x42394950 (LWP 8735)  0x00007ff6bedcc0e1 in nanosleep ()
  from /lib/libpthread.so.0
 3 Thread 0x413d1950 (LWP 8734)  0x00007ff6bedcc0e1 in nanosleep ()
  from /lib/libpthread.so.0
 1 Thread 0x7ff6c07466f0 (LWP 8713)  0x00007ff6bedc5715 in pthread_join ()
  from /lib/libpthread.so.0

Same error, happens if hunter enter (heroic) instance with http://www.wowhead.com/?spell=58983. wtf?

December 27, 2009

I have a question for the people running Tasssadar's repo... is it me or os there something wrong with scriptdev2 repo there (tasssadar/valhalla-project-scriptdev2.git)
3raZar3

what wrong with it? maybe some compile errors because i expect my custom patches(for example completeAchievement() hack...) in mangos

December 26, 2009

no
see:
if (obj &&

yeah...but my experience is that whole if is checked, no only first argument, even if theres && operator...so

 if (obj && m_target->GetDistance(obj) <= 40.0f)

check for obj, and then for "m_target->GetDistance(obj) <= 40.0f" in any case - and if obj is null->crash...?

December 24, 2009

Im using this patch:

http://github.com/Tasssadar/Valhalla-Project/commit/3d9c4a98d36a5b9eb14beef389ba01b9584f5701 and

http://github.com/Tasssadar/Valhalla-Project/commit/586a09e9a3250fdfe76c32bf41e7e906be8d1542

on server with 400 ppl, no serious problems found.

EDIT:

        if (apply)
       {
           GameObject* obj = m_target->GetGameObject(48018);
           if (obj [b]&& m_target->GetDistance(obj) <= 40.0f[/b])
               ((Player*)m_target)->TeleportTo(obj->GetMapId(),obj->GetPositionX(),obj->GetPositionY(),obj->GetPositionZ(),obj->GetOrientation());
       }

This crash server when obj is NULL, isnt it?

December 22, 2009

Hello Wojta,
why have you merge your vehicle branch with your custom patchs (spell debugs) ?

Because I using my master branch as main source for my server - and I using this vehicle patch (well, I will - mangos is extremly unstable now, so I have to wait)

EDIT: Ah, my bad - wrong selected branch when push Now its fine

December 21, 2009

Yeah, works perfect

December 21, 2009

I have remastered the regen system for vehicles. And now there are works a vehicles like Salvaged Chopper.
Added new data for vahicle_* tables. Thanks to gen1us2k

PS to Wojta. When you'll apply the patch add my "signed-off".

Thanks. http://github.com/Tasssadar/Valhalla-Project/commit/d46ceee93a5deadf7ca3bb7f75a2192a573f9d8b

Looks like I did not put your signed-off correctly into commit. I am so sorry, I never did this and it looks like just put it into commit is not correct

December 18, 2009

ERROR: Attempted to get in ByteBuffer (pos: 44 size: 47) value with size: 4
WorldSession::Update ByteBufferException occured while parsing a packet (opcode: 1179) from client 83.240.110.109, accountid=1254332. Skipped packet.

bad news...I get this when I try to switch seat, even if there is no accessory in vehicle...

December 17, 2009

at the moment any of the vehicles seat has accesories ?

yes. Maybe current function to handle packet works fine, but this error does not allow to execute it

Sign In

Profiles

Bug Tracker

Wiki

Release Notes

Forums

Downloads

Blogs

Events

Posts posted by Wojta

Contact Us

Repositories

Important Information