xarly

Hi, in VS2010 I changed Optimization to: disabled (/Od) and Inline to: disabled (/Ob0). Should this make mangos work better, or poorer ? Is there any configuration in VS2010 to make mangos more stable? and also, my server is w2003 Ent x64, so I compile in x64, but I have heard that x64 is more unstable and can crash more often, it would be better x32? Thank you!

Hi! I have a crash that is usually the same, this one: https://gist.github.com/729500 Since it looks like is some spell, I wonder if can be possible know the spell that is causing the crash with the crashlog. I have seen in crash, under "Local Variables", this: Local unsigned int 'spellId' = 385E01CD but i don't know if can be useful or how get the entry id with that Thank you

I answer myself, i have seen other vendors that do what i say, and investigating i have discovered (for me ) the field BuyCount in item_template. That's all, thank you anyway

I think that is not possible, I ask for buy 3 or whatever you say in db for the same price. You would be buying a stack of X items for the price that npc says.

, i will try to explain better By default (i think) when you go to a npc vendor, you will see (A picture is worth a thousand words) something like for example: http://img253.imageshack.us/img253/3753/badgegem.jpg and i suggest the possibility of do this: http://img838.imageshack.us/img838/1310/badgegemcopia.jpg I have been looking and i think this cannot be done now, but i think that it's interesting

I wonder if can be possible to add stacks to vendor, for example, make possible to buy 5 items at once not five times one item. If not, i think would be interesting do this option Thank you

I know that this post is quite old, but with this patch, UnloadGrid crashes would be fixed? Thank you

Where can be modified rewards? For example if i select random heroic dungeon it rewards 2 emblems and money but I have seen "lfg_dungeon_rewards" and rewards for those quests are not emblems and money, just things like "Satchel of Helpful Goods" How does rewards works? Thank you

I think KiriX means that when doungeon ends (you kill all bosses) nothing happens, system does't send rewards

Thank you darkstaller! but seems that doesn't work :'( it looks like the condition is not evaluated or never is true (even having the quest), but for example i have tried with only a if if (pPlayer->GetQuestStatus(11111) == QUEST_STATUS_INCOMPLETE) { } like this it works, but with for and array doesn't... I want to know this because i want to start to script some quests, and many of them have the same name but different IDs depending team or faction.

Power to the imagination! gg i found solution probably not the most optimal but should work defining a struct, then a variable type array with that struct and its done Thank you anyway

Thank you Mango, i didn't realized that option the only thing and maybe the most difficult is the second part, how to compare each value in enum with a condition enum QUESTS { QUEST1 = 1, QUEST2 = 2, QUEST3 = 3, QUEST4 = 4 } #define MAX_QUEST 4 for (uint8 i = 0; i < MAX_QUEST ; I++) { if ( pPlayer->GetQuestStatus( EACH QUEST# IN ENUM ) == QUEST_STATUS_INCOMPLETE ) ... } I don't know how do that, maybe it's impossible in this way... Thank you

I need some help in C++ I need a structure like for, able to go over a enum define, for example enum QUESTS { QUEST1 = 11111, QUEST2 = 22222, QUEST3 = 33333, QUEST4 = 44444 }; and then for (uint8 i = 0; i < /*QUESTS LENGHT*/; I++) { if ( pPlayer->GetQuestStatus(/*QUESTS [i]*/) == QUEST_STATUS_INCOMPLETE ) ... } you know what i mean? I have found solution for C#, but using foreach. Can you help me? Thank you!

I have comented code line if (!m_IsTriggeredSpell && NeedsComboPoints(m_spellInfo) && (!m_targets.getUnitTarget() || m_targets.getUnitTarget()->GetObjectGuid() != ((Player*)m_caster)->GetComboTargetGuid())) return SPELL_FAILED_NO_COMBO_POINTS; its an ugly fix, but now Overpower works jej

Thank you Edder, if you want to improve the patch, i think that would be a good thing the possibility of specify an end date for the bonus, you know what i mean? Would be more unnatended - you set manually the bonus - After 1 month (or whatever) system itself disable the bonus I think this could be done adding two columns in sql like 'enddate' and 'active' and some code in Player::LoadFromDB Thank you

There is a problem with Overpower, it says that requires combo points, and warrior has not combo points.. I think this ocurrs after [10636]. Can you confirm this? Thank you

My last 10 crashes are the same, always FreezeDetectorRunnable Revision: * * 10632 5c48f96415de0c4ec493785ea29fd84104d37a72 Date 21:10:2010. Time 9:44 //===================================================== *** Hardware *** Processor: Intel(R) Core(TM) i7 CPU 920 @ 2.67GHz Number Of Processors: 8 Physical Memory: 12573508 KB (Available: 4428836 KB) Commit Charge Limit: 16221748 KB *** Operation System *** Microsoft Windows Server 2003 Enterprise Edition Service Pack 2 (Version 5.2, Build 3790) //===================================================== Exception code: C0000005 ACCESS_VIOLATION Fault address: 000000014004B754 01:000000000004A754 M:\\UltimoWoW\\mangosd.exe Registers: RAX:0000000000000000 RBX:0000000000000000 RCX:00000000797E6D08 RDX:0000000000000002 RSI:000007FFDD9A8518 RDI:000007FFDD9A8518 R8: 0000000008C9E2F0 R9: 0000000000000000 R10:0000000000000246 R11:0000000000000000 R12:0000000000000000 R13:0000000000000000 R14:0000000000000000 R15:000007FF00000001 CS:RIP:0033:000000014004B754 SS:RSP:002B:0000000008C9FE80 RBP:00000000 DS:002B ES:002B FS:0053 GS:002B Flags:00010202 Call stack: Address Frame Function SourceFile 000000014004B754 0000000008C9FEA0 FreezeDetectorRunnable::run+A4 src\\mangosd\\master.cpp line 104 000000014005D95F 0000000008C9FED0 ACE_Based::Thread::ThreadTask+F src\\shared\\threading.cpp line 190 00000000003F0CE5 0000000008C9FF10 ?invoke@ACE_OS_Thread_Adapter@@UEAAKXZ+55 0000000079751DB7 0000000008C9FF40 _endthreadex+43 0000000079751E53 0000000008C9FF70 _endthreadex+DF 0000000077D6B71A 0000000008C9FFA0 BaseThreadStart+3A Any idea? Thx

SQL doesn't correspond with code, SQL should be something like this CREATE TABLE `character_xp_rate` ( `guid` int(11) unsigned NOT NULL DEFAULT '0' COMMENT 'Global Unique Identifier', `xp_rate` tinyint(3) unsigned NOT NULL DEFAULT '1' COMMENT 'Experience Multiplier', PRIMARY KEY (`guid`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 ROW_FORMAT=COMPACT And I think code is incomplete, it can crash the server by several ways

This patch must be used wisely, obviously if you have one player in the server, disable it! Use your efforts on search for real players and not in patches like this , but if you use to have more than 400 o more, you can increase the number without arouse suspicions gg

If you don't want to touch DB and many lines of code you can use my patch. It only increment count number X players found (showing 50). Also increment can be modified by mangosd.conf, very simple! @MiscHandler.cpp uint32 count = m.size(); data.put( 0, clientcount ); // insert right count, listed count - data.put( 4, count > 50 ? count : clientcount ); // insert right count, online count + data.put( 4, count > 50 ? ( count + sWorld.getConfig(CONFIG_UINT32_WHO_COUNT_BASE) ) : ( clientcount + sWorld.getConfig(CONFIG_UINT32_WHO_COUNT_BASE) ) ); // insert right count, online count SendPacket(&data); DEBUG_LOG( "WORLD: Send SMSG_WHO Message" ); @World.h CONFIG_UINT32_MIN_LEVEL_STAT_SAVE, CONFIG_UINT32_CHARDELETE_KEEP_DAYS, CONFIG_UINT32_CHARDELETE_METHOD, CONFIG_UINT32_CHARDELETE_MIN_LEVEL, CONFIG_UINT32_RANDOM_BG_RESET_HOUR, - CONFIG_UINT32_VALUE_COUNT + CONFIG_UINT32_VALUE_COUNT, + CONFIG_UINT32_WHO_COUNT_BASE }; @World.cpp setConfig(CONFIG_UINT32_ARENA_SEASON_ID, "Arena.ArenaSeason.ID", 1); setConfig(CONFIG_BOOL_ARENA_SEASON_IN_PROGRESS, "Arena.ArenaSeason.InProgress", true); setConfigMin(CONFIG_INT32_ARENA_STARTRATING, "Arena.StartRating", -1, -1); setConfigMin(CONFIG_INT32_ARENA_STARTPERSONALRATING, "Arena.StartPersonalRating", -1, -1); + + setConfig(CONFIG_UINT32_WHO_COUNT_BASE, "WhoCountBase", 0); @mangosd.conf (at the end) +############ +#Modify Who Count +# 0 = disabled (default) +############ + WhoCountBase = 100

Debugging with Visual studio 2008 i have get this call stack CALLSTACK msvcr90.dll!000000007862fea4() mangosd.exe!vutf8printf(_iobuf * out=0x00000000786af600, const char * str=0x0000000140889860, char * * ap=0x0000000002f2fbe0) Línea 471 C++ mangosd.exe!Log::outDebug(const char * str=0x0000000140889860, ...) Línea 637 C++ > mangosd.exe!DatabaseMysql::DirectExecute(const char * sql=0x000007ffb7b80c00) Línea 316 + 0xc0 bytes C++ mangosd.exe!SqlTransaction::Execute(Database * db=0x0000000140a2de50) Línea 42 + 0x1b bytes C++ mangosd.exe!SqlDelayThread::run() Línea 48 C++ mangosd.exe!ACE_Based::Thread::ThreadTask(void * param=0x000007fffff83d60) Línea 190 C++ ACE.dll!00000000006f139b() msvcr90.dll!0000000078622fdf() msvcr90.dll!0000000078623080() kernel32.dll!0000000077d6b71a() VARIABLES INSIDE EACH FUNCTION mangosd.exe!vutf8printf + out 0x00000000786af600 {_ptr=0x00000000023b3326 "etType FROM character_pet WHERE owner = '28697' AND slot = '0'exettalents_cost,resettalents_time, trans_x, trans_y, trans_z, trans_o, transguid, extra_flags, stable_slots, at_login, zone, online, death_expire_time, taxi_path, dungeon_difficulty,arenaPoints, totalHonorPoints, todayHonorPoints, yesterdayHonorPoints, totalKills, todayKills, yesterdayKill _iobuf * + str 0x0000000140889860 "[%u ms] SQL: %s" const char * + ap 0x0000000002f2fbe0 char * * + wtemp_buf 0x0000000002f1fba0 "[0 ms] SQL: INSERT INTO character_account_data VALUES ('28697','1','1283550350','SET minimapZoom \\"0\\"\\nSET minimapInsideZoom \\"0\\"\\nSET questLogCollapseFilter \\"-1\\"\\nSET trackedQuests \\" wchar_t [32768] + temp_buf 0x0000000002f17ba0 "[0 ms] SQL: INSERT INTO character_account_data VALUES ('28697','1','1283550350','SET minimapZoom \\"0\\"\\nSET minimapInsideZoom \\"0\\"\\nSET questLogCollapseFilter \\"-1\\"\\nSET trackedQuests \\"v$Zy#P^#M%#S>#{#OY#SI\\"\\nSET trackedAchievements \\"v\\"\\nSET cameraSavedDistance \\"14.000399\\"\\nSET cameraSavedPitch \\"13.350006\\"\\nSET showKeyring \\"1\\"\\nSET playerStatLeftDropdown \\"PLAYE char [32768] wtemp_len 486 unsigned __int64 temp_len 486 unsigned __int64 mangosd.exe!Log::outDebug + str 0x0000000140889860 "[%u ms] SQL: %s" const char * + this 0x000007fffff83f20 {raLogfile=0x0000000000000000 logfile=0x00000000786af660 gmLogfile=0x0000000000000000 ...} Log * const + ap 0x0000000002f2fc10 "" char * mangosd.exe!DatabaseMysql::DirectExecute _s 108596546 unsigned int + query_connection_guard {lock_=0x0000000140a2df50 owner_=0 } ACE_Guard<ACE_Thread_Mutex> + this 0x0000000140a2de50 class DatabaseMysql CharacterDatabase {mMutex={...} tranThread=0x000007ffe584bfe8 mMysql=0x000000000256f6d0 } DatabaseMysql * const + sql 0x000007ffb7b80c00 "INSERT INTO character_account_data VALUES ('28697','1','1283550350','SET minimapZoom \\"0\\"\\nSET minimapInsideZoom \\"0\\"\\nSET questLogCollapseFilter \\"-1\\"\\nSET trackedQuests \\"v$Zy#P^#M%#S>#{#OY#SI\\"\\nSET trackedAchievements \\"v\\"\\nSET cameraSavedDistance \\"14.000399\\"\\nSET cameraSavedPitch \\"13.350006\\"\\nSET showKeyring \\"1\\"\\nSET playerStatLeftDropdown \\"PLAYERSTAT_BASE_S const char * mangosd.exe!SqlTransaction::Execute + this 0x000007ffb5c41710 {m_queue=[0]() } SqlTransaction * const + sql 0x000007ffb7b80c00 "INSERT INTO character_account_data VALUES ('28697','1','1283550350','SET minimapZoom \\"0\\"\\nSET minimapInsideZoom \\"0\\"\\nSET questLogCollapseFilter \\"-1\\"\\nSET trackedQuests \\"v$Zy#P^#M%#S>#{#OY#SI\\"\\nSET trackedAchievements \\"v\\"\\nSET cameraSavedDistance \\"14.000399\\"\\nSET cameraSavedPitch \\"13.350006\\"\\nSET showKeyring \\"1\\"\\nSET playerStatLeftDropdown \\"PLAYERSTAT_BASE_S char * + db 0x0000000140a2de50 class DatabaseMysql CharacterDatabase {mMutex={...} tranThread=0x000007ffe584bfe8 mMysql=0x000000000256f6d0 } Database * mangosd.exe!SqlDelayThread::run + s 0x000007ffb5c41710 {m_queue=[0]() } SqlOperation * + this 0x000007fffff83d60 SqlDelayThread * const loopSleepms 10 const unsigned int loopCounter 10190 unsigned int pingEveryLoop 180000 const unsigned int mangosd.exe!ACE_Based::Thread::ThreadTask param 0x000007fffff83d60 void * + _task 0x000007fffff83d60 ACE_Based::Runnable * I post this with hope that someone can do something, because I cannot... Also i have to say that I have manymany crashes wich stops in ACE_Based::Thread::ThreadTask. Don't know if is some related to main problem... Thank you

Do you know what would be useful? Would be very useful that gamemasters can see the full list of players connected

Magic!! Suddenly armory has started to work LOL Thank you anyway

I had version 367, today i have done a git pull and updated to 380 and updated sql, and now the site doesn't work... I'm getting this error XML read error: incorrect content after an element of the XML document Location: http://localhost/ Line 3, Column 1: ^ I get this error on evey page for example http://localhost/character-sheet.xml?r=Realm&cn=Olivander I have tryed to delete whole folder and download armory again clean, but it's the same In debug log there is nothing if I try to see a player shows DEBUG [29-08-2010 18:50:55]: Characters::BuildCharacter : all correct, player Olivander (race: 4, class: 11, level: 80) loaded, class has been initialized. but nothing about the problem Can you help me? Thank you very much

Hi, I have found how to debug with visual studio, I'm doing this because I have a crash when executing .gobject near command. When I execute that command server crash, and visual studio points to ChatHandler::PSendSysMessage(int32 entry, ...) This is the call stack msvcr90.dll!0000000073e96b16() msvcr90.dll!0000000073e75564() msvcr90.dll!0000000073e755ad() mangosd.exe!ChatHandler::PSendSysMessage(int entry=517, ...) Línea 927 C++ > mangosd.exe!ChatHandler::HandleGameObjectNearCommand(char * args=0x0000000003ea3a05) Línea 1192 + 0xcb bytes C++ mangosd.exe!ChatHandler::ExecuteCommand(const char * text=0x0000000003ea3a05) Línea 1152 + 0x24 bytes C++ mangosd.exe!ChatHandler::ParseCommands(const char * text=0x0000000003ea39f9) Línea 1285 C++ mangosd.exe!WorldSession::HandleMessagechatOpcode(WorldPacket & recv_data={...}) Línea 173 + 0x4d bytes C++ mangosd.exe!WorldSession::ExecuteOpcode(const OpcodeHandler & opHandle={...}, WorldPacket * packet=0x000007ffeeaee828) Línea 875 C++ mangosd.exe!WorldSession::Update(unsigned int __formal=47) Línea 190 C++ mangosd.exe!World::UpdateSessions(unsigned int diff=47) Línea 1934 + 0x29 bytes C++ mangosd.exe!World::Update(unsigned int diff=47) Línea 1468 C++ mangosd.exe!WorldRunnable::run() Línea 61 C++ mangosd.exe!ACE_Based::Thread::ThreadTask(void * param=0x000007ffef01c220) Línea 190 C++ ACE.dll!ACE_OS_Thread_Adapter::invoke() + 0x5b bytes C++ msvcr90.dll!0000000073e62fdf() msvcr90.dll!0000000073e63080() kernel32.dll!000000007798f56d() ntdll.dll!0000000077ac3281() and variables inside ChatHandler::PSendSysMessage(int32 entry, ...) ap 0x0000000003ea1580 "¦»" char * format 0x000000000227f060 "%d, Entrada %d - |cffffffff|Hobjeto de juego:%d|h[%s X:%f Y:%f Z:%f IdMapa:%d]|h|r " const char * str 0x0000000003ea0d50 "48038, Entrada 65672736 - |cffffffff|Hobjeto de juego:144131|h[" char [2048] this 0x0000000003ea3e18 {m_session=0x000007ffeeacfd00 sentErrorMessage=false } ChatHandler * const also variables inside HandleGameObjectNearCommand LANG_GO_MIXED_LIST_CHAT 517 int entry 144131 unsigned int gInfo 0x000007fffb9e52d8 {id=144131 type=19 displayId=1907 ...} const GameObjectInfo * gInfo->name 0x000007fffc0390b8 "Mailbox" char * guid 48038 unsigned int mapid 1 int this 0x0000000003ea3e18 {m_session=0x000007ffeeacfd00 sentErrorMessage=false } ChatHandler * const x 16219.500 float y 16272.800 float z 12.969600 float But now I don't know what to do, for me variables are ok, in fact has the gameobject which i was near... Could you help me? Thank you